> On Aug. 8, 2012, 8:30 a.m., John Layt wrote: > > Sorry, but I disagree. The separate config settings are for specific > > technical reasons, due to previous user feedback, and for backwards > > compatibility purposes. We have two config settings for Events and > > Holidays due to Events turning on Akonadi which many people don't want to > > use but still want to have Holidays displayed. Until we have a proper > > solution to the Akonadi problem we have to retain the separate config > > options. In any case, the solution would be in modifying the behaviour of > > the GUI, not in changing the backend config. > > > > We used to have separate tick-boxes in the GUI directly mapped to the > > config options, but I changed the Holidays tick-box to the multiple > > holidays selection widget and had to retain the backwards compatible > > behaviour of respecting any existing config setting. You also have the > > usability issue of people ticking the Holiday options but not the Event box > > and wondering why the Holidays don't show, you would need to change the GUI > > to make this obvious. > > > > Also, you seem to have other unrelated code fixes included in the review?
Well, of course we could grey out the holiday selection, if display events is unticked. In the current implementation I think it's awkward that you have to scroll through the entire list and disable every region to hide all events. Maybe a extra tick-box for that really would be better. In this case we could also split up the pim event box into options for every kind of event (todos, events, journals). Actually I don't understand why there is this holiday setting in the widget at all. This holiday calender needs to be merged into akonadi, so the widget show exactly the same events like i.e. korganizer. We have already a Birthday akonadi ressource. Why not simply create a holiday ressource? I could do that, I suppose. What dou you think? That unrelated code is from https://git.reviewboard.kde.org/r/105779/ feel free to review it :) - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/#review17095 ----------------------------------------------------------- On Aug. 8, 2012, 7:35 a.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105924/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 7:35 a.m.) > > > Review request for Plasma and Anne-Marie Mahfouf. > > > Description > ------- > > This patch addresses an usuability issue. The config option 'display events' > enables/disables now all events/holidays. The user doesn't distinguish > between them and it must be possible to turn off that feature with just one > click. > > > This addresses bug 281464. > http://bugs.kde.org/show_bug.cgi?id=281464 > > > Diffs > ----- > > libs/plasmaclock/calendar.cpp 75bfc31 > libs/plasmaclock/calendartable.h 8678593 > libs/plasmaclock/calendartable.cpp d2b436e > libs/taskmanager/groupmanager.cpp 45c15a9 > > Diff: http://git.reviewboard.kde.org/r/105924/diff/ > > > Testing > ------- > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
