Re: Review Request 124395: Test if signals are defined before using them

2015-07-19 Thread Felix Geyer
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5e88bb70f18571f4e4a429ee282056f49892a237 by Felix Geyer to branch master. Repository: plasma-workspace Description --- killtest.cpp sends various signals for testing. Not all of them are defined on

Review Request 124395: Test if signals are defined before using them

2015-07-19 Thread Felix Geyer
screenlocker/greeter/autotests/killtest.cpp 2e9997f Diff: https://git.reviewboard.kde.org/r/124395/diff/ Testing --- plasma-workspace built fine with this patch on mipsel. Thanks, Felix Geyer ___ Plasma-devel mailing list Plasma-devel@k

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-09-02 Thread Felix Geyer
iff: https://git.reviewboard.kde.org/r/117499/diff/ Testing --- - Lock the screen - Press "Switch user" - Press "Cancel" - With this patch the "Switch user" button is visible and functional. Thanks, Felix Geyer __

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-08-21 Thread Felix Geyer
ncel" - With this patch the "Switch user" button is visible and functional. Thanks, Felix Geyer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-07-16 Thread Felix Geyer
is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117499/#review56182 ------- On April 22, 2014, 10:53 a.m., Felix Geyer wrote: > > --- &g

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-04-22 Thread Felix Geyer
the screen - Press "Switch user" - Press "Cancel" - With this patch the "Switch user" button is visible and functional. Thanks, Felix Geyer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-04-11 Thread Felix Geyer
th this patch the "Switch user" button is visible and functional. Thanks, Felix Geyer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Display brightness OSD notification and change brightness when Fn keys are unhandled

2010-05-06 Thread Felix Geyer
ationsship between the objects is a bit obscure. As said I only copied the code from KMix but I'll clean this up. - Felix --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kd

Re: Review Request: Display brightness OSD notification and change brightness when Fn keys are unhandled

2010-05-05 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1942/ --- (Updated 2010-05-05 20:58:51.762208) Review request for Plasma and Dario Freddi.

Re: Review Request: Display brightness OSD notification and change brightness when Fn keys are unhandled

2010-05-05 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1942/ --- (Updated 2010-05-05 20:30:50.097920) Review request for Plasma and Dario Freddi.

Re: kubuntu kdebase patches to plasma

2009-12-14 Thread Felix Geyer
Sebastian Kügler kde.org> writes: > Does this also fix the "we don't get notifications from HAL about > brightness changes"-problem? > > I've been working around this in the battery applet for some time now, > it only updates the brightness slider when the applet pops up. The patch works around

Re: Review Request: kickoff: Always select "Favorites" tab when opened

2009-07-30 Thread Felix Geyer
- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/#review1859 --- On 2009-07-30 12:49:11, Felix Geyer wrote: > > --- > This is an a

Review Request: kickoff: Always select "Favorites" tab when opened

2009-07-30 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1164/ --- Review request for Plasma. Summary --- Fix bug 201998 by calling reset() af