-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117499/
-----------------------------------------------------------

(Updated Aug. 21, 2014, 8:47 p.m.)


Review request for Plasma, David Edmundson, Thomas Lübking, and Wolfgang Bauer.


Changes
-------

I've added another Sessions object in Greeter to avoid having that singleton.
While it's not ideal to have a second Session object I think the overhead isn't 
significant.


Bugs: 331761
    http://bugs.kde.org/show_bug.cgi?id=331761


Repository: kde-workspace


Description
-------

The user switichting dialog from the screen locker is destroyed when the cancel 
button is pressed.
As a result you can't open it again.

The screen locker uses a PlasmaComponents.PageStack to show the password input 
and user switching dialogs.
When a dialog is popped from the stack it is destroyed by PageStack.

This change fixes this by creating a new instance of userSessionsUI before it 
is pushed to the stack.
Additionally the switchUserEnabled property is set once when the screen locker 
is created as userSessionsUIInstance
doesn't always exist. 


Diffs (updated)
-----

  
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml
 0d3c7d5 

Diff: https://git.reviewboard.kde.org/r/117499/diff/


Testing (updated)
-------

- Lock the screen
- Press "Switch user"
- Press "Cancel"
- With this patch the "Switch user" button is visible and functional.


Thanks,

Felix Geyer

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to