> On April 22, 2014, 1:44 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml, > > line 92 > > <https://git.reviewboard.kde.org/r/117499/diff/1/?file=264758#file264758line92> > > > > Page stack can take a component so this can become > > > > .push(userSessionsUIComponent) > > and then kill the function and bonus property. > > > > Having functions and pseudo singleton instance isn't very QML'y. > > That would mean reworking the Sessions object so that > > switchUserSupported works.
Sorry for the long delay. I'm not really sure how Session could be reworked best, except creating another Sessions instance in main.qml. - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117499/#review56182 ----------------------------------------------------------- On April 22, 2014, 10:53 a.m., Felix Geyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117499/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:53 a.m.) > > > Review request for Plasma, Thomas Lübking and Wolfgang Bauer. > > > Bugs: 331761 > http://bugs.kde.org/show_bug.cgi?id=331761 > > > Repository: kde-workspace > > > Description > ------- > > The user switichting dialog from the screen locker is destroyed when the > cancel button is pressed. > As a result you can't open it again. > > The screen locker uses a PlasmaComponents.PageStack to show the password > input and user switching dialogs. > When a dialog is popped from the stack it is destroyed by PageStack. > > This change fixes this by creating a new instance of userSessionsUI before it > is pushed to the stack. > Additionally the switchUserEnabled property is set once when the screen > locker is created as userSessionsUIInstance > doesn't always exist. > > > Diffs > ----- > > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml > 0d3c7d5 > > Diff: https://git.reviewboard.kde.org/r/117499/diff/ > > > Testing > ------- > > - Lock the screen > - Press "Switch user" > - Press "Cancel" > - With this patch the "Switch user" button is visible and functional. > > > Thanks, > > Felix Geyer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
