Re: Review Request: Plasma doesn't follow Kiosk restrictions

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5823/#review8624 --- no, I don't think this is correct. check out line 880: Immutabili

KDE/kdebase/workspace/plasma/desktop/shell

SVN commit 1194120 by chani: containments with invalid ID are deleted instead of respawning (unless the activitymanager is down, of course) do you think I should do the same for all orphans, if a migration has already happened? CCMAIL:plasma-devel@kde.org M +9 -11 desktopcorona.cpp ---

Re: Review Request: activity templates

ust commit :) - Chani On 2010-10-28 21:08:41, Chani Armitage wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5709/ >

Review Request: activity templates

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5709/ --- Review request for Plasma. Summary --- whee! this turned out to be quit

Re: Review Request: activities dataengine

e.org/r/5707/#review8414 --- On 2010-10-28 17:09:34, Chani Armitage wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Review Request: activities dataengine

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5707/ --- Review request for Plasma and Albert Astals Cid. Summary --- this is a

Re: Review Request: Microblog: small patch so that microblog remembers the password even when kwallet is disabled

> On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config file > > isn't great... > > some time ago it did already this thing, why was it removed? good question. Mohit, you should look in the svn log and see if there was a reason it w

Re: Review Request: activity sessions in ksmserver and kwin

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5638/ --- (Updated 2010-10-18 12:20:20.183265) Review request for kwin, Plasma and Lub

Review Request: activity sessions in ksmserver and kwin

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5638/ --- Review request for kwin and Plasma. Summary --- so, this is the activit

Re: Review Request: Corona::exportLayout

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5451/ --- (Updated 2010-09-27 14:38:42.056313) Review request for Plasma. Changes --

Re: Review Request: Corona::exportLayout

it call > > the new one. > > > > then we have a nice api with symmetry? > > Chani Armitage wrote: > so... void Corona::exportLayout(KConfigGroup *config, QList > containments) > and void Corona::importLayout(KConfigGroup *config) > > Aaron

Re: Review Request: Corona::exportLayout

e=38404#file38404line359> > > > > what does calling updateConstraints even do in this case? looking at > > the code in Applet, this just schedules a call to > > flushPendingConstraintsEvents with a timer. is it actually needed at all? > > Chani Armitage wrote: >

Re: Review Request: Corona::exportLayout

tomatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5451/#review7824 --- On 2010-09-25 16:51:30, Chani Armitage wrote: > > --- > This is an automatic

Review Request: Corona::exportLayout

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5451/ --- Review request for Plasma. Summary --- this adds exportLayout to corona

KDE/kdebase/workspace/kwin

SVN commit 1179043 by chani: Use an X property for activity associations the new property name is "_KDE_NET_WM_ACTIVITIES", of type XA_STRING, and it's a comma-separated list of activity UUIDs. kwin should respond to other processes changing the activity list for a window, and filter out any bog

Re: Review Request: Added feature in "showdesktop" widget to minimize all opened window when any file/folder is dragged from the opened window and hover over "showdesktop" widget icon.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5060/#review7124 --- neat :) I'd love to see the same logic applied to the show-dashboard p

Re: Review Request: Security updates in kdeplasma-addons for 4.5

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4602/#review6482 --- Ship it! - Chani On 2010-07-11 21:53:30, Ryan Rix wrote: > > -

Re: Review Request: Fixes for screen hotplugging

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4451/#review6253 --- thanks for tackling this :) there are other situations where the scre

KDE/kdebase/workspace/plasma/design

SVN commit 1131048 by chani: added some explaination of activities and context in case I get hit by a bus :) I hope it makes sense 'cause I'm getting tired. the context stuff is... not 100% coherent, and probably only 80% correct. aaron, could you check that file when you get a moment please? :)

Re: Review Request: basic activity manager

n automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3780/#review5180 ------- On 2010-04-22 21:06:15, Chani Armitage wrote: > > --- > This is an automatically genera

Re: Review Request: basic activity manager

gt; > bottom of the screen as a horizontal strip. which means we don't need a > > containment. > > > > the corona can be gotten from PlasmaApp. hmm. I'll look into that next then, see how many contaimnent assumptions aree in the co

Review Request: basic activity manager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3780/ --- Review request for Plasma. Summary --- this is the beginning of the activit

Re: Review Request: Do not use values() over a QHash when it's not really necessary

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3490/#review4874 --- Ship it! this sort of simple improvement doesn't really need reviewin

Re: Review Request: Plasma::DialogManager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3474/#review4868 --- Ship it! /trunk/KDE/kdelibs/plasma/applet.h

Review Request: split widget-explorer classes

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3470/ --- Review request for Plasma. Summary --- this factors out the appletbrowser c

Re: Review Request: save/restore containments

robably end up sharing code with this. hmm. - Chani --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2713/#review3830 --- On 2

Review Request: save/restore containments

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2713/ --- Review request for Plasma. Summary --- as expected, the libplasma side of c

Re: Review Request: a way for a custom corona to forbid some standard context menu entries

generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2580/ > --- > > (Updated 2010-01-14 11:03:23) > > > Review request for Plasma and Chani Armitage. > > > Summary > --- > > This approach doesn't look that right, but is th

KDE/kdelibs/plasma

SVN commit 1067596 by chani: give wallpaper priority over containmentactions in all events CCMAIL: plasma-devel@kde.org note that the wallpaper is only getting wheel events and move events when itemAt != this, which is different from the "if there's no applet there" logic that's used for containm

Re: Review Request: Add a tooltip to battery monitor applet

> On 2009-11-25 17:27:53, Cyberbeat wrote: > > I really like the estimated time. And it really helps. And for not being > > precise, it is "estimated" :) Would really like to see this in kde-4.4, and > > perhaps also backported to kde-4.3? > > Kåre Särs wrote: > I'm afraid it is a bit too

Re: Review Request: popup ContextMenu at a sensible position

> On 2009-11-25 00:18:30, Aaron Seigo wrote: > > this feels broken. i think klipper should just popup the menu where the > > mouse is (more clever schemes might entail finding what widget has focus > > ... but ... yeah, i don't think we need to get that fancy) it has an option for that already

KDE/kdebase/workspace/plasma

SVN commit 936599 by chani: a new security constraint: KRun. I'm getting the trashcan off the screensaver with this, although I'm sure I could find other constraints it violates... iirc there are several other plasmoids that need to be updated for this constraint. CCMAIL: plasma-devel@kde.org