----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3490/#review4874 -----------------------------------------------------------
Ship it! this sort of simple improvement doesn't really need reviewing :) (although it made a good reminder to not write code like that...) - Chani On 2010-04-04 10:48:42, Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3490/ > ----------------------------------------------------------- > > (Updated 2010-04-04 10:48:42) > > > Review request for Plasma. > > > Summary > ------- > > Calling values and then foreach on a QHash is slower and more memory > intensive than just foreach the QHash, this changes the first to the second. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/runnermanager.cpp 1110839 > > Diff: http://reviewboard.kde.org/r/3490/diff > > > Testing > ------- > > It compiles > > > Thanks, > > Albert > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
