----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2580/#review3697 -----------------------------------------------------------
:/ this feels wrong. for the screensaver, I just created a separate mouse plugin. I suppose the netbook shares actions like "log out" and "lock screen" though, which makes this a bit trickier... we don't really want to duplicate all that code, but nor do we want a special hack for the contextmenu plugin... really, all those plugins were written with just the desktop in mind, they should be in desktop/ not generic/. *thinks* abusing kauthorized wouldn't be much better, I guess? /trunk/KDE/kdelibs/plasma/containment.h <http://reviewboard.kde.org/r/2580/#comment3043> why's this here? I don't see any code using it. /trunk/KDE/kdelibs/plasma/corona.h <http://reviewboard.kde.org/r/2580/#comment3044> that name confuses me... well, all the names are confusing in this area *sigh* a ContainmentActions is a plugin that does stuff on a trigger, what we're disabling is one action within one specific plugin. heh, and that's not to be confused with contextactions or actions() ... - Chani On 2010-01-14 11:03:23, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2580/ > ----------------------------------------------------------- > > (Updated 2010-01-14 11:03:23) > > > Review request for Plasma and Chani Armitage. > > > Summary > ------- > > This approach doesn't look that right, but is the only way i could think of: > in the netbook shell there really shouldn't be the "add panel" context menu > entry since it isn't supported (what happens right now is the panel > containment being created and no views assigned to it. > we could also decide that yeah, indeed the netbook should support multiple > panels too (was thinking about that for unrelated reasons) but the problem > would propose itself again when we do another shell without panels but that > still make sense to have context menus (like the screensaver) > i tried to do a generic mechanism: all actions will be enabled by default and > the corona keeps a blacklist of them (corona or containment? some actions > make sense to be enabled or disabled only globally, like add panel, others > could be containment dependent?) > setContaimentActionEnabled() adds the action to the blacklist > > this is just a stub, all actions should check their availability in the future > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/contextmenu/menu.cpp > 1070354 > /trunk/KDE/kdebase/workspace/plasma/netbook/shell/netcorona.cpp 1070354 > /trunk/KDE/kdelibs/plasma/containment.h 1074119 > /trunk/KDE/kdelibs/plasma/containment.cpp 1074119 > /trunk/KDE/kdelibs/plasma/corona.h 1074119 > /trunk/KDE/kdelibs/plasma/corona.cpp 1074119 > > Diff: http://reviewboard.kde.org/r/2580/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
