marked as submitted.
Review request for Plasma, Ashish Bansal and Bhushan Shah.
Changes
---
Submitted with commit cf570eb71014e517c91f718c02a48b7afaa96418 by Aditya Dev
Sharma to branch master.
Repository: plasma-mediacenter
Description
---
Implemented it like the other datasources
autotests/lastfmimagefetchertest.cpp abb3fd6
autotests/CMakeLists.txt 04ba1c3
autotests/lastfmimagefetchertest.h eb7cb29
Diff: https://git.reviewboard.kde.org/r/125993/diff/
Testing
---
Builds 100%.
Works as expected.
Thanks,
Aditya Dev Sharma
/lastfmimagefetcher.cpp e005077
libs/mediacenter/medialibrary.h 45744c1
libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe
Diff: https://git.reviewboard.kde.org/r/125993/diff/
Testing (updated)
---
Builds 100%.
Works as expected.
Thanks,
Aditya Dev Sharma
.
NOTE: This is just for testing purposes. Hence kept the comments and debugs.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
he QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
and media plays as expected.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
om it, all the datasources are loaded and media plays as expected.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
after this.
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
seem to work which I'll fix after this.
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde
seem to work which I'll fix after this.
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde
100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this.
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.
Thanks,
Aditya Dev Sharma
https://git.reviewboard.kde.org/r/125993/diff/
Testing (updated)
---
Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this.
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.
Tha
/mediacenter/lastfmimagefetcher.cpp e005077
libs/mediacenter/pmcimagecache.h 6399461
libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe
Diff: https://git.reviewboard.kde.org/r/125993/diff/
Testing
---
Built and Tested.
Thanks,
Aditya Dev Sharma
e005077
libs/mediacenter/pmcimagecache.h 6399461
libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe
Diff: https://git.reviewboard.kde.org/r/125993/diff/
Testing
---
Built and Tested.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/pmcimagecache.h 6399461
libs/mediacenter/pmcimagecache.cpp fcfe2a8
libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe
Diff: https://git.reviewboard.kde.org/r/125993/diff/
Testing
---
Built and Tested.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing
://git.reviewboard.kde.org/r/125993/diff/
Testing
---
Built and Tested.
Thanks,
Aditya Dev Sharma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
17 matches
Mail list logo