----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ -----------------------------------------------------------
(Updated Dec. 28, 2015, 2:09 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Ashish Bansal and Bhushan Shah. Changes ------- Submitted with commit cf570eb71014e517c91f718c02a48b7afaa96418 by Aditya Dev Sharma to branch master. Repository: plasma-mediacenter Description ------- Implemented it like the other datasources. Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList. After the image is fetched, gotImage emits the signal imageFetched (from mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel. Diffs ----- libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe libs/mediacenter/medialibrary.h 45744c1 libs/mediacenter/lastfmimagefetcher.cpp e005077 libs/mediacenter/lastfmimagefetcher.h ecff37e libs/mediacenter/CMakeLists.txt 5a13449 datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION datasources/lastfm/CMakeLists.txt PRE-CREATION datasources/CMakeLists.txt a7171b7 autotests/lastfmimagefetchertest.cpp abb3fd6 autotests/CMakeLists.txt 04ba1c3 autotests/lastfmimagefetchertest.h eb7cb29 Diff: https://git.reviewboard.kde.org/r/125993/diff/ Testing ------- Builds 100%. Works as expected. Thanks, Aditya Dev Sharma
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
