----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ -----------------------------------------------------------
(Updated Nov. 23, 2015, 8:05 p.m.) Review request for Plasma, Ashish Bansal and Bhushan Shah. Changes ------- Changes made as per Review. Repository: plasma-mediacenter Description (updated) ------- Implemented it like the other datasources. Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList. After the image is fetched, gotImage emits the signal mediaUpdated (from mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel. Diffs (updated) ----- autotests/CMakeLists.txt 04ba1c3 autotests/lastfmimagefetchertest.h eb7cb29 autotests/lastfmimagefetchertest.cpp abb3fd6 datasources/CMakeLists.txt a7171b7 datasources/lastfm/CMakeLists.txt PRE-CREATION datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION libs/mediacenter/CMakeLists.txt 5a13449 libs/mediacenter/lastfmimagefetcher.h ecff37e libs/mediacenter/lastfmimagefetcher.cpp e005077 libs/mediacenter/medialibrary.h 45744c1 libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe Diff: https://git.reviewboard.kde.org/r/125993/diff/ Testing (updated) ------- Builds 100%. However the audio scrobbler api doesn't seem to work which I'll fix after this. Fixed the QThread LastfmImageFetcher Warning. Apart from it, all the datasources are loaded and media plays as expected. Thanks, Aditya Dev Sharma
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
