Re: New Plasma modules and localization

El dissabte, 16 de maig de 2020, a les 14:50:12 CEST, Yuri Chornoivan va escriure: > Hi, > > Plasma 5.19 sports several KCM updates that lead to some changes in > translations. It is good to see the continuous progress in the design, > features, and usability of Plasma. > > It is sad, however,

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

ngraham added a comment. You're probably right. This was a pretty lazy patch. The inherent challenge here is that desktop wallpapers are per-containment ("Containment" means a screen or activity), while the lock and login screens are per-session. A further complication is that the login

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

niccolove added a comment. I'm a bit torn about this. It is indeed very nice, but at the same time I don't feel like it's the right solution. Ignoring minor complaints I'd have ("it's a very large button!") it doesn't feel right that the user, in order to change login wallpaper, would think

D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now the appearance is consistent with other similar messages, as well as the one to

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This should make it a bit easier for people to change the wallpapers in all three places. In

Re: New Plasma modules and localization

> > > It is sad, however, to see some regressions in translations. I cannot > test by > > myself but there are reports that some parts of the new KWin Rules KCM > are > > untranslatable: > > > > https://phabricator.kde.org/D29413 > > > > Can somebody test if it's true? > Reading the code I can't i

Re: New Plasma modules and localization

Yuri Chornoivan ha scritto: > Hi, > > Plasma 5.19 sports several KCM updates that lead to some changes in > translations. It is good to see the continuous progress in the design, > features, and usability of Plasma. > > It is sad, however, to see some regressions in translations. I cannot test

D29796: Fix "Implicitly defined onFoo" deprecation warnings

hexchain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hexchain requested review of this revision. REVISION SUMMARY Fix "Implicitly defined onFoo" deprecation warnings (part 2) REPOSITORY R120 Plasma Workspace BRANCH fix-deprecation-warning

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82996. guoyunhe added a comment. No delete engine and watcher REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82994&id=82996 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTE

D29140: Show POTD in lock screen

davidre added inline comments. INLINE COMMENTS > kded_potd.cpp:25 > +delete engine; > +delete watcher; > +} Don't need to delete watcher because you constructed it with `this` as parent. https://doc.qt.io/qt-5/objecttrees.html For the engine don't delete it because you don't have the ow

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82994. guoyunhe added a comment. Remove unused slots REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82993&id=82994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82993. guoyunhe added a comment. Fix leaks REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82821&id=82993 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES CMakeList

D10197: Fix krunner's alt+f2 on wayland

meven added inline comments. INLINE COMMENTS > view.cpp:247 > -m_plasmaShellSurface->setPanelTakesFocus(true); > -m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel); > -//this should be on showEvent, but it was too soon so none of > those had any e

D29140: Show POTD in lock screen

davidre added a comment. Flickr works here F8325269: Screenshot_20200516_095930.png > For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some document/tutorials/ex