davidre added inline comments. INLINE COMMENTS
> kded_potd.cpp:25 > + delete engine; > + delete watcher; > +} Don't need to delete watcher because you constructed it with `this` as parent. https://doc.qt.io/qt-5/objecttrees.html For the engine don't delete it because you don't have the ownership pof the object. The function just returned a pointer to it. > When the DataEngineConsumer class is deleted, all engines accessed using it > are de-referenced and possibly deleted (in the case that there are no other > users of the engine in question). https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1DataEngineConsumer.html REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, davidre, broulik Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
