KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/24/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 25 Apr 2020 04:27:54 + Build duration: 43 sec and counting CONSOLE OUTPUT [...t

D29142: Add footer support to systray

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Actually this does something funky to the Vaults applet if I open the sound applet first and then switch to Vaults while the popup is still open: F8259065: Screenshot_20200424_

D29140: Fix POTD in lock screen (partly)

ngraham added a comment. Thanks for working on this! It seems like to make this cache work on the lock screen, the file needs to be added to the cache *before* the screen locks, even if it hasn't been added there by the desktop wallpaper. REPOSITORY R114 Plasma Addons REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81153. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81135&id=81153 BRANCH tools-area-color-changes-v3 REVISION DETAIL https://phabricator.kde.org/D28317 AFFECTED FILES c

D29165: [System Monitor] Fix update interval setting

ksmanis added a comment. I am not sure what the proper solution for the i18ncp call is given that the argument is decimal. Someone more knowledgeable should probably chime in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29165 To: ksmanis, #plasma Cc: pl

D29165: [System Monitor] Fix update interval setting

ksmanis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY The update interval setting for the system monitor applets seems to be borked right now, as a result of a missing reference and an

D27669: [kstyle] Tools area

cblack updated this revision to Diff 81137. cblack added a comment. Re-add empty drawing for menu bar REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=81133&id=81137 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFF

D29142: Add footer support to systray

niccolove added a comment. Sorry! I'll double check from now on. INLINE COMMENTS > ngraham wrote in PlasmoidPopupsContainer.qml:38 > Nothing was using this? Nothing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29142 To: niccolove, ngraham Cc: plasma-de

D27669: [kstyle] Tools area

ngraham added a comment. That fixes the crashes as well as the performance issues I was seeing. However every app with a menubar now shows a lighter-colored rectangle to the right of the menu area: F8258365: vokoscreenNG-2020-04-24_14-31-10.webm REPOSI

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81135. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81039&id=81135 BRANCH tools-area-color-changes REVISION DETAIL https://phabricator.kde.org/D28317 AFFECTED FILES colo

D28888: Fix navigation regressions

ngraham added a comment. That works, but wouldn't it be nicer if the border of the card just clipped the image? Also I just noticed that Sidebar Drawer view is a mess. REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami C

D27669: [kstyle] Tools area

cblack updated this revision to Diff 81133. cblack added a comment. Disconnect signals on destruction REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=81123&id=81133 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFF

D28888: Fix navigation regressions

cblack updated this revision to Diff 81132. cblack added a comment. Add left margin to image REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81130&id=81132 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https:

D27669: [kstyle] Tools area

ndavis added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:127 > +auto geoUpdate = [=]() { > +_helper->_invalidateCachedRects = true; > +emit toolbarUpdated(); I misclicked. It's this line with `_helper->_invalidateCachedRects = true;`

D27669: [kstyle] Tools area

ndavis added inline comments. INLINE COMMENTS > ndavis wrote in breezetoolsareamanager.cpp:127 > When I run GDB on `oxygen-demo5`, sometimes it tells me that `oxygen-demo5` > crashes on this line. I'm not sure how to make it happen reliably, but it > usually involves changing QStyles with the S

D28888: Fix navigation regressions

ngraham added a comment. Much better. But the left corners of the cards aren't rounded. REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, j

D28888: Fix navigation regressions

cblack updated this revision to Diff 81130. cblack added a comment. Address feedback REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81129&id=81130 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https://phabri

D28888: Fix navigation regressions

ngraham added a comment. Much nicer! There appear to be issues with the left margin and the color of the search field's toolbar background though: F8258252: Screenshot_20200424_130114.png Also the text in the cards seems a too large to me. Mayb

D29154: Use QWindow overload of QIcon::pixmap

apol accepted this revision. apol added a comment. This is what it looks like for me with the patch applied. scale 1x: F8258193: Screenshot_20200424_203628.png scale 2x: F8258201: Screenshot_20200424_203729.png

D28888: Fix navigation regressions

cblack updated this revision to Diff 81129. cblack added a comment. Swap collapsed header and image REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81127&id=81129 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

cblack updated this revision to Diff 81127. cblack added a comment. Adjust listview REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=80822&id=81127 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https://phabric

D29142: Add footer support to systray

ngraham added a comment. It also helps if your reviewer has applied the correct patch before he leaves a snarky comment. :) I can see now that this is working properly. But please to add more info into the Description and Test Plan sections so they can become a part of the historical re

D29142: Add footer support to systray

ngraham added a comment. It helps to add a description, Test Plan, and screenshots. Since there are none, I have to guess at what this patch is doing, and I'm not sure if its failure to remove the extra margins around the footer in the Audio applet are due to a missing other patch, or this p

D27669: [kstyle] Tools area

cblack updated this revision to Diff 81123. cblack added a comment. Address tooling warnings REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=80819&id=81123 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FIL

D29157: force systemsettings for kcms

ngraham added a comment. Heh, clever! However if System Settings is already open and y REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29157 To: mart, #plasma Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zac

D28936: Use a Proxy object to detect changes within the MediaMetadata

broulik added a comment. Maybe if I overwrote `MediaMetadata` with a `Proxy` object already, then the website would never have a separate `Object` to work with.. hmm REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28936 To: broulik, #plasma, fvogt

D29157: force systemsettings for kcms

davidre added a comment. Maybe todo remove? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29157 To: mart, #plasma Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29154: Use QWindow overload of QIcon::pixmap

davidre added a comment. In D29154#656585 , @apol wrote: > +1 > > I did the same thing for kirigami @ D29100 and plasma-framework @ D29102 yesterday after looking at Q

D29154: Use QWindow overload of QIcon::pixmap

apol added a comment. In D29154#656516 , @cblack wrote: > Icon handling looks somewhat funky with this patch applied when a window changes DPI. > F8257898: ksnip_20200424-111720.png Right, should

D29154: Use QWindow overload of QIcon::pixmap

apol added a comment. +1 I did the same thing for kirigami @ D29100 and plasma-framework @ D29102 yesterday after looking at Qt's code and assessing it was the right thing to do. I am not familiar with Breeze's

D29157: force systemsettings for kcms

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY as we can't kill completely kcmshell just yet, hack intothe services runner to replace on the fly the e

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 81115. apol added a comment. Adapt to the changes in hte kwayland patch REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80985&id=81115 BRANCH master REVISION DETAIL https:/

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ngraham created this revision. ngraham added reviewers: Plasma, ahmadsamir, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY By default, the "Small" font is 2 points smaller than the "Normal" one. However

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixes the bug for me and seems like the right solution. REPOSITORY R119 Plasma Desktop BRANCH l-setnearest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29155

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir updated this revision to Diff 81110. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: ngraham. ahmadsamir added a comment. Tweak commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29155?vs=81109&id=

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir added a reviewer: ngraham. ahmadsamir added a comment. If that diff is a no-go, it'll have to be D27785 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29155 To: ahmadsamir, #plasma, bport, ngraham Cc: plasma-d

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY It seems that nearestExistingFont() gets the same result of `fc-match font-name`, which is basically the sans serif defaul

D29154: Use QWindow overload of QIcon::pixmap

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. Icon handling looks somewhat funky with this patch applied when a window changes DPI. F8257898: ksnip_20200424-111720.png REPOSITORY R31

D29154: Use QWindow overload of QIcon::pixmap

davidre updated this revision to Diff 81107. davidre added a comment. Correct code style when I'm touching these lines either way REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29154?vs=81106&id=81107 BRANCH window REVISION DETAIL https://phabricator.kd

D29154: Use QWindow overload of icon.pixmap

davidre created this revision. davidre added reviewers: apol, broulik, ndavis, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Previously only the combobox used this overload but that dropped in 0eaf76

D28908: Use the same icon mode calculation for comboboxes as for buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:5a62232415bc: Use the same icon mode calculation for comboboxes as for buttons (authored by davidre). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28908?vs=80359&id=

D29012: Fix variable mixup

This revision was automatically updated to reflect the committed changes. Closed by commit R31:49cff2127371: Fix variable mixup (authored by davidre). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29012?vs=80657&id=81104 REVISION DETAIL https://phabricator.kd

D29012: Fix variable mixup

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Works for me REPOSITORY R31 Breeze BRANCH typo (branched from master) REVISION DETAIL https://phabricator.kde.org/D29012 To: davidre, #breeze, #plasma, ndavis Cc: ndavis, plasma-dev

D29144: [applets/weather] Improve UX for selecting a weather station

This revision was automatically updated to reflect the committed changes. Closed by commit R114:ef213aaa5a2c: [applets/weather] Improve UX for selecting a weather station (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29144?vs=8104

D29144: [applets/weather] Improve UX for selecting a weather station

ngraham added a comment. In another patch, sure, I can work on that. REPOSITORY R114 Plasma Addons BRANCH better-weather-station-selection-ux (branched from master) REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg, #plasma, broulik, spstarr Cc: ndavis, spstarr, pla

D29144: [applets/weather] Improve UX for selecting a weather station

ndavis added a comment. Can you also make locations show up as you type so that you don't need a search button? REPOSITORY R114 Plasma Addons BRANCH better-weather-station-selection-ux (branched from master) REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg, #plasm

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 46 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/46/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 24 Apr 2020 13:10:16 + Build duration: 1 hr 24 min and counting JUnit Tests Name: (root) Failed: 0 tes

D29144: [applets/weather] Improve UX for selecting a weather station

spstarr requested changes to this revision. spstarr added a comment. This revision now requires changes to proceed. Hoping to get back into working on the backend as for how many, well depends how many weather providers will provide free API keys to use, I guess this is ok for now then. +1

D29144: [applets/weather] Improve UX for selecting a weather station

ngraham added a comment. In D29144#656123 , @spstarr wrote: > -1 From me, what happens if we have more Weather Providers won't the dialog box be cluttered? If we can sort that out then +1 Is that in the cards? Right now we have only four

D29152: Allow PlaceholderMessage to be text-less

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d2969c7af79b: Allow PlaceholderMessage to be text-less (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29152?vs=81097&id=81099 REVISION DETA

D29152: Allow PlaceholderMessage to be text-less

ngraham updated this revision to Diff 81097. ngraham marked an inline comment as done. ngraham added a comment. Simplify REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29152?vs=81095&id=81097 BRANCH allow-PlaceholderMessage-to-omit-text (branched from m

D28936: Use a Proxy object to detect changes within the MediaMetadata

fvogt added a comment. In D28936#656422 , @broulik wrote: > > this doesn't catch something like this > > Yeah it doesn't. I thought I could "monitor" an Object but the caller actually has to //use// the Proxy for it to detect anything :/ >

D29152: Allow PlaceholderMessage to be text-less

broulik added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:220 > > +visible: text && text.length > 0 > + `text` is a string property and as such always present, you can simplify this to visible: text !== "" or visible: text.length > 0 REPOSITORY R169 Kirigami RE

D28936: Use a Proxy object to detect changes within the MediaMetadata

broulik added a comment. > this doesn't catch something like this Yeah it doesn't. I thought I could "monitor" an Object but the caller actually has to //use// the Proxy for it to detect anything :/ Any ideas? :) INLINE COMMENTS > fvogt wrote in content-script.js:716 > That appears

D28936: Use a Proxy object to detect changes within the MediaMetadata

fvogt added a comment. AFAICT (take with a grain of salt, I'm a JS n00b) this doesn't catch something like this: let a = {}; navigator.mediaSession.metadata = a; a["foo"] = "bar"; And behaves weirdly if you do: let a = navigator.mediaSession.metadata; navigator.m

D29152: Allow PlaceholderMessage to be text-less

ngraham created this revision. ngraham added reviewers: iasensio, mart, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Requested by @iasensio for the KWin Rules KCM patch (D29141

D28658: [krdb] Drop GTK2 colour exporting

fvogt added a comment. > FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?) At least in openSUSE we'll backport it to Plasma 5.18, but it might not be the kind of behaviour change desired in 5.18 at this point in time... REPOSITORY R119 Plasma Des

D28305: Systemd Startup

davidedmundson updated this revision to Diff 81093. davidedmundson added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=80412&id=81093 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28305 AFFECTED FILES

D29150: Address Connections syntax warnings on the systray plasmoid

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Using it REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2915

D28333: Add a new daemon for stats monitoring

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > mart wrote in ksysguarddaemon.cpp:58 > needs to be always polling every half a second? could it be somewhat > adjustable (maybe depending on ac/on battery?) Indeed, the current code is every

D28333: Add a new daemon for stats monitoring

davidedmundson updated this revision to Diff 81087. davidedmundson marked 23 inline comments as done. davidedmundson added a comment. all the changes REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=78977&id=81087 BRANCH master REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 45 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/45/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 24 Apr 2020 10:30:29 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 2660 lines...][

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 81078. mart added a comment. - move here faces and packagestructure REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=81019&id=81078 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org

D28487: Redesign of system monitor plasmoids

mart updated this revision to Diff 81077. mart added a comment. - move faces and packagestructure to libksysguard REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=81020&id=81077 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phab

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added a comment. See https://github.com/systemd/systemd/pull/15226 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28424 To: hchain, davidedmundson, broulik, dfaure, ngraham, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29133: [Icon Applet] Port jump list actions to KServiceAction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:404b2be2168c: [Icon Applet] Port jump list actions to KServiceAction (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29133?vs=81001&i

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

meven added a comment. In D28424#637869 , @davidedmundson wrote: > looks good to me, but lets delay merging till the relevant other parts are ready. Seems ready to land ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph