ngraham added a comment.

  It also helps if your reviewer has applied the correct patch before he leaves 
a snarky comment. :)
  
  I can see now that this is working properly. But please to add more info into 
the Description and Test Plan sections so they can become a part of the 
historical record in the git log.

INLINE COMMENTS

> PlasmoidPopupsContainer.qml:38
>      property bool appletHasHeading: false
> -    property bool appletHeadingShown: appletHasHeading && 
> activeApplet.fullRepresentationItem.header.visible
> -    property bool mergeHeadings: appletHasHeading && appletHeadingShown

Nothing was using this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29142

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to