davidre created this revision. davidre added reviewers: apol, broulik, ndavis, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision.
REVISION SUMMARY Previously only the combobox used this overload but that dropped in 0eaf762705d84fab5c70a8934ffa7cfeadeeebde <https://phabricator.kde.org/R31:0eaf762705d84fab5c70a8934ffa7cfeadeeebde> because of the changes in 582f5ebad1686d47168a3246e2aff5beefb59121 <https://phabricator.kde.org/R31:582f5ebad1686d47168a3246e2aff5beefb59121>. However we should prefer that overload because it takes the screen into account on which the icon is rendered. This reinstates the code removed in 0eaf762 <https://phabricator.kde.org/R31:0eaf762705d84fab5c70a8934ffa7cfeadeeebde> as a helper function to retrieve the window from a window or styleObject. TEST PLAN Icons look correct (I don't have a high dpi screen myself but this should be straightforward) REPOSITORY R31 Breeze BRANCH window REVISION DETAIL https://phabricator.kde.org/D29154 AFFECTED FILES kstyle/breezehelper.cpp kstyle/breezehelper.h kstyle/breezestyle.cpp To: davidre, apol, broulik, ndavis, #breeze Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
