D28360: cmake: make xsettingsd check an option

kossebau added a comment. Can you tell which packagers missed that this is a required runtime dependency? Noting runtime dependencies as done so far here, by not having it required and tagging it as "RUNTIME" is a pattern everywhere else in KDE code, so the proposed patch or just settin

D28360: cmake: make xsettingsd check an option

ngraham added a comment. +1 for just making it a required dependency REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

paulm added a comment. In D28356#636593 , @ndavis wrote: > KDE4 was unpopular because it was heavier and buggier, not because the titlebar buttons were different. I didn't like KDE back then either (I mainly used GNOME 2 and Unity), but I did li

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

ndavis added a comment. In D28356#636362 , @paulm wrote: > > It has been part of the default kde look for many years (for all of oxygen and breeze) and forms a core part of our design brand. It's something where you can spot breeze on the first

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added inline comments. INLINE COMMENTS > breeze.kcfg:36 > > -true > +false > Maybe instead of disabling this, we should make its color red? I like the circle and making it red would be more consistent with our icons. REPOSITORY R31 Breeze REVISION DETAIL

D28368: [krunner] Avoid (a third!) pointless config parse

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Sounds like you can merge this with the other similar one, right? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28368 To: davidedmundson, #

D28365: [krunner] Avoid (another) pointless config load on start

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > view.cpp:110 > // Catch both, direct changes to the config file ... > -connect(KDirWatch::self(), &KDirWatch::dirty, this, &View::reloadConfig); > -connect(KDir

D27914: [Kilpper] Port QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in urlgrabber.h:185 > The code stores the QRegularExpression::capturedTexts(), > m_regexCapturedTexts, which is eventually what ClipCommandProcess uses. I

D28354: [applets/digital-clock] Fix calendar events not being shown at first

ngraham added a comment. If you're gonna have the function live inside the `onAgendaUpdated:` handler and only be used once, it might as well not be a function at all. :) If you want to keep it a function, it would be good to put it higher up in the file, so it can potentially be used by oth

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

davidre added a comment. In D27938#636412 , @paulm wrote: > I went ahead and made an Aurorae version of this just to get a feel for how much I could theme. Overall, I am disappointed with Aurorae as Plasma is n

D28369: [runners/recentdocuments] disable executables or .desktop files

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's possible to have a .desktop file in your recent documents list as you

D28368: [krunner] Avoid (a third!) pointless config parse

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We are krunner, our default config will be krunnerrc, we can load the insta

D27595: Watch for language change events, and forward those to the QML engine

rikmills added a comment. git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause, mart Cc: rikmills, ngraham, apol, plasma-devel, fbampaloukas, GB_2, d

D28366: [krunner] Don't set the position three times in a row

davidedmundson updated this revision to Diff 78708. davidedmundson retitled this revision from "[krunner] Don't set the position twice in a row" to "[krunner] Don't set the position three times in a row". davidedmundson edited the summary of this revision. davidedmundson added a comment. updat

D28366: [krunner] Don't set the position twice in a row

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY loadConfig does this on the line belwo REPOSITORY R120 Plasma Workspace B

D28365: [krunner] Avoid (another) pointless config load on start

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.o

D28364: [krunner] Avoid a config pointless extra config load

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN #plasma REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL htt

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636435 , @eszlari wrote: > In D28360#636418 , @gikari wrote: > > > But the option is enabled by default and needs to be explicitly disabled. This seems to be an over

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636418 , @gikari wrote: > But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, whi

D28360: cmake: make xsettingsd check an option

gikari added a comment. But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, which already is. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https:

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

paulm added a comment. I went ahead and made an Aurorae version of this just to get a feel for how much I could theme. Overall, I am disappointed with Aurorae as Plasma is not as easily customizable as would first meet the eye. Aurorae alone will not let yo

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 4 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 19:06:34 + Build duration: 2 min 25 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 27 Mar 2020 19:06:34 + Build duration: 2 min 18 sec and counting JUnit Tests Name: projectro

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636406 , @gikari wrote: > In D28360#636404 , @eszlari wrote: > > > I would like to have this in 5.18 > > > We cannot add mandatory dependencies to the stable

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636404 , @eszlari wrote: > I would like to have this in 5.18 We cannot add mandatory dependencies to the stable branches/releases. Currently it's an optional dependency. If you want to make it mandatory,

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 27 Mar 2020 19:00:24 + Build duration: 41 sec and counting CONSOLE OUTPUT [...truncated 359 l

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636403 , @gikari wrote: > Why just not make xsettingsd required? It is set to REQUIRED (and ON by default), but can be disabled, mainly because I would like to have this in 5.18, and it seems safer that

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/3/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 18:54:43 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT [...truncated 376 li

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 27 Mar 2020 18:54:43 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncated 359 li

D28360: cmake: make xsettingsd check an option

gikari added a comment. Why just not make xsettingsd required? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Zr

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 27 Mar 2020 18:42:03 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT [...truncated 426 lin

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 27 Mar 2020 18:42:03 + Build duration: 41 sec and counting CONSOLE OUTPUT [...truncated 361 li

D28360: cmake: make xsettingsd check an option

eszlari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. eszlari requested review of this revision. REVISION SUMMARY This way, packagers won't miss this new runtime dependency. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov updated this revision to Diff 78694. epopov added a comment. Make a function that compares dates inline. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28354?vs=78670&id=78694 REVISION DETAIL https://phabricator.kde.org/D28354 AFFECTED F

D27914: [Kilpper] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > Then you want to store a match? The code stores the QRegularExpression::capturedTexts(), m_regexCapturedTexts, which is eventually what ClipCommandProcess uses. REPOSITORY R120 Plasma Workspace REVISION DET

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

paulm added a comment. > It seems MacOS can get away with colored circles without people complaining about usability. I would argue that MacOS does this very badly, and that MacOS usability is not as great as the fanatics would attest. REPOSITORY R31 Breeze REVISION DETAIL https://

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

paulm added a comment. In D28356#636309 , @cblack wrote: > IMO, the maximise and minimise buttons are a step backwards from the current decorations in terms of legibility and aesthetics. > Minimise especially, considering that a square has no

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

davidre added subscribers: broulik, davidre. davidre requested changes to this revision. davidre added a comment. -1 I think the current design is fine. It has been part of the default kde look for many years (for all of oxygen and breeze) and forms a core part of our design brand. It's so

D26718: aggregate text for KRunner in DesktopView

pzro added a comment. Hey guys, this is what I think 1. Having the shell capture input and forward it to KRunner when it comes up - because KRunner is too slow to come up and capture text on demand 2. Having KRunner in the background from the beginning - because KRunner is too slow on

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

ervin added inline comments. INLINE COMMENTS > main.qml:333 > +15, > +20]; > + nitpick: I'd put the closing square bracket on the next line and you can drop the semicolumn > main.qml:343 > +value = index; > +} > + You

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. IMO, the maximise and minimise buttons are a step backwards from the current decorations in terms of legibility and aesthetics. Minimise especially, considering that a square has

D26934: KCM/Autostart Add a model to separate logic from UI

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Damn turns out I still missed a few, so what @broulik says (when it still applies). @broulik : are you sure about all your comments? It looks like something odd happened, some

D27914: [Kilpper] Port QRegExp to QRegularExpression

apol added inline comments. INLINE COMMENTS > ahmadsamir wrote in urlgrabber.h:185 > Another point (which I forgot since it has been some time since I last looked > at this patch), QRegExp stores the match info in itself, whereas > QRegularExpression stores the match info in a QRegularExpressio

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78686. ngraham added a comment. Don't forget to update `breeze.kcfg` too REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78676&id=78686 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28358: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-GTK

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. Changes to Breeze GTK are submitted to https://invent.kde.org/kde/breeze-gtk. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D28358 To: paulm, cbla

D28358: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-GTK

paulm created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. paulm requested review of this revision. REVISION SUMMARY As described in T12793 , this patch applies the KDE1-style 'Classik' titlebar icon styles to Breez

D26934: KCM/Autostart Add a model to separate logic from UI

broulik added inline comments. INLINE COMMENTS > autostart.cpp:182 > +AddScriptDialog addDialog(this); > +if (addDialog.exec() != QDialog::Accepted) { > +return; In preparation for a move to QML, can we please not `exec()` > autostart.cpp:192 > +QTreeWidgetItem* widgetItem =

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze, Breeze-GTK and Breeze-Icons

paulm updated this revision to Diff 78684. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28356?vs=78682&id=78684 REVISION DETAIL https://phabricator.kde.org/D28356 AFFECTED FILES kdecoration/breezebutton.cpp kdecoration/breezesettingsdata.kcfg kstyle/b

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze, Breeze-GTK and Breeze-Icons

paulm updated this revision to Diff 78682. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28356?vs=78679&id=78682 REVISION DETAIL https://phabricator.kde.org/D28356 AFFECTED FILES src/assets/breeze-close-active-symbolic.svg src/assets/breeze-close

D26934: KCM/Autostart Add a model to separate logic from UI

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Thanks for your patience :-) REPOSITORY R119 Plasma Desktop BRANCH D26934 REVISION DETAIL https://phabricator.kde.org/D26934 To: meven, mlaurent, ervin, #plasma, broulik, bport, cross

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78681. meven marked 2 inline comments as done. meven added a comment. remove spurious space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78680&id=78681 BRANCH D26934 REVISION DETAIL https://phabric

D26934: KCM/Autostart Add a model to separate logic from UI

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. One last nitpick INLINE COMMENTS > autostartmodel.cpp:121 > +case PlasmaStart: > +return static_cast (index); > +default: Please remove the spurious space before (

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze, Breeze-GTK and Breeze-Icons

paulm created this revision. paulm added reviewers: VDG, Breeze, hpereiradacosta. paulm added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. paulm requested review of this revision. REVISION SUMMARY As described in T12793

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78680. meven added a comment. Remove spaces, use static_cast for less repetition REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78074&id=78680 BRANCH D26934 REVISION DETAIL https://phabricator.kde.or

D27914: [Kilpper] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > Then call it m_regularExpression? Another point (which I forgot since it has been some time since I last looked at this patch), QRegExp stores the match info in itself, whereas QRegularExpression stores the ma

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +include(GNUInstallDirs) > + May be this could be moved to parent CMakeLists with other includes? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D28076 REVISION DETAIL https://phabricator.kde.org/D28076 To: c

D26934: KCM/Autostart Add a model to separate logic from UI

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > autostartitem.cpp:60 > +m_comboBoxStartup->addItem( AutostartModel::listPathName()[1], > AutostartEntrySource::PlasmaShutdown); > +m_comboBoxStartup->ad

D28354: Bug 395956: calendar events are not shown at first

ngraham added reviewers: Plasma, vkrause. ngraham added a comment. No need to put the function in a separate file; you should put it in `CalendarView.qml`. Since it's only used once, it could even be inline without defining a new function at all. That's a judgment call though. REPOSITORY R

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78676. ngraham added a comment. Also change Breeze light (large diff because it was super inconsistent with the old Breeze, which is fixed here as a part of making it consistent with the new Breeze except for the titlebar color not changing) REPOSITORY

D28354: Bug 395956: calendar events are not shown at first

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY I noticed that on the first time I bring up the calendar by clicking the clock on my Plasma panel,

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#636071 , @develoot wrote: > In D28200#633124 , @ngraham wrote: > > > Anyway, @develoot, could you provide your email address so we can land this patch with proper

D28200: Enable wrapping of error messages which use KMessageWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9bf6f53a036: Enable wrapping of error messages which use KMessageWidget (authored by develoot, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

D27971: Solid-device-automounter/kcm: correctly update automountOn

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aca698e497c8: Solid-device-automounter/kcm: correctly update automountOn (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27971?vs=77992&i

D28317: Adjust default color scheme and titlebar appearance for Tools Area

davidre added a comment. In D28317#636115 , @ngraham wrote: > This isn't really a new version of Breeze Light. I see Breeze Light as the light version of Breeze Dark; both are unibody (titlebar is same color as window background), but one is lig

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:151 > decoration()->client().data()->icon().paint(painter, > iconRect.toRect()); > - > +KIconLoader::global()->resetPalette(); > I will look into it REPOSITORY R31 Breeze BRANCH icons (branched fr

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. This isn't really a new version of Breeze Light. I see Breeze Light as the light version of Breeze Dark; both are unibody (titlebar is same color as window background), but one is light and the other is dark. That said, yeah, I wonder how many people will still w

D28317: Adjust default color scheme and titlebar appearance for Tools Area

The-Feren-OS-Dev added a comment. In my honest opinion, it'd probably be good to also get rid of Breeze Light in a separate patch as TBH as I see it right now Breeze will make Breeze Light redundant by default post-this-patch since they'll both be Breeze Light in a sense. It just seems redun

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78667. cblack added a comment. Address issues REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78664&id=78667 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES kstyle

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78666. ngraham added a comment. Also turn off the close button circle by default REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78665&id=78666 BRANCH tools-area-color-changes (branched from master) REVISION D

D28317: Adjust default color scheme and titlebar appearance for Tools Area

niccolove added a comment. I also think that the circle around x should be removed :-) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblac

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78665. ngraham added a comment. Complete colorscheme changes REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78584&id=78665 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phab

D27669: [kstyle] Tools area

niccolove added a comment. Couple of things: - There's strong consensus in the VDG that we should go with a standard separator line for now, and eventually make it consistently darker if we decide it's not dark enough. - The above mentioned colorscheme with transparent titlebar still d

D28330: Color icons in titlebar if possible

kossebau added a comment. With cross-casting I meant the type of cast where the types involved are not in same inheritance branch INLINE COMMENTS > davidre wrote in breezebutton.cpp:148 > I don't think it can fail. decoration() is a QPointer > (https://api.kde.org/kdecoration/html/classKDec

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78664. cblack added a comment. Fix bad toolbar heuristic REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78577&id=78664 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FIL

D27914: [Kilpper] Port QRegExp to QRegularExpression

apol added inline comments. INLINE COMMENTS > ahmadsamir wrote in urlgrabber.h:185 > I find it confusing to call the pattern "regExp" and the QRegExp object > "m_myRegExp". Then call it m_regularExpression? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2791

D28200: Enable wrapping of error messages which use KMessageWidget

develoot added a comment. In D28200#633124 , @ngraham wrote: > Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? My email address is devel...@gmail.com. thanks. REPOSITO

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven updated this revision to Diff 78663. meven added a comment. Fix touchpad scrollFactor loading, rename 'Scroll speed' to 'Scrolling speed' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=78635&id=78663 BRANCH arcpatch-D28331 REVISION

D28054: Made window backgroun color lighter

niccolove abandoned this revision. niccolove added a comment. https://phabricator.kde.org/D28317 Better REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28054 To: niccolove, #vdg, ngraham Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +KIconLoader::global()->setCustomPalet

D28330: Color icons in titlebar if possible

kossebau added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +KIconLoader::global()->setCustomPale

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I don't think we're planning on changing Breeze Light or Breeze dark as a part of this Tools Area change. IMO they both become more coherent, implementing a unibody look that's entirely light or dark, while the new Breeze color scheme implements the color split betwe

D28317: Adjust default color scheme and titlebar appearance for Tools Area

The-Feren-OS-Dev added a comment. In D28317#635865 , @ngraham wrote: > Sure, that seems reasonable. I guess the question is whether we should ship it in this repo, or make it a GHNS thing, as with the other old colorschemes like Norway, Wonton S

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Some comparisons with and without the filled circle: F8201574: Kate - circle.png F8201576: Kate - no circle.png F8201578: Plasma config window - circle.png

D28333: Add a new daemon for stats monitoring

davidedmundson updated this revision to Diff 78658. davidedmundson added a comment. Drop object library, it was too cool for some cmake versions REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=78625&id=78658 BRANCH master REVISION DETAIL htt

D28341: Use new simpler way to disable session management in services

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9be7dedb87ea: Use new simpler way to disable session management in services (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28

D27914: [Kilpper] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > Why did you change how it works right here? I find it confusing to call the pattern "regExp" and the QRegExp object "m_myRegExp". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D28330: Color icons in titlebar if possible

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Quite nice, quite nice. REPOSITORY R31 Breeze BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D28330 To: davidre, #plasma, #vdg, ngraham Cc: ngraha

D27914: [Kilpper] Port QRegExp to QRegularExpression

apol added inline comments. INLINE COMMENTS > urlgrabber.h:185 > private: > - QRegExp m_myRegExp; > + QString m_regexPattern; > + QStringList m_regexCapturedTexts; Why did you change how it works right here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven added a comment. In D28331#635969 , @ngraham wrote: > These KCMs have X11 versions too. They are not Wayland-specific. I'm not a fan of adding this feature only on Wayland. By those KCM, I meant their frontend (they have each 1 for

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

ngraham added a comment. These KCMs have X11 versions too. They are not Wayland-specific. I'm not a fan of adding this feature only on Wayland. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28331 To: meven, #kwin, #plasma, davidedmundson, ervin, bport, cros

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven added a comment. In D28331#635945 , @ngraham wrote: > So is this Wayland-only? The dependent patch says it's for Wayland. Yes it is wayland-only, the two kcms here are Wayland specific. REPOSITORY R119 Plasma Desktop REVISION DET

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

ngraham added a comment. So is this Wayland-only? The dependent patch says it's for Wayland. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28331 To: meven, #kwin, #plasma, davidedmundson, ervin, bport, crossi, hchain Cc: ngraham, zzag, plasma-devel, Orage, L

D28347: Port services and shell runner away from KRun

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Use `ApplicationLauncherJob` and `CommandLauncherJob`. Also, for services runner pass a `

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a subscriber: manueljlin. ngraham added a comment. In D28317#635580 , @broulik wrote: > You are not changing the close button to not be a filled circle, are you? Heh, I forgot to undo that change in my screenshots; I turn it

D28341: Use new simpler way to disable session management in services

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL htt

D28289: Refactor of OverlaySheet

ngraham added a comment. In D28289#635601 , @mart wrote: > I'm thinking to maybe *always* show the header with separator line and all even if empty when there is a close button... Makes sense to me, yeah. REPOSITORY R169 Kirigami REVI

D28339: [kapplymousetheme] Avoid loading QPT

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D28339 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, Orage, LeGast00n, T

D28338: [PowerDevil Runner] Remove unused KRun include

This revision was automatically updated to reflect the committed changes. Closed by commit R120:62a7e1c464e4: [PowerDevil Runner] Remove unused KRun include (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28338?vs=78638&id=78642

D28339: [kapplymousetheme] Avoid loading QPT

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Cuts time down significantly. Ideally we should kill this binary, but th

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78639. davidre added a comment. Use decoration()->fontColor() REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78618&id=78639 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

  1   2   >