broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY Use `ApplicationLauncherJob` and `CommandLauncherJob`. Also, for services runner pass a `KServiceAction` to the job so it invokes the appropriate jump list action TEST PLAN Depends on D28295 <https://phabricator.kde.org/D28295> - Running normal programs still works - Invoking jump list action entries still works - Running programs with spaces in their desktop file (checking if that `QUrl` breaks some encoding) still works - Running shell commands still works - Running shell commands in terminal (unchanged) still works - When program fails to launch, I now get a nice plasma notification Makes me wonder if we should do the `notifyAccessed` stuff in the job as well? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28347 AFFECTED FILES runners/services/CMakeLists.txt runners/services/servicerunner.cpp runners/shell/CMakeLists.txt runners/shell/shellrunner.cpp To: broulik, #plasma, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
