ngraham added a comment.

  If you're gonna have the function live inside the `onAgendaUpdated:` handler 
and only be used once, it might as well not be a function at all. :) If you 
want to keep it a function, it would be good to put it higher up in the file, 
so it can potentially be used by other things in the future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to