[Breeze] [Bug 418949] New: plymouth-theme-breeze should have a background/wallpaper option

https://bugs.kde.org/show_bug.cgi?id=418949 Bug ID: 418949 Summary: plymouth-theme-breeze should have a background/wallpaper option Product: Breeze Version: unspecified Platform: Other OS: Linux

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` module? It actually uses it inside already, but with some bugs, that prevents from building last patch. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched

D28068: Cleanup file resolving

keithzg requested changes to this revision. keithzg added a comment. This revision now requires changes to proceed. Compiles when included in an Android Debug build but when attempting to run an application I hit an immediate crash on startup with: name=Android logcat QQmlApplicationE

D28089: [applets/systemtray] Fix expanded representation's internal margins

This revision was automatically updated to reflect the committed changes. Closed by commit R120:695fec4a2d41: [applets/systemtray] Fix expanded representation's internal margins (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D280

D28089: [applets/systemtray] Fix expanded representation's internal margins

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM both visually and codewise. REPOSITORY R120 Plasma Workspace BRANCH fix-popup-margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D28089 To: ngraham, #vd

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. In D27160#628867 , @ngraham wrote: > LGTM now. @broulik, are you good with this? > > There are some funky margins that I think are the fault of the pop-up itself, due to the recent header patch. Will investigate that.

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

This revision was automatically updated to reflect the committed changes. Closed by commit R31:f944832fd0e5: Fix Defaults not being set properly in Breeze window decoration settings for… (authored by paulm, committed by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabr

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

ngraham added a comment. In D28087#628877 , @paulm wrote: > In D28087#628873 , @ngraham wrote: > > > Nice. Can we have an email address so the patch gets landed with correct authorship information?

D28090: [applet] Fix button bar right margin

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Button row was incorrectly adding unnecessary extra right padding; see D28089

D28089: [applets/systemtray] Fix expanded representation's internal margins

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is a pre-existing problem, but became much more visible with D27189

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

paulm added a comment. In D28087#628873 , @ngraham wrote: > Nice. Can we have an email address so the patch gets landed with correct authorship information? No problem: Paul McAuley (surprised you don't get this with the submitted

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

ngraham added a comment. Nice. Can we have an email address so the patch gets landed with correct authorship information? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28087 To: paulm, #breeze, hpereiradacosta Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-O

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Many thanks ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28087 To: paulm, #breeze, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Fer

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham accepted this revision. ngraham added a reviewer: broulik. ngraham added a comment. LGTM now. @broulik, are you good with this? There are some funky margins that I think are the fault of the pop-up itself, due to the recent header patch. Will investigate that. REPOSITORY R120 P

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 77796. cblack added a comment. FillWidth the combobox REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77794&id=77796 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL https://ph

D27874: Disable the audio stream indicator for IOTM by default

ngraham added a comment. I won't block this, but personally I don't find the indicator to be a problem with my IOTM. When I click on an icon, I'm almost always clicking on a pixel adjacent to the screen edge, which is on the other side of where the audio indicator is drawn, so it never gets

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Erm F8180076: Screenshot_20200316_193743.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham Cc: kmaterka, iasensio, ndavis, broulik, g

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Thanks! Now we have a new problem though: the default icon size for list view is synchronized with the default icon size for icon view, so it's now gigantic by default: F8180048: Screenshot_20200316_190912.png We need

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 77794. cblack added a comment. Unflatten combobox REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77781&id=77794 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL https://phabri

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. I'm not sure I agree, but this flat version doesn't look like a combobox at all. TBH I don't like it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham Cc: kmaterka, iasensio, ndavi

D28053: Make the animation slider more granular

This revision was automatically updated to reflect the committed changes. Closed by commit R119:06abda3d429b: Make the animation slider more granular (authored by pereira.alex, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28053?

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added a comment. In D27160#628825 , @ngraham wrote: > Hmm, something's kinda weird now. The combobox is flat so it doesn't look like a combobox, which IMO is a regression. Also its alignment feels a bit odd and the pop-up uses a nonstanda

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Hmm, something's kinda weird now. The combobox is flat so it doesn't look like a combobox, which IMO is a regression. Also its alignment feels a bit odd and the pop-up uses a nonstandard highlight style with an incorrect text color: F8179996: Screenshot_20200316_

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

paulm added a comment. In D27938#624385 , @ngraham wrote: > > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp whereby the "Draw a circle around close button" setting does not reset to Defaults properly. > > Would you m

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

paulm created this revision. paulm added reviewers: Breeze, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. paulm requested review of this revision. REVISION SUMMARY This fixes a small bug in the Breeze window decoration settings where clicking on 'Defa

D28086: Improve CMake handling of GNOME libraries

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Good stuff! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched from master) REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gik

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 77791. pereira.alex added a comment. Remove visible: true since its default As requested, removed visible: true lines as requested previously. I prefer to keep makeIconSize() ( its what I would do for me, although would probably rename it to

D27874: Disable the audio stream indicator for IOTM by default

ndavis added a comment. In D27874#628714 , @ngraham wrote: > Title needs updating to reflect the current state of the patch, if you'd still like to propose that we do this. I'm still not sure I understand the point. The indicator is already disa

D28053: Make the animation slider more granular

pereira.alex added a comment. thank you all for the positive feedback :) I am not a kde dev ( don't have a developer account ). I will try to apply for one, but in the meanwhile, anyone could land this? REPOSITORY R119 Plasma Desktop BRANCH more-granular-animation-speed-slider (bran

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Nope, you did everything right! Since `visible` is true by default, you can just remove the `visible: true` lines entirely now. And oersonally I would still remove the `makeIconSize()` function and replace its invocations with the one line of code in that functi

D28086: Improve CMake handling of GNOME libraries

cblack created this revision. cblack added reviewers: Plasma, gikari. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY GNOME libraries were being handled in a manner not as elegant as possible with CMake's built

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 77789. pereira.alex added a comment. Removed commented code Removed commented code as requested. Didn't removed the function, there are two connections to the makeIconSize function on line 1064 and 1072. I edited like this, if no problem. I

D28053: Make the animation slider more granular

broulik accepted this revision. broulik added a comment. Yeah go for it REPOSITORY R119 Plasma Desktop BRANCH more-granular-animation-speed-slider (branched from master) REVISION DETAIL https://phabricator.kde.org/D28053 To: pereira.alex, #plasma, #vdg, ngraham, davidedmundson, brouli

D28055: Fix on wayland activating minimized window will move window to current desktop

pereira.alex added a comment. In D28055#628705 , @zzag wrote: > > it will put window to VD1 and VD2. > > It seems to me like this bug must be fixed in KWin rather than the task manager. In what I understand, wayland allows to specify

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D28076#628760 , @gikari wrote: > I tried to change these ones to `GTK3_LIBRARY` and `GLIB2_LIBRARY`, but now it throws this: > > /home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:37: undefined re

D27935: Make kwallet-pam work with pam_fscrypt

aacid added inline comments. INLINE COMMENTS > sitter wrote in pam_kwallet.c:329 > Alex did add this check in a dedicated commit > 634464255a82de55e0288f7e425e50f6c409f51d > > and even though I couldn't find a subseque

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. I tried to change these ones to `GTK3_LIBRARY` and `GLIB2_LIBRARY`, but now it throws this: /home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:37: undefined reference to `g_type_check_instance_cast' INLINE COMMENTS > CMakeLists.txt:10 > +

D28081: Populate Greeter process exit stderr

romangg updated this revision to Diff 77784. romangg added a comment. else case REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28081?vs=5&id=77784 BRANCH debug REVISION DETAIL https://phabricator.kde.org/D28081 AFFECTED FILES greeter/main

D28053: Make the animation slider more granular

davidedmundson accepted this revision. davidedmundson added a comment. Change is fine, we deliberately store the value as the raw float to allow any UI separation. Thanks for your first patch. You did everything right. Good stuff. REPOSITORY R119 Plasma Desktop BRANCH more-granular-

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D28076#628706 , @gikari wrote: > Seems like I've made a mistake. This does not build. > > /home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:21:10: fatal error: gtk/gtk.h: No such file or directory

D27874: Disable the audio stream indicator for IOTM

ngraham added a comment. Title needs updating to reflect the current state of the patch, if you'd still like to propose that we do this. I'm still not sure I understand the point. The indicator is already disable-able for both the IOTM and TTM. What value is being gained here? REPOSITORY

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 77781. cblack added a comment. Always show combobox REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77763&id=77781 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL https://phab

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. Seems like I've made a mistake. This does not build. /home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:21:10: fatal error: gtk/gtk.h: No such file or directory 21 | #include | ^~ REPOSITORY R99 KDE Gtk Configuration

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. That's a deal-breaker then. I quite commonly have the following use case: 1. Play music in Elisa 2. Pause the music using my keyboard's play/pause button 3. Watch some Yo

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added a comment. In D27160#628688 , @ngraham wrote: > Detecting when more than one stream is playing seems broken too. If I play two at once, the UI never shows a combobox to let you select which one to control. The combobox can b

D28055: Fix on wayland activating minimized window will move window to current desktop

zzag added a comment. > it will put window to VD1 and VD2. It seems to me like this bug must be fixed in KWin rather than libtaskmanager. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28055 To: pereira.alex, #plasma, zzag Cc: ngraham, plasma-devel, Orag

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added inline comments. INLINE COMMENTS > ConfigIcons.qml:229 > Layout.fillWidth: true > -visible: !isPopup || viewMode.currentIndex === 1 > +visible: true //!isPopup || viewMode.currentIndex === 1 > Don't comment out code, just remove it (applies to

D28055: Fix on wayland activating minimized window will move window to current desktop

ngraham added a reviewer: zzag. ngraham added a comment. Thanks for the patch! In general, don't comment out code, just remove the lines instead. Also if this fixes, 417888, add `BUG: 417888` on its own line somewhere in the description section of this patch. REPOSITORY R119 Plasma Desktop

D28081: Populate Greeter process exit stderr

romangg added inline comments. INLINE COMMENTS > zzag wrote in ksldapp.cpp:256 > Shouldn't it be in an else branch? Yes, thanks! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28081 To: romangg, #plasma Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D28053: Making the Animation Slider more granular

ngraham added subscribers: davidedmundson, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems reasonable to me. I agree that the current steps are not quite granular enough for people who just want to tweak the default setti

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Detecting when more than one stream is playing seems broken too. If I play two at once, the UI never shows a combobox to let you select which one to control. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #

D28081: Populate Greeter process exit stderr

zzag added inline comments. INLINE COMMENTS > ksldapp.cpp:256 > } > +qCritical("Greeter process exitted and we could in no way > recover from that!"); > } Shouldn't it be in an else branch? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Nice, it's gone for me now. However the margins are a bit funky with the new PlasmoidHeader design for the System Tray popups: F8179677: Screenshot_20200316_141954.png REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D28083: Use methods in KF5-activities to switch to previous/next activity

muesli created this revision. muesli added reviewers: ngraham, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY Since the release of KDE Frameworks 5.68.0 we can now use the methods exposed in KActivities:

D28070: [KRDB] Remove GTK3 color export

gikari updated this revision to Diff 9. gikari added a comment. Fix "forgetting to pull local master" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=7&id=9 BRANCH remove-gtk3-color-export-from-krdb (branched from master) REVI

D28070: [KRDB] Remove GTK3 color export

gikari updated this revision to Diff 7. gikari added a comment. Diff against master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=6&id=7 BRANCH remove-gtk3-color-export-from-krdb (branched from master) REVISION DETAIL http

D28070: [KRDB] Remove GTK3 color export

gikari updated this revision to Diff 6. gikari added a comment. Rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=77720&id=6 BRANCH remove-gtk3-color-export-from-krdb (branched from master) REVISION DETAIL https:/

D28081: Populate Greeter process exit stderr

romangg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Give more info in debug output when and how the Greeter porcess exited and what counter-measures are triggered to unregular exits.

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 19:41:09 + Build duration: 36 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 121 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/121/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 19:41:09 + Build duration: 41 sec and counting CONSOLE OUTPUT [...truncated 457

D27957: [GTK Config] Port all settings to KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R99:702607595599: [GTK Config] Port all settings to KConfigWatcher (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27957?vs=77320&

D27956: [Various KCMs] Notify about changes in GTK related settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eede3025c84b: [Various KCMs] Notify about changes in GTK related settings (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27956?vs=77313

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 19:25:54 + Build duration: 30 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 120 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 19:25:54 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated 457

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc added a comment. In D28066#628195 , @apol wrote: > Makes sense to me. +1 > > Since most people who did static builds will be using STATIC_LIBRARY, can you set a fatal error if it's on, so the devs know to use BUILD_SHARED_LIBS instead

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a581035b3f47: [GTK Config] Construct font style by hand instead of relying on Qt function (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricat

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 18:57:18 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 457

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 18:57:18 + Build duration: 34 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/70/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 18:52:33 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 118 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 18:52:33 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT [...truncated

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

This revision was automatically updated to reflect the committed changes. Closed by commit R99:306e01d86ab9: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them (authored by cblack). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28076?vs=77764&id=77768#toc REPOS

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D28076#628617 , @gikari wrote: > > GTK needs to be configured to load the GTK module `colorreload-gtk-module`. > > You mean we need to add `gtk-modules=colorreload-gtk-module` to settings.ini? And how to add this

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. > GTK needs to be configured to load the GTK module `colorreload-gtk-module`. You mean we need to add `gtk-modules=colorreload-gtk-module` to settings.ini? And how to add this module to autoload in Wayland? REPOSITORY R99 KDE Gtk Configuration Tool BRANC

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77764. cblack added a comment. Minor formatting improvements REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77740&id=77764 BRANCH color-reload-module (branched from master) REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D28076#628452 , @gikari wrote: > Nice! Does it need to be manually passed to GTK apps when testing D28072 ? GTK needs to be configured to load the GTK module `colorreload-gtk-

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 77763. cblack added a comment. Replace PE.Heading with Kirigami.Heading REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77684&id=77763 BRANCH media-plasmoid-relayout (branched from master) REVISION D

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 16 Mar 2020 17:41:10 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 17:41:11 + Build duration: 35 sec and counting CONSOLE OUTPUT [...truncated 292 li

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir updated this revision to Diff 77754. ahmadsamir added a comment. Tweak comment REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28079?vs=77753&id=77754 BRANCH l-mainglobpattern (branched from master) REVISION DETAIL https://phabrica

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, dfaure, davidedmundson, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY QMimeDatabase re-adds/prepends the "main" glob pattern (the

D27971: Solid-device-automounter/kcm: correctly update automountOn

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceAutomounterKCM.cpp:66 > > -auto emitChanged = [this] { > - > m_devices->setAutomaticMountOnLogin(kcfg_AutomountOnLogin->isChecked()); > -

D27956: [Various KCMs] Notify about changes in GTK related settings

ervin added a comment. In D27956#625419 , @ngraham wrote: > I'm finding myself wondering why we don't just make everything notify by default. IMHO it's mostly a question of limiting the chatter on the bus. REPOSITORY R119 Plasma Deskto

D25375: Start of the accessibility KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Almost there! INLINE COMMENTS > Bell.qml:53 > +} > +Row { > +Kirigami.FormData.label: i18nc("Defines if the system will use a > sound system bell", "Audible Bel

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. Sorry, I wasn't clear. I mean, I think it would be nice if adjacent quick-tiled windows didn't show shadows on their shared edges. Quick tiled windows would still show shadows on their edges that are not toughing a screen edge or another quick tiled window edge.

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628432 , @ngraham wrote: > In D27892#628109 , @davidre wrote: > > > Please note that his doesn't disable shadows completely for quick tiled windows, only on the ed

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham added a comment. Ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, hi

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Darn. Guess that's gotta get fixed first then. :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljl

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D28042#628179 , @sitter wrote: > I wouldn't terribly mind a second pair of eyes. > > Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. OK, thanks. RE

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77744. ahmadsamir added a comment. Fix comment grammar REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77606&id=77744 BRANCH l-QRE-port (branched from master) REVISION DETAIL https://phabricator.kde.org

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added a comment. In D27160#628387 , @ngraham wrote: > I'm still seeing the binding loop. :( Looks like this is a bug with Plasma's Label component, and not this patch. The Label component the height of the component based off of th

D28064: [applet/notes] Show a "remove" button on the button row

This revision was automatically updated to reflect the committed changes. Closed by commit R114:ef9ecb605dbc: [applet/notes] Show a "remove" button on the button row (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28064?vs=77685&id=

D27944: KCM Colors fix apply button always disabled

davidedmundson added a comment. Apparently my patch doesn't work, so go ahead. Though I don't fully understand why my patch isn't enough REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27944 To: crossi, #plasma, ervin, bport, meven, broulik Cc: davidedmun

D27944: KCM Colors fix apply button always disabled

ervin added a comment. I marked it accepted, but of course this is assuming David's patch wouldn't make it quickly and we'd need the fix here ASAP. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27944 To: crossi, #plasma, ervin, bport, meven, broulik Cc: dav

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > set(PROJECT_VERSION "5.17.80") > -cmake_minimum_required(VERSION 2.8.12) > +cmake_minimum_required (VERSION 3.4) > Extra space REPOSITORY R99 KDE Gtk Configuration Tool BRANCH color-reload-module (branched from master)

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Nice! Does it need to be manually passed to GTK apps when testing D28072 ? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH color-reload-module (bra

Re: Proposal to centralize KCM bugs inside the systemsettings product

On 3/16/20 8:03 AM, David Edmundson wrote: On Mon, Mar 16, 2020 at 1:42 PM Nate Graham wrote: Hmm, you're right. I suppose the applet bugs should be moved back into print-manager then. Would you like me to do that? There are only four bugs in there so it should not generate a flood or emails

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77740. cblack marked 7 inline comments as done. cblack added a comment. Address feedback REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77739&id=77740 BRANCH color-reload-module (branched fr

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added inline comments. INLINE COMMENTS > gikari wrote in CMakeLists.txt:2 > Would you mind making this as a subproject? That's a Meson thing, not a CMake thing. CMake just has add_subdirectory, afaik. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +project(libcolorreload C) > + Why is this needed? > CMakeLists.txt:3 > + > +find_package(PkgConfig REQUIRED) > +include(GNUInstallDirs) Move to parent CMakeLists.txt > CMakeLists.txt:4 > +find_package(PkgConfig REQUIRED) > +i

  1   2   >