ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Almost there!
INLINE COMMENTS
> Bell.qml:53
> + }
> + Row {
> + Kirigami.FormData.label: i18nc("Defines if the system will use a
> sound system bell", "Audible Bell:")
Redo the layout do be more like this:
Audible bell: [] Enable
[] Custom sound file: [ ]
> Bell.qml:54
> + Row {
> + Kirigami.FormData.label: i18nc("Defines if the system will use a
> sound system bell", "Audible Bell:")
> +
Remove this `Kirigami.FormData.label`; the checkbox above already has the same
label
> Bell.qml:144
> + Kirigami.FormData.label: i18nc("Notification Bells", "Notification:")
> + text: i18n("Bell when a gesture is used to toggle an accessibility
> feature")
> +
This isn't a grammatically correct sentence ("bell" is inappropriately used as
a verb).
How about: "Trigger when an accessibility feature is activated with a gesture"
> main.qml:56
> + RowLayout {
> + anchors.margins: Kirigami.Units.largeSpacing
> +
This also needs a height set so that it fills the full height available in the
KCM. probably `anchors.fill: parent` would be appropriate
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25375
To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage,
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra
