pereira.alex updated this revision to Diff 77789.
pereira.alex added a comment.


  Removed commented code
  
  Removed commented code as requested.
  Didn't removed the function, there are two connections to the makeIconSize 
function
  on line 1064 and 1072.
  I edited like this, if no problem. I have to learn a few things and test more 
about
  removing the function as to not introduce some bug. ( this weekend if not a 
problem with you ) ?
  
  Also this is going as an arc diff ( amend ). Should I have created an new 
revision through
  arc diff --create ?
  
  Thanks for the review !

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28057?vs=77656&id=77789

BRANCH
  fix-folderview-popup-icon-list-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28057

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to