D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex updated this revision to Diff 76144. alex added a comment. Adjust comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=76142&id=76144 BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.o

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex created this revision. alex added reviewers: ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The foreach has been refactored and the loadSyntaxes method gets now called directly

D27555: Add a category for kde-only and gnome-only apps

ngraham added a comment. I used to think this was really important but am less sure now. I don't feel the need to push for it, but nonetheless Aleix is right that it's pretty common user request--not just in that bug report but in other places too. So we might not want to dismiss the idea ou

D27565: Hide configure action in Info center mode

ngraham created this revision. ngraham added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY There's nothing to configure, so hide the action that shows the configuration window. B

D27563: [mobile/wifi] Use ScrollViewKCM

ngraham accepted this revision. ngraham added a comment. What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of convergence. REPOSITORY R116 Plasma Network Management Ap

D27561: [kcm/activities] Clip ListView

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R119 Plasma Desktop BRANCH clipactivity REVISION DETAIL https://phabricator.kde.org/D27561 To: nicolasfella, #plasma, ngraham Cc: ngraham, plasma-devel, O

D27559: [kcm/baloo] Clip ListView

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch. REPOSITORY R119 Plasma Desktop BRANCH clip REVISION DETAIL https://phabricator.kde.org/D27559 To: nicolasfella, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, L

D27563: [mobile/wifi] Use ScrollViewKCM

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY This gives the KCM a proper frame/scrollbar

D27556: HiDPI pixmap

apol added inline comments. INLINE COMMENTS > AuthDialog.cpp:108 > > +const qreal dpr = qApp->devicePixelRatio(); > + You should get the dpr from the window, not the qApp. Different screens will have different dprs. > AuthDialog.cpp:133 > if (!pixmap.isNull()) { > -QPoint st

D27555: Add a category for kde-only and gnome-only apps

apol added a comment. In D27555#615425 , @nicolasfella wrote: > -1 > > This "Only KDE apps on KDE, only GNOME apps on Gnome" is an attitude we need to leave behind, not reinforce by introducing such filters. > > The original bug report i

D27561: [kcm/activities] Clip ListView

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the content overflows the frame when scrolling. Same finding/fix as in D2

D27559: [kcm/baloo] Clip ListView

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the content overflows the frame when scrolling REPOSITORY R119 Plasma Deskt

D27556: HiDPI pixmap

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make the big icon at left side sharp in HiDPI screen. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH master REVISION D

D27555: Add a category for kde-only and gnome-only apps

nicolasfella added a comment. -1 This "Only KDE apps on KDE, only GNOME apps on Gnome" is an attitude we need to leave behind, not reinforce by introducing such filters. The original bug report is only about mobile, which is an entirely different story REPOSITORY R134 Discover So

D27555: Add a category for kde-only and gnome-only apps

pino added a comment. Whatever is the outcome of this, please do not use contractions, as they are obscure and they may not work in non-English languages. Also, what about other DEs such as XFCE, LxQt, Cinnamon, Mate, etc? REPOSITORY R134 Discover Software Store REVISION DETAIL https:/

D27555: Add a category for kde-only and gnome-only apps

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's apparently something people like to browse through. BUG: 390630 TEST PLAN Used it REPOSITORY

D27554: reviews: expose the reviewed package version on the delegate

apol added a comment. In D27554#615412 , @ngraham wrote: > Nice! How about putting the version next to the stars, up on the header row? Having 2 text fields growing one against each other is often a source of problems. Could work though.

D27554: reviews: expose the reviewed package version on the delegate

ngraham added a reviewer: VDG. ngraham added a comment. Nice! How about putting the version next to the stars, up on the header row? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27554 To: apol, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast

D27554: reviews: expose the reviewed package version on the delegate

apol added a comment. F8119550: Screenshot_20200221_210428.png #vdg REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27554 To: apol, #plasma Cc: plasma-devel, Orage, LeGast

D27554: reviews: expose the reviewed package version on the delegate

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Helps show which version was reviewed to see if the critiques might have been figured out. BUG: 4176

Re: Policy changes: Adjusting Freezes

+1 Can you put it into calendar terms? Maybe it's easier for everyone to see how it affects by seeing the date sequence. It's some work we'll have to do anyway... Aleix On Thu, Feb 20, 2020 at 6:43 PM David Edmundson wrote: > > Notes from the plasma meeting: > > Freeze proposal: > - Feature

D27348: Port to use level 1 Heading instead of Title

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eb91f8e983f2: Port to use level 1 Heading instead of Title (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27348?vs=75553&id=76112 REV

Re: Policy Changes: Bugzilla statuses

On 2/21/20 12:55 AM, Kai Uwe Broulik wrote: Am 21.02.20 um 00:18 schrieb Nate Graham: We don't have to make VHI-priority bugs release blockers per se, but rather treat them as "please fix this before the release or else users will complain a lot" type of bugs. There's no point in marking infa

D27518: Only enable the "Help" button if khelpcenter is available

apol added a comment. In D27518#615128 , @ahmadsamir wrote: > You mean open the local .docbook with kio_help to get an HTML then open it in a browser? or opening docs.kde.org e.g. https://docs.kde.org/stable5/en/kde-workspace/kcontrol/fonts/ind

D27348: Port to use level 1 Heading instead of Title

ngraham added a comment. No worries. :) How about D27350 too? REPOSITORY R119 Plasma Desktop BRANCH port-to-heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D27348 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, p

D27348: Port to use level 1 Heading instead of Title

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I stand corrected, my apologies. REPOSITORY R119 Plasma Desktop BRANCH port-to-heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D27348 To:

D27522: Fix date-label size in vertical layout

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now using the "Long Date" setting in a double-width panel results in the following: F8118081: Screenshot_20200221_071729.png And "Sho

D27348: Port to use level 1 Heading instead of Title

ngraham added a comment. In D27348#615134 , @davidedmundson wrote: > > PlasmaExtras.Title is deprecated > > Docs don't say anything of the sort I found a deprecation message in the component itself: https://cgit.kde.org/plasma-framew

D23021: [Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

ngraham added a subscriber: ahiemstra. ngraham added a comment. @ahiemstra any ideas here? Maybe you can work your shader magic if this isn't performant enough? :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23021 To: broulik, #plasma, ngraham Cc: ahiem

D27348: Port to use level 1 Heading instead of Title

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > PlasmaExtras.Title is deprecated Docs don't say anything of the sort REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27348

D27482: Update kdeglobals config file for Breeze widgetStyle

ngraham added a comment. I think I did--for me at least. But I won't block this because I'm not sure if my kdesrc-build-built setup is capable of testing kconfig patches adequately. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27482 To: crossi, ngraham, er

D27537: Fix simpleWrite test in kwaylandbackendtest

romangg added a comment. Thanks, but the commit message in wrong as the type must be `test` since this is a fix to an autotest. And the scope `autotest` does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md Also the header is not very expressive. A "fix" can be eve

D27518: Only enable the "Help" button if khelpcenter is available

ahmadsamir added a comment. You mean open the local .docbook with kio_help to get an HTML then open it in a browser? or opening docs.kde.org e.g. https://docs.kde.org/stable5/en/kde-workspace/kcontrol/fonts/index.html ? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator

D27537: Fix simpleWrite test in kwaylandbackendtest

This revision was automatically updated to reflect the committed changes. Closed by commit R110:2fcd093919b8: fix(autotests): fix simpleWrite test in kwaylandbackendtest (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27537?vs=760

D27545: Escape connection name in close dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R116:28c36476fc3b: [kcm] Escape connection name in close dialog (authored by davidedmundson). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D275

D27541: [kded] Set password dialog boxes to plaintext

This revision was automatically updated to reflect the committed changes. Closed by commit R116:762504196246: [kded] Set password dialog boxes to plaintext (authored by davidedmundson). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27

D27542: [kded] Escape notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R116:abe0ed15ec5a: [kded] Escape notifications (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27542?vs=76091&id=76102#toc REPOSITORY R116 Plasma Network Management A

D27543: Set all labels to plain text

This revision was automatically updated to reflect the committed changes. Closed by commit R97:fb1a8474651e: Set all labels to plain text (authored by davidedmundson). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27543?vs=76094&id=76100 REVISION DETAIL h

D27543: Set all labels to plain text

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Similar fix applied to plasma-nm. Looks good to me. REPOSITORY R97 Bluedevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D27543 To: davidedmundson, #plasma, jgruli

D27545: Escape connection name in close dialog

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidedmundson requested review of this revision. REVISION SUMMARY Due to MessageDialog being used we cannot

D27542: [kded] Escape notifications

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Thank you David. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D27542 To: davidedmundson, #plasma, jgrulich Cc: plas

D27541: [kded] Set password dialog boxes to plaintext

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Thank you David. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D27541 To: davidedmundson, #plasma, jgrulich Cc: plas

D27537: Fix simpleWrite test in kwaylandbackendtest

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Please follow commit message guideline. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27537 To: dvratil, #plasma, romangg Cc: romangg,

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

romangg added a comment. It would be nice if I get at least 24 hours to review patches in KScreen/libkscreen. Thanks for the patch. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D27536 To: dvratil, #plasma, davidedmundson, meven Cc: romangg, meven, plasma-d

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

This revision was automatically updated to reflect the committed changes. Closed by commit R110:63cab28e74ee: fix(kwayland): remove code with side-effects from Q_ASSERT (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27536?vs=7608

D27543: Set all labels to plain text

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REPOSITORY R97 Bluedevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D2754

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76093. gvgeo added a comment. Fix problem 3 REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75971&id=76093 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FIL

D27522: Fix date-label size in vertical layout

carewolf updated this revision to Diff 76092. carewolf added a comment. Fixing also for short data and very long dates REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27522?vs=76055&id=76092 BRANCH Plasma/5.18 REVISION DETAIL https://phabricat

D27542: [kded] Escape notifications

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidedmundson requested review of this revision. REVISION SUMMARY CCBUG: 417980 REPOSITORY R116 Plasma Ne

D27541: [kded] Set password dialog boxes to plaintext

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidedmundson requested review of this revision. REVISION SUMMARY CCBUG: 417980 REPOSITORY R116 Plasma Ne

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

meven accepted this revision. meven added a comment. Nice ! REPOSITORY R110 KScreen Library BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 To: dvratil, #plasma, davidedmundson, meven Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added a comment. Is it fine for other reviewers ? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D27395 REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-De

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 76085. alex added a comment. Pass file directly to add_library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76023&id=76085 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL https://

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. @ngraham do you confirm it is not working ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27482 To: crossi, ngraham, ervin, bport, meven, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampal

Re: Plasma Sprint 2020 in Augsburg, Germany

Hello again, I have now booked a hotel for all of us. We'll be staying at Hotel B&B Augsburg, in walking-distance to the venue. Everyone who's had their name on the wiki [1] until now (and is marked with an "ok") was considered. As with sprint tradition I've booked double rooms with separate

D27537: Fix simpleWrite test in kwaylandbackendtest

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The test still fails on removeOutput test, but that's fixed by D27536

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

dvratil updated this revision to Diff 76082. dvratil added a comment. - Add bug reference REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27536?vs=76080&id=76082 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 AFFECTED FI

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6d3d3ffa76a5: KCM look and feel : set proper default values for kwin kdecoration when… (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D27525: Support Qt 5.14 on Android

vkrause added a comment. In D27525#614905 , @apol wrote: > > Assets (QML files and icons) are no longer extracted into the file system, > > but now are available in the android_rcc_bundle QRC file. > > Meaning that we now need to change all