apol added inline comments.

INLINE COMMENTS

> AuthDialog.cpp:108
>  
> +    const qreal dpr = qApp->devicePixelRatio();
> +

You should get the dpr from the window, not the qApp. Different screens will 
have different dprs.

> AuthDialog.cpp:133
>      if (!pixmap.isNull()) {
> -        QPoint startPoint;
> +        QPointF startPoint;
>          // bottom right corner

All are integers, why are you turning it into QPointF?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27556

To: guoyunhe, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Reply via email to