D24101: [GTK3] Improve button appearance

This revision was automatically updated to reflect the committed changes. Closed by commit R98:22637c221ee3: [GTK3] Improve button appearance (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24101?vs=66511&id=66518 REVISION DETAIL

D24101: [GTK3] Improve button appearance

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 and merge to master please. REPOSITORY R98 Breeze for Gtk BRANCH button-fixes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24101 To: cblack, #breeze, n

D24098: Remove unnecessary KF5People dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a27e8ceb53e: Remove unnecessary KF5People dependency (authored by heikobecker). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24098?vs=66501&id=66514 REVI

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

This revision was automatically updated to reflect the committed changes. Closed by commit R99:d3060530e8f8: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists (authored by heikobecker). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D24101: [GTK3] Improve button appearance

ngraham added a comment. The focus changes are definitely a bugfix, likely this whole patch is 5.17 material. Will review later! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24101 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, j

D24101: [GTK3] Improve button appearance

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Buttons now have more vertical padding and now indicate if they have keyboard focus. REPOSITORY R

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 110 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/110/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 21:11:54 + Build duration: 4 min 26 sec and counting JUnit Tests Name: pr

Plasma 5.17 beta update

plasma-workspace was updated for moved build-dep on appstream-qt http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/plasma-workspace/5.16.90_to_5.16.90.1/changes_report.html http://download.kde.org/unstable/plasma/5.16.90/plasma-workspace-5.16.90.1.tar.xz plasma-workspace;Plasma/5.17;2739

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 21:11:14 + Build duration: 47 sec and counting CONSOLE OUTPUT [...truncated 4

D11352: Use consistent ordering for System Tray items

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0df34cc3f7b8: Use consistent ordering for System Tray items (authored by Pitel, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 88 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/88/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 20:43:39 + Build duration: 3 min 10 sec and counting JUnit Tests Name: (root) Fai

D24097: Use symbolic icon in intro page

This revision was automatically updated to reflect the committed changes. Closed by commit R124:95316aa9deec: Use symbolic icon in intro page (authored by tienisto, committed by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24097?vs=66499&id

D24098: Remove unnecessary KF5People dependency

heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Not longer needed after 84c8dade3ce0c9cad9da26b083c954655266c639

D24097: Use symbolic icon in intro page

tienisto created this revision. tienisto added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tienisto requested review of this revision. REVISION SUMMARY Use the monochrome icon instead of the colorful icon because of dark themes REPOSITORY R124 Sys

D23378: Check if sddm user exists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. On second look, given that each one does actually do slightly different things, I rescind my request. Since this contains no new translated strings, let's land it on the 5.17 branch. REP

D24096: Restore appstream integration in kicker

bshah added a comment. Whoops, missed this and committed a fix already REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24096 To: arojas, bshah Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf

D24070: Don't use toolTipMainText to show info, rather use the second line

ndavis added a comment. Works just as well as it did before the patch for me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, f

D23241: Show application window icon on AboutPage

caspermeijn added a comment. Can I do anything for this to get merged? REPOSITORY R169 Kirigami BRANCH about_icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23241 To: caspermeijn, mart, apol, #kirigami, hein Cc: bcooksley, sitter, ngraham, plasma-devel, fbampa

D23378: Check if sddm user exists

filipf added a comment. In D23378#517611 , @ngraham wrote: > How about refactoring this "does SDDM user exist?" check into a function so we don't have to write virtually the same code three times? I would need help with this. If someone c

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

heikobecker updated this revision to Diff 66496. heikobecker added a comment. Used the ReadWrite flag to simplify REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24087?vs=66473&id=66496 BRANCH Plasma/5.17 REVISION DETAIL https://phabr

D24096: Restore appstream integration in kicker

arojas created this revision. arojas added a reviewer: bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY This got lost in the move from plasma-desktop TEST PLAN libkickerplugin.so links to appstream-qt, "

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

gikari added inline comments. INLINE COMMENTS > appearancegtk2.cpp:96 > + > if (gtkrc.open(QIODevice::ReadOnly | QIODevice::Text)) { > QString fileContents{gtkrc.readAll()}; I think file creation could be simplified. Just replace WriteOnly flag with ReadWrite here. This would mean

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham accepted this revision. ngraham added a reviewer: broulik. ngraham added a comment. The logic looks sane to me and the UI is good, but the time-to-empty/time-to-full values still don't always update correctly for me after a state change. I suspect this is something that @broulik will

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

The-Feren-OS-Dev added a comment. @fvogt Nope, but now you've mentioned that I've added an extra line if there's no defaults file found to set the Splash Screen to be the Look & Feel name like it originally would do. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

The-Feren-OS-Dev updated this revision to Diff 66489. The-Feren-OS-Dev added a comment. - Based on a code review, re-added original behaviour for Splash Screen setting if there's no 'defaults' file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2311

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham Do you still have issues with this? @ndavis could you try this too? Or anyone else? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66487. mthw added a comment. Re-order again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66485&id=66487 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/b

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#534771 , @ngraham wrote: > Heh, how I get this every time my battery is discharging: F7387261: Screenshot_20190919_102717.png Not here: F7387375: Screenshot_20190919_1

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66485. mthw added a comment. Remove ";", reorder and simplify if clauses REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66482&id=66485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2407

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

fvogt added inline comments. INLINE COMMENTS > kcm.cpp:429 > //TODO: option to enable/disable apply? they don't seem required by UI > design > -setSplashScreen(m_selectedPlugin); > setLockScreen(m_selectedPlugin); If the if block above is not entered, this is not done anymore. Int

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Heh, how I get this every time my battery is discharging: F7387261: Screenshot_20190919_102717.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: nda

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw marked 6 inline comments as done. mthw added a comment. Is the formatting OK? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66482. mthw added a comment. Switch lines REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66480&id=66482 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/bat

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but let's see what @apol thinks. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D24087 To: heikobecker, gikari, #pla

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. In D24070#534721 , @mthw wrote: > I can do that if @ngraham agrees. Yeah alright, I don't have any strong negative preference. Consistency with the volume applet's tooltip is also another argument in favor. REPOS

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66480. mthw added a comment. Use battery at X% REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66476&id=66480 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applet

D24070: Don't use toolTipMainText to show info, rather use the second line

ndavis added a comment. I think it's redundant to say "change level" since the percentage is always the charge level. I also think keeping the language consistent is a good idea. The volume tooltip says "Volume at %", which is why I originally suggested "Battery at %". REPOSITORY R120 Pla

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. I can do that if @ngraham agrees. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, al

D24070: Don't use toolTipMainText to show info, rather use the second line

ndavis added a comment. In D24070#534719 , @mthw wrote: > @ndavis So, generally, you would like to switch the two lines? Yes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ndavis So, generally, you would like to switch the two lines? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

Plasma 5.17 beta out and branches made

Plasma 5.16.90 is now released https://www.kde.org/announcements/plasma-5.16.90.php This is a beta release with final due in three weeks time. Please test it and work on bug fixes in the Plasma/5.17 branches. Features can go into master. No string changes or new build-dependencies in Plasma/5.1

D24070: Don't use toolTipMainText to show info, rather use the second line

ndavis added a comment. In D24070#534585 , @ngraham wrote: > In D24070#534447 , @ndavis wrote: > > > In D24070#534378 , @broulik wrote: > > > > > Volume

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66476. mthw added a comment. un-capitalize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66474&id=66476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/ba

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added inline comments. INLINE COMMENTS > batterymonitor.qml:70 > +if (remainingTime > 0) { > +return i18n("%1 Remaining", > KCoreAddons.Format.formatDuration(remainingTime, > KCoreAddons.FormatTypes.HideSeconds)) > +} un-capitalize the R > batte

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. In D24070#534687 , @mthw wrote: > In D24070#534676 , @ngraham wrote: > > > Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#534676 , @ngraham wrote: > Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time to empty" number always reads as 0:00 for me: F7386917: Screenshot_20190919_092713.png <

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66475. apol added a comment. Polish REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66467&id=66475 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FILES CMakeLists.txt

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time to empty" number always reads as 0:00 for me: F7386917: Screenshot_20190919_092

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66474. mthw added a comment. re-added powermanagementDisabled and fixed white spaces REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66470&id=66474 BRANCH master REVISION DETAIL https://phabricator.k

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY After a9f3a3d saveSettingsPrivate() errors out

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66470. mthw added a comment. Made changes, according to instructions, tested, should work correctly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66431&id=66470 BRANCH master REVISION DETAIL https:

D24011: Provide a telemetrics kcm module for Plasma

ngraham added a comment. Thanks, looking better. I don't see explanatory text below the combobox yet; looks like that part isn't quite working. Also, suppose I want to contribute both usage and system information, how do I do that? The wording in the combobox implies that I can only

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 44 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 14:32:02 + Build duration: 21 min and counting CONSOLE OUTPUT [...truncated 258 lines

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 109 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/109/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 14:30:32 + Build duration: 23 min and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 87 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 14:32:08 + Build duration: 20 min and counting CONSOLE OUTPUT [...truncated 264 l

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 398 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/398/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 14:30:32 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 275

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 14:28:31 + Build duration: 6 min 45 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/13/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 19 Sep 2019 14:28:24 + Build duration: 4 min 33 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 26 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 14:28:31 + Build duration: 4 min 23 sec and counting CONSOLE OUTPUT [...truncated

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66467. apol added a comment. Iterated with Nate's feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66351&id=66467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FI

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. In D24070#534447 , @ndavis wrote: > In D24070#534378 , @broulik wrote: > > > Volume shows the percentage in the main title so this is inconsistent now. > > Perhaps instead

D24080: Fix copying urls to the clipboard

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Addresses an original porting issue. TEST PLAN Addresses the issue in the feedback kcm I've been dev

D21524: Keep existing configurations' strings               

heikobecker added a comment. This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console Start

D24063: applets/kicker: Remove unused commands from Messages.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1528162b167f: applets/kicker: Remove unused commands from Messages.sh (authored by aspotashev). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24063?vs=66412

D24070: Don't use toolTipMainText to show info, rather use the second line

ndavis added a comment. In D24070#534378 , @broulik wrote: > Volume shows the percentage in the main title so this is inconsistent now. > Perhaps instead show some other information like remaining time in the subtext? Yes, perhaps it s

D24068: docs: add contributing guide

yurchor added a comment. Thanks in advance for fixing this minor typo. INLINE COMMENTS > CONTRIBUTING.md:58 > +## Contact > +Real-time communications about the project happens on the IRC channel > `#plasma` on freenode and the bridged Matrix room `#plasma:kde.org`. > + Typo: "communication"

D24073: Revert "Revert "i18n fixes""

This revision was automatically updated to reflect the committed changes. Closed by commit R104:a81d5e0d4405: Revert "Revert "i18n fixes"" (authored by ltoscano). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24073?vs=66443&id=66445 REVISION DETAIL https:/

D24073: Revert "Revert "i18n fixes""

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Ok, to not block the release translations any longer I accept this as a short-term solution and created task T11721 on Kirigami board about this issue

D24073: Revert "Revert "i18n fixes""

bshah added a comment. As mentioned on IRC, +1 to this patch. If this violates a coding style, we can discuss it in the mailing-list/IRC later and either - come up with solution to this affecting translations - come up with exception and make change accordingly, but let's try to no

D24073: Revert "Revert "i18n fixes""

romangg added a comment. As said in the revert if currently there is no other way of making translations of long sentences work in QML while respecting the line chars limit this needs to go in of course. I would like to see this resolved long-term such that: - Translations work of c

D24073: Revert "Revert "i18n fixes""

ltoscano created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ltoscano requested review of this revision. REVISION SUMMARY As translator, any supposed arbitrary coding style which breaks the translation is not acceptable. We can certainly discuss th

D24068: docs: add contributing guide

romangg added a comment. In D24068#534383 , @broulik wrote: > > The CHANGELOG keyword is cumbersome to use because the summary line most often already tells sufficiently what the commit is about. So it would only be a repetition of what is alrea

D24054: Set default visibility for per-process network sensors to true

This revision was automatically updated to reflect the committed changes. Closed by commit R106:ec2532c5f2df: Set default visibility for per-process network sensors to true (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24054?vs=6638

D24053: Properly handle ProcessAttribute enabled and default visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled and default visibility (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2405

D24068: docs: add contributing guide

romangg updated this revision to Diff 66437. romangg added a comment. - Explain types REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66424&id=66437 BRANCH contributingGuide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED FILES

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 09:10:06 + Build duration: 42 min and counting JUnit Tests Name: (root) Failed: 0 tes

D24068: docs: add contributing guide

broulik added a comment. > The CHANGELOG keyword is cumbersome to use because the summary line most often already tells sufficiently what the commit is about. So it would only be a repetition of what is already written. Besides why should we want to have a disparity between changelog and com

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 09:04:55 + Build duration: 22 min and counting

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 19 Sep 2019 09:03:54 + Build duration: 17 min and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/42/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 08:56:00 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated 258 lines

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

victorr added a comment. The “Apply” button stops working after the “Times” mode is activated. Before turning on this mode, the rest works fine. To fix, you can delete the line “Mode=Times" from the file ~/.config/kwinrc and restart the session. https://bugs.kde.org/show_bug.cgi?id=4

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added a comment. Volume shows the percentage in the main title so this is inconsistent now. Perhaps instead show some other information like remaining time in the subtext? INLINE COMMENTS > batterymonitor.qml:82 > } > +if (powermanagementDisabled) { > +

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 08:49:49 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated 746

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 08:26:44 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated 741

D24068: docs: add contributing guide

romangg added a comment. In D24068#534288 , @ngraham wrote: > In terms of changelogs, you can already use the FEATURE: and CHANGELOG: tags in your commit message. That's already there and similarly we're not actually using it. Might it make sens

D24070: Don't use Main text in Tooltip to show info, rather use second line

mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/batterymonitor/package/co