D20863: Allow folder view elements to be be dropped using other Action than Copy

ngraham added a comment. Me too, it's a bit unnerving the first few times you do it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20863 To: meven, ngraham, hein Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D20863: Allow folder view elements to be be dropped using other Action than Copy

meven added a comment. In D20863#461260 , @ngraham wrote: > Now don't forget to merge to master. :) > > git checkout Plasma/5.15 > git pull > git checkout master > git merge -s recursive -Xours origin/Plasma/5.15 > git push

D21033: Panels: reset shadow pixmaps on theme change

This revision was automatically updated to reflect the committed changes. Closed by commit R120:93bdcda49702: Panels: reset shadow pixmaps on theme change (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21033?vs=57592&id=57623

D21012: [PanelView] Update mask as last on resize event (& move one for consistency)

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b51fd4bab2a5: [PanelView] Update mask as last on resize event (& move one for consistency) (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D21029: UpdatesPage: Don't try to translate version numbers

apol added a comment. Yep, change isn't correct. A solution would be to ad an installedVersion && availableVersion ? i18n(...) : "". Or fix i18n() to not complain about "", although I'm pretty sure it's not easily doable. REPOSITORY R134 Discover Software Store REVISION DETAIL http

D21030: [WidgetExplorer] Fix blurry previews

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! Stable branch please. REPOSITORY R119 Plasma Desktop BRANCH no-blurry-previews-widget-explorer (branched from master) REVISION DETAIL https://phabricator.kde.org/D21030 To:

D21012: [PanelView] Update mask as last on resize event (& move one for consistency)

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Makes sense and works fine, thanks REPOSITORY R120 Plasma Workspace BRANCH updatemasklast REVISION DETAIL https://phabricator.kde.org/D21012 To: kossebau, #plasma, broulik Cc: apo

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

broulik added a comment. Looks like a recent policy change in Chrome, only my Chrome 74 seems affected and I recall it working half a year ago when I implemented this feature. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20830 To: broulik, #pla

D21030: [WidgetExplorer] Fix blurry previews

filipf updated this revision to Diff 57617. filipf added a comment. use Math.floor instead of Math.round REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21030?vs=57588&id=57617 BRANCH no-blurry-previews-widget-explorer (branched from master) REVIS

D21030: [WidgetExplorer] Fix blurry previews

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > WidgetExplorer.qml:295 > keyNavigationWraps: true > -cellWidth: (width - units.smallSpacing) / 2 > +cellWidth: Math.roun

D21038: Also store the player's frame ID

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The extension is also injected into iframes on a website. They share the sam

D20969: [potd] Modernize configuration settings

filipf added a comment. In D20969#461288 , @ngraham wrote: > Few changes needed to the Description before landing: > > - Is the `NOTE` still accurate? I don't see that behavior anymore. > - Also we're no longer porting to QQC2 Fixed.

D20969: [potd] Modernize configuration settings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Few changes needed to the Description before landing: - Is the `NOTE` still accurate? I don't see that behavior anymore. - Also we're no longer porting to QQC2 REPOSITORY R114 Pla

D20863: Allow folder view elements to be be dropped using other Action than Copy

ngraham added a comment. Now don't forget to merge to master. :) git checkout Plasma/5.15 git pull git checkout master git merge -s recursive -Xours origin/Plasma/5.15 git push --- I have a handy shell function `kmerge` that does this for me and then check

D20863: Allow folder view elements to be be dropped using other Action than Copy

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b753301b74ac: Allow folder view elements to be be dropped using other Action than Copy (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf planned changes to this revision. filipf added a comment. In D21027#461230 , @ngraham wrote: > Gotcha. At least use a function instead of duplicating the same code in each button. Ah yeah, rereading your original comment I now see

D21027: [Notes] Fix icons being almost invisible with light backgrounds

ngraham added a comment. In D21027#461027 , @filipf wrote: > I get what you're saying but that's just how the applet is designed. It's preconfigured SVG backgrounds (you can find them in `/usr/share/plasma/desktoptheme/default/widgets/notes.svgz

D20863: Allow folder view elements to be be dropped using other Action than Copy

ngraham added a comment. Please land this on the stable branch (`Plasma/5.15`) before tagging in two days, then merge to master. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 If you need help, don't hesitate to let me know! REPOSITORY R119

D20863: Allow folder view elements to be be dropped using other Action than Copy

meven added a comment. @hein is it ok ? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20863 To: meven, ngraham, hein Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D21035: Remove disconnected network devices from Network Monitor.

bernhardu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bernhardu requested review of this revision. REVISION SUMMARY USB network devices or VirtualBox bridges are just temporarily up and active in the system. The Network Monitor Widget au

D21033: Panels: reset shadow pixmaps on theme change

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH resetshadowpixmapsonthemechange REVISION DETAIL https://phabricato

D21030: [WidgetExplorer] Fix blurry previews

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Round the cell width to avoid getting blurry previews. NOTE: It also seems further improvements could be done for the icons them

D20265: Introduce libnotificationmanager

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in jobsmodel_p.cpp:358 > you're not filtering the jobs based on the desktopEntry > > every app gets notified about anyones percentage? Good catch, forgot a check for `desktopEntry` there > hein wrote in notificationgroupingp

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationgroupcollapsingproxymodel.cpp:175 > +emit dataChanged(idx, idx, dirtyRoles); > +emit dataChanged(idx.child(0, 0), idx.child(rowCount(idx) - 1, 0), > dirtyRoles); > + I know this really sucks, and I'm not going to be pushy on this

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationgroupcollapsingproxymodel.cpp:52 > +Q_UNUSED(bottomRight); // what about it? > +Q_UNUSED(roles); > + Not actually unused. `bottomRight`: You sure the source model will emit for single cells? Otherwise you need to

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationgroupingproxymodel.cpp:38 > + > +bool NotificationGroupingProxyModel::appsMatch(const QModelIndex &a, const > QModelIndex &b) const > +{ Careful there - these will match when both are empty, which is why the libtm version tests for that

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationsmodel.cpp:57 > + > +int rowOfNotification(uint id) const; > + Could be worth making `inline` maybe? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma Cc: hein, mart, nicol

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notifications.cpp:828 > +{ > +return QHash { > +{IdRole, QByteArrayLiteral("notificationId")}, // id is QML-reserved While this isn't an objection, I usually use QMetaEnum to compute this from the enum instead of having a block of stuff

D21029: UpdatesPage: Don't try to translate version numbers

pino added a comment. The explanation of this change does not match the code changes: the code never translated the version numbers, but it composed a string showing the version numbers before and after the upgrade. Could it simply be that one of the two (for example `installedVersion`) is

D21029: UpdatesPage: Don't try to translate version numbers

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Fixes a I18N_ARGUMENT_MISSING warning in the ui that appears sometimes while discover is looking for updates. TEST PLAN Ve

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notifications.h:217 > +IsGroupRole = Qt::UserRole + 2, ///< Whether the item is a group > +GroupChildrenCountRole, ///< The number of children in a group. > +ExpandedGroupChildrenCountRole, ///< The number of children in a > g

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf added a subscriber: broulik. filipf added a comment. I get what you're saying but that's just how the applet is designed. It's preconfigured SVG backgrounds (you can find them in `/usr/share/plasma/desktoptheme/default/widgets/notes.svgz`). I'm not really introducing any hardcoding th