filipf planned changes to this revision. filipf added a comment.
In D21027#461230 <https://phabricator.kde.org/D21027#461230>, @ngraham wrote: > Gotcha. At least use a function instead of duplicating the same code in each button. Ah yeah, rereading your original comment I now see that bit went over my head, that would be much better so I will make those changes. >> The other thing about components is that Plasma Components doesn't support `icon.color`. I'd have kept using it, but PC2 spews out an error, while with PC3 it didn't complain but didn't work anyway. > > OK, that makes sense. Can you make it a bit more clear in the Description? Yep! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21027 To: filipf, #plasma, #vdg, ngraham Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
