D20908: RFC: Redesign QML applet configuration windows

GB_2 added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

hein added a comment. Looks great to me. Subtle visual refreshs like this are very appreciated, especially when they improve consistency, too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: hein, plasma-devel, jra

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. Beautiful. Now we just need to do it in Breeze too, and turn off those borders when using Breeze window decorations. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: plasma-devel, jrale

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:007a86a603df: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D20905: [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:ad66b200036e: [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D20828: Correctly show memory sizes > 4 GiB on 32 bit Linux

This revision was automatically updated to reflect the committed changes. Closed by commit R102:10d60170eaa4: Correctly show memory sizes > 4 GiB on 32 bit Linux (authored by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20828?vs=56992&id=57228 R

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 for visuals, everything works too REPOSITORY R114 Plasma Addons BRANCH modernize-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D20896 To: ngr

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57227. filipf added a comment. have top separator fill the window's width REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57218&id=57227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D209

D20851: [Pager] Improve label legibility

ngraham updated this revision to Diff 57220. ngraham added a comment. Revert unnecessary change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57219&id=57220 BRANCH improve-pager-label-legibility (branched from master) REVISION DETAIL

D20851: [Pager] Improve label legibility

ngraham updated this revision to Diff 57219. ngraham added a comment. Yeah it's way better without any visual changes except just moving the label to the top REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57063&id=57219 BRANCH improve-pa

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. In D20908#458307 , @filipf wrote: > I agree, the sidebar looks a bit lost there. So do you mean to turn on the separator in KWin or add it ourselves like this? > > F6800729: image.png

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. I agree, the sidebar looks a bit lost there. So do you mean to turn on the separator in KWin or add it ourselves like this? F6800729: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. In general, this is a change I hugely support. This look for sidebars is already used in System Settings, Discover, and other QML-ish apps. It's attractive and clean, and provides adequate separation between dissimilar elements. Looking at your Breeze Light and

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57218. filipf added a comment. remove unrelated changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57217&id=57218 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED FILES

D20908: RFC: Redesign QML applet configuration windows

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This is patch is a sketch meant to open up discussion about redesigning our configuration windows. We currently have insconsiste

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.xml:13 > - > - true > If you change the name of any properties in the config xml file, users who have altered the settings will unexpec

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57216. GB_2 marked 3 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20906?vs=57211&id=57216 BRANCH kimpanel-port-settings-page-to-qqc2-plus-kirigami

D20905: [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57215. ngraham added a comment. Whoops, I forgot the Advanced page. Also do that! REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20905?vs=57209&id=57215 BRANCH timer-modernize-settings-window (branched from mas

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

ngraham added a comment. FWIW the Pager widget uses radio buttons for its vertical/horizontal chooser UI. We might want to consider doing the same thing here too. I think it's a nicer UI than having using a checkbox, as it makes the opposite state 100% explicit. INLINE COMMENTS > ConfigApp

D20859: Crash in sddmthemeinstaller invalid use of errorString

johngehrig added a comment. Thanks for the clarification! I understand what you are saying :) I see errorString() has a fallback path stating the app is broken for invalid errror() values. Agreed, this isn't right... Yes, setting a breakpoint at the destructor for job was my plan. I

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. @atulbi were you able to get in touch with @romangg? Can I help in any way? The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules/Plasma_5) and it would really nice to finally have full Libinput support in our KCM i

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 29 Apr 2019 18:34:49 + Build duration: 1 hr 9 min and counting CONSOLE OUTPUT [...truncated

D19011: Thunderbolt KCM and KDED module

broulik added a comment. I was wondering, since this thing has like a lib and kded and what not, wouldn't it make sense to have that be a separate module and repository rather than in plasma-desktop "just because" all kcms are in there? For the lack of Thunderbolt devices I have only tri

D20859: Crash in sddmthemeinstaller invalid use of errorString

davidedmundson added a comment. > You are saying "this" (parent window of dialog) is deleted out from under KMessageBox while it is in a waiting state? ~ish We know KJob calls deleteLater at the end of KJob::exec() We know KMessageBox spawns a new event loop I think it's deleting

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout - Improve some strings - Follow the KDE HIG - Improve look of

D20859: Crash in sddmthemeinstaller invalid use of errorString

davidedmundson added a comment. > What's the harm in adding a line of defensive code so that we conform to the API? First step to fixing a bug is understanding the bug. Your description of what is happening does not match the code. From KJob. int KJob::error() const {

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57210. ngraham added a comment. Use non-symbolic version of the `find-location` icon REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20896?vs=57200&id=57210 BRANCH modernize-settings-window (branched from master

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added inline comments. INLINE COMMENTS > kossebau wrote in ConfigWeatherStation.qml:85 > Where is that documented? Asking because as developer writing new code one > day I am now very confused what to use. > Besides why would there be action icons where this is not the case (at least >

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. This can be closed; the icons in cloudbrowser are no longer tinted. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner, #kirigami, mart Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20905: [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Use standard import names - Adjust some strings

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

kossebau added inline comments. INLINE COMMENTS > ngraham wrote in ConfigWeatherStation.qml:85 > The `-symbolic` suffix means "this icon is always supposed to be monochrome". > However in this case I used the -symbolic version simply because there was no > non-symbolic version in Breeze icons.

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf7a430da31d: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20904

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

GB_2 updated this revision to Diff 57207. GB_2 added a comment. Add QQC2 import name where it was missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20904?vs=57205&id=57207 BRANCH desktoppackage-port-to-qqc2-and-fix-get-new-widgets-button-text

D19752: [Splash KCM] Use InlineMessage for testing error

ngraham added a comment. I think this is useful enough now, and we can tweak the error message later. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19752 To: broulik, #plasma, #vdg, filipf Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragree

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

ngraham added a comment. I don't think we //do// have a consistent style for the import name. In some places it's QQC2, in others it's QtControls, or QtControls2, or nothing at all (as in `WidgetExplorer.qml`). Also we mostly don't add a name for the `Layouts` import, but in a few places we

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

GB_2 added a comment. In D20904#458191 , @ngraham wrote: > I would not even change `QQC` and `QtControls` to `QQC2`. That way the diff will be even smaller. Is the diff being smaller more important than making it consistent? REPOSITORY

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

ngraham added a comment. I would not even change `QQC` and `QtControls` to `QQC2`. That way the diff will be even smaller. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20904 To: GB_2, #plasma, #vdg Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2,

D20863: Allow folder view elements to be be dropped using other Action than Copy

ngraham accepted this revision. ngraham added a reviewer: hein. ngraham added a subscriber: hein. ngraham added a comment. This revision is now accepted and ready to land. @hein is this okay? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2086

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY - Port to QQC2 - Fix "Get New Widgets..." button text TEST PLAN Try pressing Esc in the widget exp

D20859: Crash in sddmthemeinstaller invalid use of errorString

johngehrig added a comment. The API for `errorString()` calls out that it should not be called when `error() == 0`. The code does not explicitly check for this scenario. Somehow users (myself and others) can get into a state where `!rc && error() == 0`, and we are calling `errorString()`

D20859: Crash in sddmthemeinstaller invalid use of errorString

johngehrig added a comment. @anthonyfieroni Yes, I think there also an issue with KAuth here. This machine never gets to the auth prompt, which works fine on another machine. I don't think "jobs" is deleting itself, otherwise we would segfault on "jobs->error()". No? @davidedmundson

D19829: kicker: add option to make root level icons visible

ngraham added 1 blocking reviewer(s): hein. ngraham added a comment. This revision now requires review to proceed. Ultimately it's up to @hein as the maintainer. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg,

D19829: kicker: add option to make root level icons visible

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Works great. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel,

D20902: Add SDDM theme login load feedback

GB_2 closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20902 To: GB_2, #plasma, #vdg, ngraham Cc: abetts, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ma

D20902: Add SDDM theme login load feedback

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH add-sddm-theme-login-load-feedback (branched from master) REVISION DETAIL https://phabricator.kde.org/D20902 To: GB_2, #plasma, #vdg, ngraham Cc: abetts, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen,

D20902: Add SDDM theme login load feedback

GB_2 added a comment. In D20902#458128 , @ngraham wrote: > There's no chance that this could glitch out and leave you in a state where it's not logging in but all the controls are disabled, right? I have used an edited theme with this sin

D20902: Add SDDM theme login load feedback

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Cool, sounds good! REPOSITORY R120 Plasma Workspace BRANCH add-sddm-theme-login-load-feedback (branched from master) REVISION DETAIL https://phabricator.kde.org/D20902 To: GB_2, #

D20901: Hide the new NNP column by default

ngraham added reviewers: broulik, Plasma. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All good, @broulik? REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20901 To: topimiettinen,

D20902: Add SDDM theme login load feedback

ngraham added a comment. There's no chance that this could glitch out and leave you in a state where it's not logging in but all the controls are disabled, right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20902 To: GB_2, #plasma, #vdg Cc: ngraham, #vd

D19829: kicker: add option to make root level icons visible

i.Dark_Templar updated this revision to Diff 57202. i.Dark_Templar added a comment. Rebased to master, but it needs testing. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19829?vs=54094&id=57202 REVISION DETAIL https://phabricator.kde.org/D19829

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added inline comments. INLINE COMMENTS > kossebau wrote in ConfigWeatherStation.qml:85 > While I see this: what are all those "-symbolic" variants and when would one > use it? Is that documented anywhere? I expeted something on hig.kde.org, but > found nothing. The `-symbolic` suffix m

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57200. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20896?vs=57181&id=57200 BRANCH modernize-settings-window (branche

D20901: Hide the new NNP column by default

topimiettinen added a subscriber: broulik. topimiettinen added a comment. requested by @broulik REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20901 To: topimiettinen Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D20902: Add SDDM theme login load feedback

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Currently, when you log in you can see a short freeze which looks bad. This patch adds some feedback b

D20901: Hide the new NNP column by default

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabrica

D20854: process: show SELinux context

topimiettinen updated this revision to Diff 57197. topimiettinen added a comment. hide selinux column view by default REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20854?vs=57072&id=57197 BRANCH master REVISION DETAIL https://phabricator.kd

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57196. topimiettinen added a comment. hide cgroup column by default REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57069&id=57196 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:c097927dee21: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize… (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde

D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57194. ngraham added a comment. Tweak a string REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20899?vs=57190&id=57194 BRANCH user-switcher-modernize-settings-window (branched from master) REVISION DETAIL htt

D20788: Reset model when there are new available connections

McPain added a comment. In D20788#458047 , @jgrulich wrote: > You said it's broken so I would preffer not landing a broken patch. I thought it was a regression when I applied this patch. Could reproduce an error (see D20900

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

broulik added inline comments. INLINE COMMENTS > ConfigFilter.qml:208 > +icon.name: "edit-select-all" > +ToolTip.delay: 1000 > +ToolTip.timeout: 5000 I think using `ToolTip` attached property is discouraged as that cannot inherit the default times

D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57190. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20899?vs=57186&id=57190 BRANCH user-switcher-modernize-settings-w

D20900: Reject short PSK passwords

jgrulich added a comment. Then the password dialog should use some sort of validation (we already use it for example in the editor and applet) and do not allow to accept a password which is likely not valid. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabri

D20788: Reset model when there are new available connections

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. You said it's broken so I would preffer not landing a broken patch. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20788 To

D20645: process: add NoNewPrivileges

broulik added a comment. Can you please make sure this column isn't enabled by default? After updating this morning I suddenly had an "NNP" column I didn't ask for or knew what it was REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20645 To: topimiettinen,

D20788: Reset model when there are new available connections

McPain requested review of this revision. McPain added a comment. This revision is now accepted and ready to land. Tomorrow I'll land this patch, but I submitted another one https://phabricator.kde.org/D20900 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://ph

D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

broulik added inline comments. INLINE COMMENTS > configGeneral.qml:46 > +checked: cfg_showFullName > +onCheckedChanged: if (checked) cfg_showFullName = true; > +} Shouldn't that be `onClicked` to only trigger on explicit user interaction? REPOSITORY R114 Plasma Addons REV

D20900: Reject short PSK passwords

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. McPain requested review of this revision. REVISION SUMMARY PasswordDialog accepted all WPA-PSK keys, included ones shorter than 8 characters, which causes s

D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added inline comments. INLINE COMMENTS > configGeneral.qml:86 > +QtControls.ButtonGroup.group: layoutGroup > +text: i18nc("@option:radio", "Picture") > +checked: !cfg_showName && cfg_showFace Maybe we could say "User picture" just to be more precise? > configGener

D20899: [User Switcher] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Adjust some strings to sound a bit more natural

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8690a41b02ad: Provide alternatives for Show Desktop and Minimize All Windows widgets (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20895

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

GB_2 updated this revision to Diff 57184. GB_2 added a comment. org.kde.plasma.showdesktop -> org.kde.plasma.windowmanagement REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20895?vs=57173&id=57184 BRANCH provide-alternatives-for-showdesktop-and-mi

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

kossebau added a comment. So, to give context, this is the seemingly needed change on Plasma code side for the currently planned way forward with T8126#181349 Just uploaded here already as note to self and when needed to have something to point

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

kossebau added a comment. In D18961#410940 , @Zren wrote: > In D18961#410784 , @kossebau wrote: > > > Though it breaks my technically-perfect-solution-aiming engineer's heart :) > > please be pre

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

kossebau added a comment. The plan was to not have reviewers yet, but oh well ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20898 To: kossebau, #plasma, apol, leinir Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jens

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added inline comments. INLINE COMMENTS > kossebau wrote in ConfigUnits.qml:89 > Which version of KDE Frameworks? 5.56 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20896 To: ngraham, #vdg, #plasma, kossebau Cc: filipf, plasma-devel, jraleigh, GB_2, ragr

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

kossebau added inline comments. INLINE COMMENTS > filipf wrote in ConfigUnits.qml:89 > Ignore this, but I can add I'm hitting this bug in 5.15 as well. Which version of KDE Frameworks? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20896 To: ngraham, #vdg, #pla

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added inline comments. INLINE COMMENTS > filipf wrote in ConfigUnits.qml:89 > It was the same before the patch, but how come there's no preselected value > for this option? Ignore this, but I can add I'm hitting this bug in 5.15 as well. REPOSITORY R114 Plasma Addons REVISION DETAIL

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added inline comments. INLINE COMMENTS > ConfigUnits.qml:89 > + > +QtControls.ComboBox { > +id: visibilityComboBox It was the same before the patch, but how come there's no preselected value for this option? > ConfigWeatherStation.qml:69 > > -RowLayout { > -

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

kossebau created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Prepared for execution plan draft of T8126#181349 REPOSITORY R119 Plasma Desktop R

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

kossebau added inline comments. INLINE COMMENTS > ConfigAppearance.qml:69 > > -QtControls.Label { > -Layout.row: 1 > -Layout.column: 0 > -Layout.alignment: Qt.AlignRight > -text: i18nc("@label", "Tooltip:") > -

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

kossebau added a comment. Thanks for the patch, good to have consistency, Cannot test the next days, but could not spot anything raising my eyebrows on a quick look, so if you feel confident, please go ahead and push for field testing ;) About the blank Visibility combobox, that works fo

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Adjust some strings to sound a bit more

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

zzag added a comment. > I would suggest making the ID much more generic. Maybe org.kde.plasma.windowmanagement From perspective of a former Windows user, "minimize all" is the same as "show desktop." REPOSITORY R119 Plasma Desktop BRANCH provide-alternatives-for-showdesktop-and-min

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch, I didn't even check before to make sure we had this... REPOSITORY R119 Plasma Desktop BRANCH provide-alternatives-for-showdesktop-and-minimizeall-widgets (branched from m

D20797: [dict] Modernize configuration window

filipf added a comment. In D20797#457932 , @ngraham wrote: > Is there some trick to applying this? I don't actually see any change to the dictionary widget's configuration window. I got the same problem when I started working on this myself, so

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

davidedmundson added a comment. Concept ++ I would suggest making the ID much more generic. Maybe org.kde.plasma.windowmanagement Then if someone on the store makes "showPresentWindows" or whatever, it can be searchable in the same group. REPOSITORY R119 Plasma Desktop BRANCH

D20797: [dict] Modernize configuration window

ngraham added a comment. Is there some trick to applying this? I don't actually see any change to the dictionary widget's configuration window. I got the same problem when I started working on this myself, so it's not something you did wrong... REPOSITORY R114 Plasma Addons REVISION DETAI

D20788: Reset model when there are new available connections

McPain added a comment. In D20788#457772 , @jgrulich wrote: > I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. I tried to add every single path in the system where there is pkgconfig stuff, but same result, the cloudbrowser folder doesn't get built and there is the invalid command -o message still REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Provide alternatives, so you can quickly switch between the two widgets. TEST PLAN Switch to an alte

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c6a6fe1870e: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout… (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 added a comment. In D20878#457623 , @filipf wrote: > Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed: > > F6798674: image.png

D20894: Remove unused files

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They are compiled but never used since it's all done in QML TEST PLAN Compiles, still works RE

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. I would accept it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

Monday meeting notes for 29/4/2019

Kai Uwe: Work done: - Updated my microphone indicator patch - Blogged about privacy sprint: https://blog.broulik.de/2019/04/privacy-sprint-in-leipzig/ - Kate now offers VI mode toggle in insert/replace menu, making leaving VI mode easier :) - Fixed regression in task manager launchers caused

D20889: [kcolorschemeeditor] Remove useless printf

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cfbb13858f01: [kcolorschemeeditor] Remove useless printf (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20889?vs=57160&id=57162 REVIS

D20889: [kcolorschemeeditor] Remove useless printf

broulik created this revision. broulik added reviewers: Plasma, ochurlaud. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When closing the scheme editor, the KCM reads stdout of the editor to figure out what's

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. In D19829#456234 , @GB_2 wrote: > Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/`arc` in the future: https://community.kde.org/Infrastructure/Phabricator#Us

D19994: Add microphone indicator

broulik updated this revision to Diff 57158. broulik added a comment. - Address comments - Ignore virtual streams REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19994?vs=54606&id=57158 REVISION DETAIL https://phabricator.kde.org/D199

  1   2   >