ngraham added inline comments. INLINE COMMENTS
> kossebau wrote in ConfigWeatherStation.qml:85 > Where is that documented? Asking because as developer writing new code one > day I am now very confused what to use. > Besides why would there be action icons where this is not the case (at least > with the Breeze style)? After all HIG says "Action and status icons [...] > always use the monochrome style." (https://hig.kde.org/style/icon.html) > If other icon themes have different style ideas, that should be fine, after > all that is the idea of themes to also have their own style guide, no? > > So if possible, I would prefer that on changing this icon this is backed by > something proper documented (and fixed where needed, e.g. ensuring there is > an action icon with a normal name if needed) :) You're not the only one confused. :) It's a bit of a mess at the moment, TBH. See T10413 <https://phabricator.kde.org/T10413> For now I've added a normally-named icon without the `-symbolic` suffix to breeze icons (in Frameworks 5.58, so we can use it), and we'll use that here. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20896 To: ngraham, #vdg, #plasma, kossebau Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
