ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > main.xml:13 > - <entry name="use_default_font" type="Bool"> > - <default>true</default> > </entry> If you change the name of any properties in the config xml file, users who have altered the settings will unexpectedly get new values and yell at you (well, whoever triages bugs, i.e. me and Christoph). :) If you do this, you need to provide a kconf update script that adjusts people's settings. See https://techbase.kde.org/Development/Tools/Using_kconf_update Alternatively, you can keep the existing config name and just change the logic in the UI so that it still reads and writes the data in the same way, it's just presented to the user differently. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20906 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
