D20370: [Folder View] Implement a user-configurable setting for label width

ngraham created this revision. ngraham added reviewers: hein, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY It seems impossible to satisfy everyone's preferences regarding label width in Folder

D20368: [Folder View] Use a more reasonable minimum cell width

ngraham created this revision. ngraham added reviewers: hein, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY With the goal of making Folder View items' labels more legible, 78da28e7ab7d51e46fa267

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 55714. enriquem added a comment. Update per comments above CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=55653&id=55714 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openco

D18394: Add OTP support for openconnect VPN

enriquem added a comment. > ! In D18394#445411 , @jgrulich wrote: > All forms in the kcm use "Label: input" so I would like all the options to follow same pattern. OK. >> b) I agree on the PasswordField, although this being an OT

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. Are you +1'ing the original patch or the fact that I reverted it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: abetts, hpereiradacosta, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesl

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: abetts, hpereiradacosta, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. Reverted in c9aa535863e09bf736b1fb64c182b93530780c5d REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: hpereiradacosta, plasm

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

dvogel updated this revision to Diff 55690. dvogel marked an inline comment as done. dvogel added a comment. Reverted to the "old way" of trying ddcutil compatibility of the detected displays: by trying to read the feature setting. The `ddca_get_feature_list_by_dref` function was giving incon

D20302: Make wallpaper configuration respect global animation speed

matthieuharle added a comment. Unless I do `import QtQuick.Templates 2.3 as T` and replace `QtControls.StackView` with `T.StackView` inside the wallpaper chooser, it doesn't pick up what's inside the template. I've never used Qt Templates before, so I may be missing something. Here's wh

D20302: Make wallpaper configuration respect global animation speed

ngraham added a comment. Once the change to the QQC2 style repo has been made, then nothing should be required for the wallpaper chooser's code, right? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20302 To: matthieuharle, #plasma, mart, hein, davidedmundso

D18394: Add OTP support for openconnect VPN

jgrulich added a comment. In D18394#445224 , @enriquem wrote: > In D18394#444795 , @jgrulich wrote: > > > 1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token

D18394: Add OTP support for openconnect VPN

enriquem added inline comments. INLINE COMMENTS > jgrulich wrote in nm-openconnect-service.h:41 > Leftover from the other review? Not really. It's a feature in NetworkManager. If the functionality is not needed, it can be dropped. REPOSITORY R116 Plasma Network Management Applet REVISION DE

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 55653. enriquem added a comment. Hopefully there are no more trailing spaces. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=50749&id=55653 REVISION DETAIL https://phabricator.kde.o

D18394: Add OTP support for openconnect VPN

enriquem added a comment. In D18394#444795 , @jgrulich wrote: > 1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It

D20302: Make wallpaper configuration respect global animation speed

matthieuharle added a comment. So I made the changes in the qqc2-desktop-style repo. I'm new to arcanist and phabricator, should I make a new diff with the changes in qqc2-desktop-style and mark this one as depending on it (like said here