D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

broulik added a comment. > I'm not convinced this is needed at all. How often do you need to modify a connection? Often enough that it annoys me that I have to open the connection editor first and then search the connection *again* in the list of connections. +1 for the change. INLINE

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

jgrulich added a comment. I'm not convinced this is needed at all. How often do you need to modify a connection? I also don't think many people would discover this feature, because many of them also didn't discover context menu in KCM. REPOSITORY R116 Plasma Network Management Applet REVI

D18508: Somewhat guard failing to load backend

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BackendManager::loadBackendPlugin can return a nullptr. We currently use th

D18441: [Desktop theme KCM] Use new icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cbe86e622f60: [Desktop theme KCM] Use new icon (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18441?vs=50031&id=50210 REVISION DETAIL

D17706: Fix lock screen focus

ngraham added a comment. @andreyby, can you adjust this patch to address @davidedmundson and @graesslin's concerns? REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. I think a context menu is fine here, since it's not replacing anything else. We can examine the non-right-click presentation later. It might be nice to have a Configure button/icon show up on hover just like the disconnect one does. That's what Kirigami lists do. RE

D18318: Prettify and search enable the error page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 👍 Shipit! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18318 To: leinir, apol, ngraham, #discover_software_store Cc: plasma-devel, jraleigh, b

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#399356 , @abetts wrote: > Do you prefer a right click over a settings or 3-dot button? There's already very little space - I personally think it would become cluttered. An alternative might be a link whe

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

abetts added a comment. Do you prefer a right click over a settings or 3-dot button? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#399351 , @GB_2 wrote: > Next time please upload images directly to Phabricator. 👍 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg C

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

GB_2 added a comment. Thanks! Looks good! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

GB_2 added a comment. Next time please upload images directly to Phabricator. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY Screenshot: https://imgur.com/MvnFdbW REPOSITORY R116 Plasma Network Management Applet BRANCH vpilo/contextMenu REVISION DETAIL

D12278: [Colors KCM] Port to new design

abetts added a comment. It's amazing to see all the work that was done here. Thanks everyone for working together on this. I hope our users see this new KCM as a step forward. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg, d

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 63 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/63/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 24 Jan 2019 16:51:47 + Build duration: 19 min and counting JUnit Tests Name: projectroot Failed:

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/60/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 24 Jan 2019 16:28:57 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT [...truncated 277

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 62 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/62/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 24 Jan 2019 16:38:52 + Build duration: 2 min 11 sec and counting CONSOLE OUTPUT [...truncated 275

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/61/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 24 Jan 2019 16:33:15 + Build duration: 2 min 20 sec and counting CONSOLE OUTPUT [...truncated 275

D15304: [KCM] Port to QQC2

ngraham added a comment. @drosca, wanna do a final check to make sure you're good with everything? REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham, #plasma, drosca Cc: huftis, nicolasfella, davidedmundson

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel updated this revision to Diff 50196. thsurrel added a comment. Let's be as smart as Firefox! Thanks for the review REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18438?vs=50024&id=50196 BRANCH arc_taskmanagerclose (branched from master)

D18491: [KCM] Use a better icon

This revision was automatically updated to reflect the committed changes. Closed by commit R133:663debb66eca: [KCM] Use a better icon (authored by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18491?vs=50162&id=50195 REVISION DETAIL https:/

D18498: [Desktop Theme KCM] Support installing from remote locations

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Given how much is copy pasta, is there anything that can be made into a lib / put in kpackagetool? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kd

D18498: [Desktop Theme KCM] Support installing from remote locations

This revision was automatically updated to reflect the committed changes. Closed by commit R119:12f4d353f680: [Desktop Theme KCM] Support installing from remote locations (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18498?vs=501

D18498: [Desktop Theme KCM] Support installing from remote locations

broulik added a comment. The other KCMs don't use kpackagetool, so not sure how much sense it makes to add this to kpackagetool. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18498 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, jrale

D18498: [Desktop Theme KCM] Support installing from remote locations

broulik updated this revision to Diff 50187. broulik added a comment. Fix copy paste error REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18498?vs=50186&id=50187 REVISION DETAIL https://phabricator.kde.org/D18498 AFFECTED FILES kcms/desktopthem

D18498: [Desktop Theme KCM] Support installing from remote locations

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Uses KIO to copy the file into temp folder for installation. The same as the other KCMs do. TES

D18497: Disable KCMs while downloading file

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When dropping or choosing a remote file, it is downloaded to a temporary location for installatio

D12278: [Colors KCM] Port to new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b52c0cebfb98: [Colors KCM] Port to new design (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12278?vs=50181&id=50182 REVISION DETAIL

Plasma 5.16 Release Notes

We always have a bit of an issue when it comes to a release and no-one can remember what they did 3 months ago. In an attempt to address this I have started the release notes gathering page for 5.16 already as suggested last kickoff meeting. This is at https://notes.kde.org/p/plasma_5_16 When com

D12278: [Colors KCM] Port to new design

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please add to https://notes.kde.org/p/plasma_5_16 before shipping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma

D12278: [Colors KCM] Port to new design

broulik updated this revision to Diff 50181. broulik edited the test plan for this revision. broulik added a comment. - Cleanup a bit - Disable KCM while a file is being downloaded - Fix modal stuff for scheme editor REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://pha

D18438: [Task Manager] When closing apps, resize only when mouse is out.

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I like the idea. The Firefox implementation is smart enough not to do it when a tab is closed by means other than direct user mouse interaction though. REPOSITORY R119 Plasma Desktop BRANCH

D12278: [Colors KCM] Port to new design

davidedmundson added inline comments. INLINE COMMENTS > colors.cpp:228 > + > +void KCMColors::installSchemeFromFile(const QUrl &url) > +{ what would happen if this is called twice before the file_copy completes? > main.qml:71 > + > +view.remove: Transition { > +ParallelAnimation {

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d16583e479b: Useful error output when shell loading is aborted due to kactivitymanagerd not… (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. In D18078#398934 , @davidedmundson wrote: > (Though I can't find it here https://spdx.org/licenses/ does it have another name?) Probably not. I can't find any sort of formal licence text for the Pexels and Unspl

D18182: Fix new file creation leading to dupe items on a fresh view

davidedmundson added inline comments. INLINE COMMENTS > foldermodel.cpp:170 > connect(this, &QAbstractItemModel::rowsInserted, > this, [this](const QModelIndex &parent, int first, int last) { > for (int i = first; i <= last; ++i) { I'm a bit worried about queuing somet

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi accepted this revision. ossi added a comment. This revision is now accepted and ready to land. note that for extra correctness it should be "ancestor" not "parent". REPOSITORY R871 DrKonqi BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_works

D12278: [Colors KCM] Port to new design

broulik updated this revision to Diff 50175. broulik added a comment. Unify with the other KCMs: - Honor KIOSK ghns restriction (should this also count for the "Upload Scheme" button"?) - Double click delegate to apply instantly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDA

D12278: [Colors KCM] Port to new design

broulik updated this revision to Diff 50172. broulik added a comment. - Support installing files from remote locations through KIO like in the other KCMs, downloads to temp folder and then installs it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D17784: Don't ignore default virtual devices

This revision was automatically updated to reflect the committed changes. Closed by commit R115:5dc7cca58a72: Don't ignore default virtual devices (authored by sharhalakis, committed by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 50168. leinir added a comment. Hmm... yes, it does seem just perhaps a little more, hmm, pleasing i guess, for lack of a more technical way to say "it looks nice" ;) and most of the time that string will be a little bit shorter than it is, so... yup, updat

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. Grassland ftw! I'll let the licensing people know what's up and hopefully they'll tell us what's what. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, abetts, mart, ro

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

bshah accepted this revision. bshah added a comment. Yeah so since end result is same, +1 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18493 To: hein, #plasma, bshah, broulik Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zren

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

hein added a comment. Sorry @bhushan, I wrote my comment in response to Kai before yours but forgot to submit. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18493 To: hein, #plasma, bshah, broulik Cc: broulik, plasma-devel, jraleigh, GB_2

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

hein added inline comments. INLINE COMMENTS > bshah wrote in shellcorona.cpp:319 > On 2nd thought > > qFatal is probably wrong, it is entirely possible that service is starting up > and ::status is different then running, we might end up hitting needless > abort? Came to the same conclusion a

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

bshah added inline comments. INLINE COMMENTS > shellcorona.cpp:319 > > connect(m_activityController, > &KActivities::Controller::serviceStatusChanged, this, &ShellCorona::load, > Qt::UniqueConnection); > On 2nd thought qFatal is probably wrong, it is entirely possible that service is

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

hein updated this revision to Diff 50167. hein added a comment. Switch to `qWarning()`. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18493?vs=50166&id=50167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18493 AFFECTED FILES

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

broulik added inline comments. INLINE COMMENTS > shellcorona.cpp:649 > +qFatal("Aborting shell load: The activity manager daemon > (kactivitymanagerd) is not running."); > +qFatal("If this Plasma has been installed into a custom prefix, > verify that its D-Bus services dir is kn

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

bshah accepted this revision as: bshah. bshah added a comment. This revision is now accepted and ready to land. LGTM. Best wait for others to chime-in also though :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18493 To: hein, #plasma, bs

D18182: Fix new file creation leading to dupe items on a fresh view

hein added a comment. The QueuedConnection is fine, though. Why remove it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18182 To: hein, #plasma, McPain Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable

hein created this revision. hein added reviewers: Plasma, bshah. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Ran into this gotcha the other day, and it was impossible to resolve without code debugging. REPOSITORY R120 Plasma Workspace BRANCH m