bshah added inline comments.

INLINE COMMENTS

> shellcorona.cpp:319
>  
>      connect(m_activityController, 
> &KActivities::Controller::serviceStatusChanged, this, &ShellCorona::load, 
> Qt::UniqueConnection);
>  

On 2nd thought

qFatal is probably wrong, it is entirely possible that service is starting up 
and ::status is different then running, we might end up hitting needless abort?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18493

To: hein, #plasma, bshah, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to