hein added inline comments. INLINE COMMENTS
> bshah wrote in shellcorona.cpp:319 > On 2nd thought > > qFatal is probably wrong, it is entirely possible that service is starting up > and ::status is different then running, we might end up hitting needless > abort? Came to the same conclusion and switched to `qWarning()` already as per above. > broulik wrote in shellcorona.cpp:649 > `qFatal` calls `abort` so the second one can not be reached, can it? Perhaps > just `\n` The more I think about it, I think `qFatal()` might be wrong anyway. It changes behavior of the program, since in theory `load()` could be re-entered at a later time when kactivitymanagerd has since come up. I'll go with `qWarning`. Will update this diff. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18493 To: hein, #plasma, bshah, broulik Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
