D17751: Add shadow to Hour's hand

shubham added a comment. ngraham I will put those changes in effect REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17751 To: shubham, mart, hein, #vdg, ngraham Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D17751: Add shadow to Hour's hand

ngraham added a comment. The SVG did actually need some tweaking. I've done that at D18288 . After that, I found that setting the hour hand shadow's `topMargin` to -6 and changing the second hand's `topMargin` to 2 looked great: F6551260: Screensh

D18287: Remove hardcoded /usr/share paths in install

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We can't assume where breeze color files are installed. If this was a us

D18286: Export path of installed color-schemes in BreezeConfig cmake

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Used by breeze-gtk REPOSITORY R31 Breeze BRANCH master REVISION DETAIL http

D18285: Fake mousehover whilst combobox is open

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Under QWidgets the combobox menu steals the mouse focus, including under wayland. Because of this the root control r

D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY See the end of QComboBox::initStyleOption if (d->container && d->container->isVisible()) option->state

D18189: Fix ComboBox

davidedmundson added a comment. I'm finding issues with combobox and this patch. Using the test supplied I can't select other items. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, pl

D18255: Improve up/down display for Monitor widgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:64045dbddc14: Improve up/down display for Monitor widgets (authored by ngraham). REPOSITORY R120 Plasma Workspace C

D18255: Improve up/down display for Monitor widgets

ngraham added a comment. Landing based on @davidedmundson's "ship it" for what's left (I think he's asleep right now and I'd like to get this in before we branch). Will submit further patches for other changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49582. ngraham added a comment. Revert unit formatting changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49554&id=49582 BRANCH improve-network-monitor-display (branched from master) REVISION D

D18255: Improve up/down display for Monitor widgets

davidedmundson added a comment. > I grabbed this code from plasma-nm, which does the same thing. Ok, cool. Ship that part. --- As for the other change. Right now it's in JDEC - you're porting to IEC. Both are valid. SI would be wrong, but that would be k not K. -

D18276: Fix KDE Connect volume control

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Related patch to plasma-pa D16443 REPOSITORY R994 Pulseaudio Qt Bindings BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18276 T

D18276: Fix KDE Connect volume control

nicolasfella updated this revision to Diff 49563. nicolasfella added a comment. Thanks! REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18276?vs=49558&id=49563 BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18276 AFFECT

D18255: Improve up/down display for Monitor widgets

ngraham added a comment. Seems like the original change to use bits (D4551 ) was not super popular and generated bug reports (https://bugs.kde.org/show_bug.cgi?id=383019). If/when this lands, I'll look into making the unit configurable, since I can see the

D18276: Fix KDE Connect volume control

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. I think it would be better to edit the check only to `contains("Glib")` as it still makes sense to check for GLib event loop, as otherwise the code will just silently fail. I

D18276: Fix KDE Connect volume control

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18276 AFFECTED FILES src/co

D18275: Remove CPOYING

nicolasfella updated this revision to Diff 49557. nicolasfella added a comment. Fix diff REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18275?vs=49556&id=49557 BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18275 AFFEC

D18275: Remove CPOYING

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Fix KDE Connect volume control REPOSITORY R994 Pulseaudio Qt Bindings BRANCH noglibcheck REVISION DETAIL https://

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49554. ngraham added a comment. B -> b (B is bytes, and this measures bits) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49553&id=49554 BRANCH improve-network-monitor-display (branched from master

D18255: Improve up/down display for Monitor widgets

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18255 To: ngraham, #plasma, #vdg Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49553. ngraham added a comment. It's actually measuring bits REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49552&id=49553 BRANCH improve-network-monitor-display (branched from master) REVISION DET

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49552. ngraham added a comment. Use the correct units (e.g. kibibytes instead of kilobytes) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49492&id=49552 BRANCH improve-network-monitor-display (bran

5.15 errata

If you're aware of any notable bugs or regressions in 5.15 please note it on the errata page https://community.kde.org/Plasma/5.15_Errata Jonathan

D18269: Improve the Splash Screen KCM

GB_2 added a comment. In D18269#393711 , @ngraham wrote: > In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch. Ok, sorry. REPOSITORY R119 Plasma

D18269: Improve the Splash Screen KCM

ngraham added a comment. In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18269 To: GB_2, #plasma, #vdg, davidedmundso

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. Actually, by using `KCrash::setFlags(KCrash::KeepFDs)` in KDevelop, so preventing the closing of all FDs, the problem is fixed(?) as well. But I think, that the situation should not appear, even for a "misconfigured" debuggee. REPOSITORY R871 DrKonqi REVISION DET

D18269: Improve the Splash Screen KCM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd94db08a555: Improve the Splash Screen KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST U

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. **GDB** Actually the problem is about joining threads at the end of `main()`. After being stuck and `kill -SIGSTOP $(pidof kdevelop)`, DrKonqi turns out to be here: #0 0x7fbf18adbf6d in __pthread_timedjoin_ex () from /usr/lib/libpthread.so.0 #1 0x000

D18269: Improve the Splash Screen KCM

GB_2 updated this revision to Diff 49544. GB_2 added a comment. Use old icon `preferences-system-splash` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18269?vs=49541&id=49544 BRANCH improve-splashscreen-kcm (branched from master) REVISION DETAIL

D18269: Improve the Splash Screen KCM

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm_splashscreen.desktop:2 > > so it wouldn't get done in time for the Plasma 5.15 release... > > It would be a runtime change, so if you got it in next frameworks it'd fix > itself midway through Plasma 5.15 beta. > > No

D18269: Improve the Splash Screen KCM

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GB_2 wrote in kcm_splashscreen.desktop:2 > Yes, I just used it because I think it should be included in Plasma 5.15 and > it is the closest to

D18269: Improve the Splash Screen KCM

GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in kcm_splashscreen.desktop:2 > Yes, I just used it because I think it should be included in Plasma 5.15 and > it is the closest to a login splash icon I could find. BTW, the Plymouth Splash KCM just uses an empty screen icon. REPOSITORY

D18269: Improve the Splash Screen KCM

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm_splashscreen.desktop:2 > I know you're making this change because we don't actually have a > `preferences-system-splash` icon, but is this really semantically correct? It > seems like we should actually create that icon, or mayb

D18269: Improve the Splash Screen KCM

ngraham added inline comments. INLINE COMMENTS > kcm_splashscreen.desktop:2 > [Desktop Entry] > -Icon=preferences-system-splash > +Icon=preferences-system-login > Exec=kcmshell5 kcm_splashscreen I know you're making this change because we don't actually have a `preferences-system-splash` icon

D18269: Improve the Splash Screen KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Splash Screen KCM has some inconsistencie

D18267: Improve the Cursor Theme KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0a4d3fa415d: Improve the Cursor Theme KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18267?vs=49536&id=49540 REVISION DETAIL http

D18267: Improve the Cursor Theme KCM

GB_2 added a comment. In D18267#393635 , @ngraham wrote: > In D18267#393620 , @davidedmundson wrote: > > > > In the tooltip and header on the page > > > > > > > > > In the description of the

D18267: Improve the Cursor Theme KCM

ngraham added a comment. In D18267#393620 , @davidedmundson wrote: > > In the tooltip and header on the page > > > > > In the description of the KCM when you hover over it. > > Both those are taken from kcm_cursortheme.desktop surely.

D18267: Improve the Cursor Theme KCM

davidedmundson added a comment. > In the tooltip and header on the page > In the description of the KCM when you hover over it. Both those are taken from kcm_cursortheme.desktop surely. REPOSITORY R119 Plasma Desktop BRANCH improve-cursortheme-kcm (branched from master) R

D18267: Improve the Cursor Theme KCM

GB_2 added a comment. In D18267#393604 , @davidedmundson wrote: > Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so) Ok, there is one more patch that I will make with this name

D18267: Improve the Cursor Theme KCM

ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > davidedmundson wrote in metadata.desktop:63 > Where is this string visible? In the tooltip and header on the page. Or at least, this should be consistent with the `C

D18267: Improve the Cursor Theme KCM

davidedmundson added a comment. Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so) INLINE COMMENTS > metadata.desktop:63 > Name[zh_TW]=游標主題 > -Comment=Mouse Cursor Theme > +Comment=Choose the mouse cursor theme > Comment[ar]=سمة م

D18267: Improve the Cursor Theme KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The Cursor Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it a

D18032: Fix USB view

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e556c25c888a: Fix USB view (authored by alexandref, committed by davidedmundson). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18032?vs=49494&id=49529 REVISI

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added inline comments. INLINE COMMENTS > fvogt wrote in foldermodel.cpp:154 > It doesn't use Qt::QueuedConnection explicitly - is the comment wrong or is > it done implicitly? According to e94888701 and cc9c3d3

D18244: Check for python-cairo

davidedmundson updated this revision to Diff 49525. davidedmundson added a comment. update REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18244?vs=49448&id=49525 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 AFFECTED FILES

D18262: Ensure only one allInitialised emission

This revision was automatically updated to reflect the committed changes. Closed by commit R134:88e315953fc0: Ensure only one allInitialised emission (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18262?vs=49523&id=49524

D18262: Ensure only one allInitialised emission

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY To ensure we only hav

D18260: fix logic of lnf loading

This revision was automatically updated to reflect the committed changes. Closed by commit R135:2682db8af734: fix logic of lnf loading (authored by mart). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18260?vs=49515&id=49521

D18260: fix logic of lnf loading

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY mDefaultLnfConfig must be breeze, and mLnfConfig should be the configured one, rather the other way aroun

D18246: Fix premature firing of allInitialized signal

This revision was automatically updated to reflect the committed changes. Closed by commit R134:798514c11668: Fix premature firing of allInitialized signal (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18246?vs=49451&id=4

D18182: Fix new file creation leading to dupe items on a fresh view

hein requested review of this revision. hein added a comment. Requesting re-review due to significant behavior changes following @fvogt's comment REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18182 To: hein, #plasma, McPain Cc: fvogt, plasma-devel, jraleigh

D18182: Fix new file creation leading to dupe items on a fresh view

hein updated this revision to Diff 49500. hein added a comment. Fix comments and make code reflect comment intent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18182?vs=49234&id=49500 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.

D18246: Fix premature firing of allInitialized signal

leinir added a comment. In D18246#393094 , @ngraham wrote: > Nice catch. Looks like this might fix 401334? i think that is precisely what's going on there, yes - the symptoms certainly match :) REPOSITORY R134 Discover Software Store

D18182: Fix new file creation leading to dupe items on a fresh view

fvogt added inline comments. INLINE COMMENTS > foldermodel.cpp:152 > > /* > * position dropped items at the desired target position The comment refers to the first connect now, but is mostly aimed at the second. Maybe move it and add another one for the added connect call? > folde