davidedmundson added a comment.

  > I grabbed this code from plasma-nm, which does the same thing.
  
  Ok, cool. Ship that part.
  
  ---
  
  As for the other change. Right now it's in JDEC - you're porting to IEC. Both 
are valid.
  SI would be wrong, but that would be k not K.
  
  -----
  
  If you are going to add an option lets do it properly via  a formatSpeed in 
KCoreAddons::KFormat method.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18255

To: ngraham, #plasma, #vdg
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Reply via email to