drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  I think it would be better to edit the check only to `contains("Glib")` as it 
still makes sense to check for GLib event loop, as otherwise the code will just 
silently fail.
  
  In older Qt versions, QAbstractEventDispatcher::instance() was 
QEventDispatcherGlib, it is now (at least on xcb platform) 
QXcbGlibEventDispatcher.

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D18276

To: nicolasfella, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to