D15011: [Kickoff] Make the search field always look like a search field

2018-08-22 Thread Andres Betts
abetts added a comment. I like this idea REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D15011: [Kickoff] Make the search field always look like a search field

2018-08-22 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Heh, flip-flopped back to https://userbase.kde.org/images.userbase/thumb/f/fe/Kickoff_Menu_Style.png/300px-Kickoff_Menu_Style.png till we get the next bug report a

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

2018-08-22 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R169:b23e642e5ac4: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled (authored by mpyne). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14984?vs=4

D15011: [Kickoff] Make the search field always look like a search field

2018-08-22 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes Kickoff's search field always look like a search field, instead of on;y afte

D15008: Don't depend on the exact version of Breeze

2018-08-22 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R135:893175d8c38b: Don't depend on the exact version of Breeze (authored by fvogt). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1500

D15008: Don't depend on the exact version of Breeze

2018-08-22 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY This makes it easier to build on dev systems and for backports. TEST PLAN Built master with Breeze 5.13.4 installed - works fine. REPOSITORY

D14830: Add "Configure Displays" context menu entry on the desktop

2018-08-22 Thread Nathaniel Graham
ngraham added a comment. In D14830#313645 , @davidedmundson wrote: > I am still waiting for a single justification. I think some were provided in the description: > One of LiMux client's requirements is for display configuration to b

D14830: Add "Configure Displays" context menu entry on the desktop

2018-08-22 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I am still waiting for a single justification. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14830 To: broulik, #plasma, #vdg,

D14830: Add "Configure Displays" context menu entry on the desktop

2018-08-22 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14830 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: mart, davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14855: Add applet with screen layouts and presentation mode

2018-08-22 Thread Andres Betts
abetts added a comment. Love! Love! <3 Thanks for working on it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, le

D14855: Add applet with screen layouts and presentation mode

2018-08-22 Thread Nathaniel Graham
ngraham added a comment. +1 on the UI now. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jens

D14855: Add applet with screen layouts and presentation mode

2018-08-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 40245. broulik edited the test plan for this revision. broulik added a comment. - Fixup wording - Improve layout of Presentation Mode checkbox REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14855?vs=40088&id=40245 RE

KDE CI: Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10 - Build # 14 - Failure!

2018-08-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20stable-kf5-qt5%20FreeBSDQt5.10/14/ Project: Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 22 Aug 2018 14:38:13 + Build duration: 26 sec and counting

D14950: Add screen to the keyword of kscreen KCM

2018-08-22 Thread Vlad Zagorodniy
zzag added a comment. Why only "refresh"? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14950 To: davidedmundson, #plasma, ngraham, gladhorn Cc: gladhorn, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ma

D14950: Add screen to the keyword of kscreen KCM

2018-08-22 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R104:24f041478771: Add screen to the keyword of kscreen KCM (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14950?vs=40066&id=40229 REVISIO

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-22 Thread Stefan BrĂ¼ns
bruns requested review of this revision. bruns added a comment. Why should I squash the commits? Each one: - compiles **and** works on its own - addresses a slightly different issue Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets > OTOH,

D14822: Use QJSValue as method parameter type for the scripting interface

2018-08-22 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6e5c9e9b1666: Use QJSValue as method parameter type for the scripting interface (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14822?v

D14822: Use QJSValue as method parameter type for the scripting interface

2018-08-22 Thread Fabian Vogt
fvogt added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14822 To: fvogt, #plasma Cc: mart, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14999: [PanelShadows] Use 0 offset for disabled borders on Wayland

2018-08-22 Thread Vlad Zagorodniy
zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY On Wayland, if some border is disabled, we don't attach corresponding empty tile. Yet, we set offset of 1 for that border. KWin rel

D14976: Less aggessive monochroming of icons

2018-08-22 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:e8a611b3eaf5: Less aggessive monochroming of icons (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST

D14976: Less aggessive monochroming of icons

2018-08-22 Thread Volker Krause
vkrause added a comment. Thanks! This looks like it should fix my problem with the breeze weather icons on Android :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14976 To: mart, #kirigami, vkrause Cc: plasma-devel, apol, davidedmundson, mart, hein

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Kai Uwe Broulik
broulik added a comment. You would need to read `kwinrc` manually, I suppose. I don't use virtual desktops, so I cannot comment, but I don't think three separate options is worthwhile. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #pla

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Phuong Nguyen
phuongn added a comment. I couldn't find an easy way to access KWindowSystem config from there. On the other hand, I personally prefer wrapping when using keyboard shortcut and no wrapping when using mouse or touchpad gesture. I figured some people might need the same flexibility. REPOSITO

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Kai Uwe Broulik
broulik added a comment. Shouldn't this just follow KWin's "screens wrap around" policy? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

2018-08-22 Thread Phuong Nguyen
phuongn created this revision. phuongn added a reviewer: Plasma. phuongn added a project: Plasma. Herald added a subscriber: plasma-devel. phuongn requested review of this revision. REVISION SUMMARY BUG: 361672 This patch implement an option to disable navigation wraps around for the switc

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Phuong Nguyen
phuongn created this revision. phuongn added a project: Plasma. Herald added a subscriber: plasma-devel. phuongn requested review of this revision. REVISION SUMMARY BUG: 361672 This patch implement an option to disable navigation wraps around for the pager plasmoid, which potentially cause