davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
Heh, flip-flopped back to https://userbase.kde.org/images.userbase/thumb/f/fe/Kickoff_Menu_Style.png/300px-Kickoff_Menu_Style.png till we get the next bug report about how it should be hidden. INLINE COMMENTS > Header.qml:66 > + opacity: 0 > + y: -1 > + } What's this about? Negative offsets are weird, and we also have a 300ms animation to move 1px? > Header.qml:144 > left: faceIcon.right > - top: faceIcon.top > - right: parent.right > + bottom: queryField.top > leftMargin: units.gridUnit and here > Header.qml:153 > + level: 5 > + font.letterSpacing: -0.4 > + opacity: 0 We can't do this. You're assuming lots of things about the user's font that you can't do. > Header.qml:164 > anchors { > - left: nameLabel.left > - top: nameLabel.bottom > - right: nameLabel.right > + left: faceIcon.right > + bottom: queryField.top This will no longer elide as the right is not constrained. If you have a long username this will just overflow out the box. When dealing with text items, it's easier to think in terms of bounding box rather than where the text itself. Include the rightMargin back too. > Header.qml:211 > + // Implement our own clear button because the PC3 version doesn't > have one > + // (https://bugs.kde.org/show_bug.cgi?id=396828) > + // FIXME: Replace this Row and everything in it with > "clearButtonShown: true" No working round Plasma code in Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson Cc: davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
