bruns requested review of this revision.
bruns added a comment.

  Why should I squash the commits? Each one:
  
  - compiles **and** works on its own
  - addresses a slightly different issue
  
  Citing from 
https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets
  
  > OTOH, commits should be preferably "atomic" - not splittable. That means 
that every bugfix, feature, refactoring or reformatting should go into an own 
commit. This, too, improves the readability of the history.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

Reply via email to