D14238: Polish Notifier Plasmoid's UI

apol added a comment. In D14238#295251 , @fabianr wrote: > Maybe add a second button "Update" that does update right away without viewing the available update list? Most users probably won't be interested in which packages are updated, but just

D14256: Fix sidebar search field with fractional scale factors

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY By using a QQC2 TextField, we improve the appearance when using a

D12946: Single/Double Click Option at Workspace KCM

rooty added a comment. hey guys, resident grammar nazi reporting :D it says Click Behaviour (british spelling), and the rest of the module uses Behavior (american spelling) a great idea otherwise sorry :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 added a comment. Hey Aleix, I have fixed things, I am reviewing whole code once again, I will upload the new diff by tomorrow morning. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14050 To: abhijeet2096, apol, davidedmundson Cc: zzag,

D14050: Fwupd Backend For Review and Improvement

apol added a comment. Ping? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14050 To: abhijeet2096, apol, davidedmundson Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D14250: Sort update items by completion

apol created this revision. apol added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Sort update items by completion. BUG: 390911 TEST PLAN Tested loca

D13937: Update formulas and add option to change grid thickness

piotrkakol added a comment. Thanks for the link! I'll check it out probably tomorrow and will make new diff(s). :-) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13937 To: piotrkakol, #plasma Cc: gladhorn, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D13937: Update formulas and add option to change grid thickness

ngraham added a comment. With Phabricator, patches can have parents, and multi-commit dependency chains are fully supported: https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project I agree that this particular workflow is a bit more cumbersome tha

D13937: Update formulas and add option to change grid thickness

piotrkakol added a comment. Wow, this is nice :) I wonder if it could be broken into smaller pieces though, this is quite a big change and thus hard to review. For example if the renaming from "dot" to "square" was independent of the rest, that would make it easier. Was it developed as indiv

D14238: Polish Notifier Plasmoid's UI

ngraham marked 3 inline comments as done. ngraham added a comment. @broulik addressed your remaining comments in another commit. Sorry for missing them the first time around; flaky bus wifi didn't show me the email for your comments until after I had already landed the patch, following Aleix'

D14145: Show a vertical menu for the panel widget options pop-up

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9adb94dc5b83: Show a vertical menu for the panel widget options pop-up (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14145?vs=38095&i

D14238: Polish Notifier Plasmoid's UI

This revision was automatically updated to reflect the committed changes. Closed by commit R134:ee062be1ca0e: Polish Notifier Plasmoid's UI (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14238?vs=38136&id=38137 REVISION

D14238: Polish Notifier Plasmoid's UI

ngraham added a comment. I'd thought of that idea too, but it requires more substantial changes than just playing around with the UI, so it'll have to be done in another patch. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14238 To: ngraham, apol,

D14238: Polish Notifier Plasmoid's UI

broulik added inline comments. INLINE COMMENTS > Full.qml:29 > PlasmaExtras.Heading { > -Layout.fillWidth: true > +anchors.top: parent.top > +width: parent.width That's the default anyway > Full.qml:37 > +ColumnLayout { > +anchors.horizontalCenter: paren

D14238: Polish Notifier Plasmoid's UI

fabianr added a comment. Maybe add a second button "Update" that does update right away without viewing the available update list? Most users probably won't be interested in which packages are updated, but just want to stay up to date? REPOSITORY R134 Discover Software Store REVISION DETA

D14238: Polish Notifier Plasmoid's UI

ngraham added a comment. In D14238#295135 , @esedgh wrote: > Just a quick question. Why does it have to be so big and waste so much space? It still feels kind of weird. > > Thank you Nate, btw. You are doing amazing work everywhere. T

D14238: Polish Notifier Plasmoid's UI

ngraham updated this revision to Diff 38136. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14238?vs=38107&id=38136 BRANCH polish-notifier-plasmoid

D14247: Hide view selection if there is only one plugin to choose

This revision was automatically updated to reflect the committed changes. Closed by commit R124:86f0f92caf0f: Hide view selection if there is only one plugin to choose (authored by broulik). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14247?vs=38133

D14247: Hide view selection if there is only one plugin to choose

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Made sense before, but I don't know how you could be in a situation where you don't have sidebar and classic compiled in... REPOSITORY R124 System Settings REVISION DETAI

D14247: Hide view selection if there is only one plugin to choose

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 374865 FIXED-IN: 5.12.7 REPOSITORY R124 S

[kscreenlocker] [Bug 374300] All UI elements should respect active color theme

https://bugs.kde.org/show_bug.cgi?id=374300 David Edmundson changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

D14245: Use '-P' option to properly adjust color temperature in manual mode

andrewc created this revision. andrewc added a reviewer: martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. andrewc requested review of this revision. REVISION SUMMARY Redshift version 1.12 introduced the '-P' option to clear

D14234: [Folder View] Improve file name text rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5fca2b32ce5b: [Folder View] Improve file name text rendering (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14234?vs=38097&id=38125#toc REPOSITORY R119 Plasma Desktop

D14243: Fix bad model hygiene in Positioner::move()

hein created this revision. hein added a reviewer: davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Don't change the proxy maps prior to insert/remove transactions so rowCount() at transaction start time matches the count

D14238: Polish Notifier Plasmoid's UI

esedgh added a comment. Just a quick question. Why does it have to be so big and waste so much space? It still feels kind of weird. Thank you Nate, btw. You are doing amazing work everywhere. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14238

D13937: Update formulas and add option to change grid thickness

gladhorn added a comment. Wow, this is nice :) I wonder if it could be broken into smaller pieces though, this is quite a big change and thus hard to review. For example if the renaming from "dot" to "square" was independent of the rest, that would make it easier. Was it developed as individ

D14226: Let download update timer only run when there's running downloads

gladhorn added a comment. Seems sensible to me. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D14226 To: broulik, #plasma, davidedmundson, fvogt Cc: gladhorn, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14234: [Folder View] Improve file name text rendering

hein added a comment. It kind of sucks we have to do this, we have a lot of different UIs we'd have to copy-paste this fix too, but after a few minutes of mulling I didn't come up with a better idea :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14234 To

D14224: Make kcm size hint bigger

gladhorn added a comment. I was in general wondering if the KCMs can give sensible size hints somehow. I guess it should be calculated, for me it looks quite different, but scaling and font size play a role. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14224 To:

D14143: Make the action selector OSD independent of the other OSDs

gladhorn added a comment. I'd like to get this in since the meaningful changes (keyboard handling) are based on this :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14143 To: gladhorn, #plasma, davidedmundson Cc: broulik, davidedmundson, zzag, plasma-devel, ragre

D14143: Make the action selector OSD independent of the other OSDs

gladhorn updated this revision to Diff 38117. gladhorn added a comment. Use QmlObjectSharedEngine REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14143?vs=38029&id=38117 BRANCH arcpatch-D14143_1 REVISION DETAIL https://phabricator.kde.org/D14143 AFFEC

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 38113. hein added a comment. Code cleanup in MouseHandler REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13746?vs=37208&id=38113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13746 AFFECTED FILES

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 38112. hein added a comment. Various window DND Fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13748?vs=37207&id=38112 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13748 AFFECTED FILES a

D13745: Implement support for virtual desktops on Wayland

hein updated this revision to Diff 38111. hein added a comment. Fixes for DND support code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=37527&id=38111 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13745 AFFECTED FILES