hein created this revision. hein added a reviewer: davidedmundson. Restricted Application added a project: Plasma. hein requested review of this revision.
REVISION SUMMARY Don't change the proxy maps prior to insert/remove transactions so rowCount() at transaction start time matches the count passed into the method. The old code hits an ASSERT in Qt 5.11 otherwise. Care is taken not to emit dataChanged() in the middle of another transaction. Also cleaned up vestiges of caching lastRow(): This cache was evicted all over the places but never actually filled anymore, so maybe we don't need it. BUG:396666 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D14243 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp containments/desktop/plugins/folder/positioner.h To: hein, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
