D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > CMakeLists.txt:46 > + > +if(USE_GCONF AND USE_GSETTINGS) > +message(FATAL_ERROR "USE_GCONF and USE_GSETTINGS cannot be used at the > same time") This should probably use cache variables: set(USE_GCONF FALSE CACHE STRING "Build with GConf")

D14143: Make the action selector OSD independent of the other OSDs

gladhorn updated this revision to Diff 37923. gladhorn added a comment. re-added const REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14143?vs=37850&id=37923 BRANCH arcpatch-D14143_1 REVISION DETAIL https://phabricator.kde.org/D14143 AFFECTED FILES

D14152: Remove ref from returned QString

gladhorn updated this revision to Diff 37922. gladhorn added a comment. Re-added the const REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14152?vs=37851&id=37922 BRANCH arcpatch-D14152 REVISION DETAIL https://phabricator.kde.org/D14152 AFFECTED FILES

D14167: Fix spaces in error messages

This revision was automatically updated to reflect the committed changes. Closed by commit R110:3e990216dca6: Fix spaces in error messages (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14167?vs=37901&id=37921 REVISION DETAIL

D14174: Fix blur behind folderview context menus

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. We have blurred context menus now? Wtf. But ok. REPOSITORY R119 Plasma Desktop BRANCH davidedmundson/kcm_clock_qml REVISION DETAIL https://phabricator.kde.org/D14174 To: davidedmun

D14145: Show a vertical menu for the panel widget options pop-up

ngraham updated this revision to Diff 37919. ngraham marked 3 inline comments as done. ngraham added a comment. - Address review comments - Make it a level 3 label to match other Headings used for panel adjustment - Make the buttons span the full width of the menu REPOSITORY R119 Plasma

D14165: Handle keyboard in action selector OSD

davidedmundson added inline comments. INLINE COMMENTS > gladhorn wrote in OsdSelector.qml:139 > I'd like to hear suggestions how to do this in a nicer fashion, iterating > over the children and checking if they are buttons and otherwise skipping > them feels pretty ugly. Personally I would add

D14174: Fix blur behind folderview context menus

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Breeze has if (!(widget->testAttribute(Q

Virtual Desktop and Activities future: Merging proposal

Was asked to copy and paste my comments from the main thread into a new thread. Motiviation Most people use one or the other, both offer half arsed things you expect from some kind of logical window grouping system. - Users of activities don't get hot edges / effects / whatever - Users of VDs

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37913. nicolasfella added a comment. - Remove unneeded class declaration REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37911&id=37913 BRANCH gsettings REVISION DETAIL https://phab

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37911. nicolasfella added a comment. - Fail if user sets both USE_GCONF and USE_GSETTINGS - Restore warning when module is unloaded REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37888

D14145: Show a vertical menu for the panel widget options pop-up

gregormi added a comment. +1; great to have also text on the Configure button (as a new Plasma user I thought this was just a non-clickable icon) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14145 To: ngraham, #plasma Cc: gregormi, abetts, broulik, plasma-

Re: Virtual Desktop and Activities future: Tree proposal

On Mon, Jul 16, 2018 at 8:21 PM Roman Gilg wrote: > > Example: > > User A is a project manager by trade and begins a job at a new > company. She receives a company laptop for her new job, whch she can > also use at home. Therefore on the first day she creates expclitiy two > Acti

D14147: Port from GConf to GSettings

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:54 > +set(USE_GCONF FALSE) > +endif() > Those two options (gconf, gsettings) should be mutually exclusive. > Advanced.qml:76 >

D14167: Fix spaces in error messages

gladhorn updated this revision to Diff 37901. gladhorn added a comment. Added colon REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14167?vs=37900&id=37901 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14167 AFFECTED FILES src/d

D14167: Fix spaces in error messages

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Unlike qDebug there is no automatic space added in QTextStream/stderr. REPOSITORY R110 KScreen

D14165: Handle keyboard in action selector OSD

gladhorn added inline comments. INLINE COMMENTS > OsdSelector.qml:139 > +} > +Keys.onPressed: { > +if (event.key === Qt.Key_Right || event.key === Qt.Key_Left) { I'd like to hear suggestions how to do this in a nicer fashion, iterating over the children and checking

D14166: Turn OsdManager into a regular class

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The OsdManager was trying to be a singleton while used from onl

D14165: Handle keyboard in action selector OSD

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The OSD is not all that bad, but it was only usable with the mouse. Change it so that left-right

Re: Virtual Desktop and Activities future: Partitioning proposal

On Mon, Jul 16, 2018 at 8:29 PM Vlad Zagorodniy wrote: > Slide effect assumes that virtual desktops form a grid. Will virtual desktops > form a grid with this approach? How VDs of the current Activity are presented to the user should be independent of this proposal. So KWin can decide to put them

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. You're welcome. And: thanks for the patience to help improving this patch comes also from my side :). REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, broulik, mart, hein, rkflx Cc: apol, antho

Re: Virtual Desktop and Activities future: Partitioning proposal

On Monday, July 16, 2018 9:07:40 PM EEST Roman Gilg wrote: > - > KWin/KWayland implementation: > - > General: > * Only knows about VDs. Has a list of all of them. > * Broadcasts the current VD list on change (and on bind through > client) to c

Virtual Desktop and Activities future: Tree proposal

The solution aims at providing all functionality today with Activities and VDs, but extents and generalizes the concept by looking at them as nodes of a tree structure, which can be freely traversed and manipulated by the user. Would not lead to lost functionality and would provide in theory a mas

Virtual Desktop and Activities future: Partitioning proposal

The solution aims at replicating functionality that is available today from user point of view, but tries to improve the internal structure and implementation. --- Motivation: --- The idea is to keep the two different concepts of VDs and Activities, but implement them in a more int

Re: Discussion for Virtual Desktops and Activities future

On Mon, Jul 16, 2018 at 12:44 PM David Edmundson wrote: > I'm not set in stone on that, depends a bit on getting feedback about the > explicit problems with merging. I think the problem is that not many people fully understand what your proposed solution would look like in the end. I at least do

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb updated this revision to Diff 37897. rjvbb added a comment. Using QApplication::style() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14000?vs=37568&id=37897 REVISION DETAIL https://phabricator.kde.org/D14000 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/kquickstyle

D12055: Remove border around menubars

zzag added a comment. @jackg Ping. REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze, ngraham, jackg, #vdg Cc: jackg, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D14129: Port away from string-based connects

This revision was automatically updated to reflect the committed changes. Closed by commit R858:e1ccdc1d7698: Port away from string-based connects (authored by vkrause). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14129?vs=37793&i

D14145: Show a vertical menu for the panel widget options pop-up

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14145 To: ngraham, #plasma Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14147: Port from GConf to GSettings

nicolasfella added a comment. It now defaults to GSettings of found and one can pass -DUSE_GCONF to build it using GConf REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: rikmills, broulik, asturmle

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

alexeymin added a comment. Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with t

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37888. nicolasfella added a comment. - Don't require GIO - Fix copyright REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37887&id=37888 BRANCH gsettings REVISION DETAIL https://ph

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37887. nicolasfella added a comment. - Support both GConf and GSettings REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37836&id=37887 BRANCH gsettings REVISION DETAIL https://phabr

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

davidedmundson added a comment. Please swap qApp->style for QApplication::style as it's static. Solution is quite clever. It's risky as any qstyle will always be written assuming it's a QApplication; but by definition the QQC2 code shields from a lot of the QWidget casting that would

D14112: Fix CMakeLists.txt to work with older versions of CMake

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d8ac72b45e97: Fix CMakeLists.txt to work with older versions of CMake (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14112?vs

D14147: Port from GConf to GSettings

nicolasfella added a comment. Keyword changes were made in D14107 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: rikmills, broulik, asturmlechner, plasma-devel

D14157: Add QT_NO_KEYWORDS definition

This revision was automatically updated to reflect the committed changes. Closed by commit R115:dd15322e50ee: Add QT_NO_KEYWORDS definition (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14157?vs=37864&id=37874 R

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.10 - Build # 31 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.10/31/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 9 min 26 sec and counting JUnit Tests

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.10 - Build # 29 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.10/29/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 7 min 7 sec and counting JUnit Tests Name

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.10 - Build # 32 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.10/32/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 7 min 25 sec and counting JUnit T

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.10 - Build # 32 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.10/32/ Project: Plasma kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 6 min 13 sec and counting JUnit Tests Name: (ro

D14050: Fwupd Backend For Review and Improvement

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FwupdBackend.cpp:93 > +AbstractResource* res = (AbstractResource*) r; > +if(r->m_id.isEmpty()) > +qDebug() << "Resource ID is Empty" <<

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.10 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.10/31/ Project: Plasma kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 5 min 55 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.10 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 2 min 41 sec and counting CONSOLE OUTPUT [

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.10 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.10/31/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 2 min 29 sec and counting CONSOLE

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.10 - Build # 30 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.10/30/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 2 min 31 sec and counting CONSOLE OUTPUT

D14026: [Pager] Don't show a window list on hover if there is only one window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7f729fa1268c: [Pager] Don't show a window list on hover if there is only one window (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D14150: [kdecoration] Delete unused includes

This revision was automatically updated to reflect the committed changes. Closed by commit R31:f28e591d: [kdecoration] Delete unused includes (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14150?vs=37846&id=37865 REVISION DETAIL https:

D14157: Add QT_NO_KEYWORDS definition

nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R115 Plasma A

D14156: Show "muted" icon for dummy output

broulik created this revision. broulik added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Dummy output cannot play any sound TEST PLAN Disconnecte

Re: Discussion for Virtual Desktops and Activities future

For the vast majority of users my proposal is identical to your proposal. The only real difference is in mine we explicitly say that we never assume VD ID == activity ID which can allow for most future complexity should someone want to both implement and opt into it. > (switching activities > Per

D14147: Port from GConf to GSettings

broulik added a comment. I would prefer those keyword changes to be done separately REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: broulik, asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, le

D13935: Remove audio setup from Phonon KCM

sitter added a comment. This is on my radar and looked good from a diff review. I'd like to give this a proper review though and that will take a bit as I am super swamped just now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13935 To: nicolasfella, #plas

Re: Discussion for Virtual Desktops and Activities future

On Fri, Jul 13, 2018 at 1:54 PM David Edmundson wrote: > work - 1 > work - 2 > browsing - 1 > browsing - 2 I really don't like having a different set of desktops for each activity, to me would be really confusing, and i don't think it would cover my main use case? (switching activities Perhaps i

Re: Discussion for Virtual Desktops and Activities future

On Sun, Jul 15, 2018 at 3:57 PM Martin Flöser wrote: > Activities are weird and we (Thomas and I) never knew what they are and > how we should integrate them in KWin. The existing code is just a bad > copy of virtual desktops (bad because it copied the code 1:1 without > understanding what it does

Re: Discussion for Virtual Desktops and Activities future

On Fri, Jul 13, 2018 at 6:20 PM David Edmundson wrote: > - effects show more options > - pager will show more options > - set on activity desktop menu will show more options > (not really a huge issue. Just don't change activities if you don't want to > change activities) To me that's exactly

D14145: Show a vertical menu for the panel widget options pop-up

broulik added a comment. +1000 this flyout has annoyed me forever INLINE COMMENTS > ConfigOverlay.qml:366 > > -LayoutMirroring.enabled: Qt.application.layoutDirection === > Qt.RightToLeft > -LayoutMirroring.childrenInherit: true > - > -Row { > -

D14152: Remove ref from returned QString

zzag added inline comments. INLINE COMMENTS > osd.cpp:58 > > -const QString &osdPath = > QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation, > QStringLiteral("kded_kscreen/qml/Osd.qml")); > +QString osdPath = > QStandardPaths::locate(QStandardPaths::QStandardP

D14152: Remove ref from returned QString

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Let's leave it up to the compiler to eliminate the ref. Sugge

D14143: Make the action selector OSD independent of the other OSDs

gladhorn updated this revision to Diff 37850. gladhorn added a comment. Remove string ref in return. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14143?vs=37826&id=37850 BRANCH arcpatch-D14143 REVISION DETAIL https://phabricator.kde.org/D14143 AFFE

D14143: Make the action selector OSD independent of the other OSDs

gladhorn added inline comments. INLINE COMMENTS > zzag wrote in osd.cpp:120 > s/expansion/extension/ Good point. I copied this from the original instantiation, will fix both. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14143 To: gladhorn, #plasma Cc: zzag, plasma-

D14150: [kdecoration] Delete unused includes

zzag created this revision. zzag added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. TEST PLAN Still builds. REPOSITORY R31 Breeze BRANCH delete-unused-includes REVISION

D11198: [libbreezecommon] Add box shadow helper

rikmills added a comment. In D11198#292783 , @zzag wrote: > @rikmills Should build now. @zzag It does. Thank you REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: r