gladhorn added inline comments.

INLINE COMMENTS

> OsdSelector.qml:139
> +        }
> +        Keys.onPressed: {
> +            if (event.key === Qt.Key_Right || event.key === Qt.Key_Left) {

I'd like to hear suggestions how to do this in a nicer fashion, iterating over 
the children and checking if they are buttons and otherwise skipping them feels 
pretty ugly.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14165

To: gladhorn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to