davidedmundson added inline comments. INLINE COMMENTS
> gladhorn wrote in OsdSelector.qml:139 > I'd like to hear suggestions how to do this in a nicer fashion, iterating > over the children and checking if they are buttons and otherwise skipping > them feels pretty ugly. Personally I would add a property currentIndex in the repeater, have Keys.right/left manipulate that and then have the delegates compare that to their index. It would match a ListView pattern > OsdSelector.qml:165 > + } > + buttonRow.children[i].checked = true > + return This breaks the checked: activeFocus binding in the delegate, which means use of tab after nav keys gets out of sync. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14165 To: gladhorn, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
