KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 76 - Still Failing!

2018-03-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/76/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Mar 2018 04:06:14 + Build duration: 5 min 22 sec and counting CONSOLE

D11402: Use KDEInstallDir variables instead of custom calculated install paths

2018-03-16 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added reviewers: davidedmundson, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Consistent usage of install variables avoids mi

D11180: Reverse tooltip colors for Breeze colorscheme

2018-03-16 Thread Vlad Zagorodniy
zzag added a comment. In D11180#223070 , @progwolff wrote: > I remember that the dark tooltips felt strange to me when I started using breeze. Dark tooltips were present way back in good ol' KDE SC 4. ;-) I think because they were dark

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 75 - Failure!

2018-03-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/75/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Mar 2018 22:27:26 + Build duration: 9 min 57 sec and counting CONSOLE

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

2018-03-16 Thread Michael Heidelbach
michaelh renamed this task from "Fix BUG:390830" to "Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems". TASK DETAIL https://phabricator.kde.org/T8066 To: michaelh Cc: nicolasfella, ivan, plasma-devel, alexeymin, michaelh, ashaposhnikov, astippich, spoorun

T8066: Fix BUG:390830

2018-03-16 Thread Michael Heidelbach
michaelh added a comment. General strategy: 1. Have a config with black- or white-listed filesystems (`fuse.*`) 2. Connect to Solid to receive a signal when `/etc/mtab` changes 3. On mounts add mountpoint to baloo's `excludedFolders` cache 4. On unmounts do nothing Status quo:

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Michail Vourlakos
https://bugs.kde.org/show_bug.cgi?id=369676 Michail Vourlakos changed: What|Removed |Added CC||mvourla...@gmail.com --- Comment #23 from M

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #22 from Michael D --- Great. In that case I have no complaints (except for the quibble that I still dislike unnecessarily hiding information in the name of aesthetic flair). -- You are receiving this mail because: You are the assignee for

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #21 from Nate Graham --- Since this patch is all about poor text visibility on certain backgrounds, you can rest assured that we won't neglect that aspect of the design. -- You are receiving this mail because: You are the assignee for the

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #20 from Michael D --- Just to chime in, I still prefer having everything visible always, with an option for changing the font color. Otherwise we might as well file another bug right now about how the white text is still unreadable on certa

D11393: Neon/Kubuntu dependency installation batch script

2018-03-16 Thread Scott Harvey
sharvey added a comment. Hi there Mycroft folks. Maybe this will make your installation a bit simpler, at least for the Neon & Kubuntu users. I merely collected all the dependency steps from the original README and put them into a quick bash script. If you approve, then enjoy. If it's n

D11393: Neon/Kubuntu dependency installation batch script

2018-03-16 Thread Scott Harvey
sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Collected the various dependency installation steps and combined them into one bash script, to mak

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. In D11308#227361 , @graesslin wrote: > Sorry but no. I want to see it addressed before flipping it. We have shipped half finished things too often - especially on the look screen. Sorry but sometimes I wonder what you w

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227359 , @ngraham wrote: > In D11308#227358 , @graesslin wrote: > > > In D11308#227332 , @ngraham wrote: > > > > >

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227357 , @ngraham wrote: > In D11308#227356 , @graesslin wrote: > > > In D11308#227334 , @ngraham wrote: > > > > >

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. In D11308#227358 , @graesslin wrote: > In D11308#227332 , @ngraham wrote: > > > In D11308#227330 , @graesslin wrote: > > > >

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #19 from Marco Martin --- another version, with blur https://www.youtube.com/watch?v=KWCZwrPXfVk -- You are receiving this mail because: You are the assignee for the bug.

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227332 , @ngraham wrote: > In D11308#227330 , @graesslin wrote: > > > @ngraham Let's try to not work against our distros. Yes we could change that because we are

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. In D11308#227356 , @graesslin wrote: > In D11308#227334 , @ngraham wrote: > > > Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's about

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227334 , @ngraham wrote: > Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's about using the current Plasma wallpaper on the lock screen. Distros can and do override the d

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Radek Hušek
Pitel updated this revision to Diff 29690. Pitel added a comment. @mart you were very right to point out the `callLater` because that is exactly what was broken. The code assumed that all calls of `callLater` with different arguments are executed but in fact only those eith different function

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #18 from Nate Graham --- > i'll try also a version which has the dialog appearing in the same way, tough > i think i would prefer the wallpaper fading out either to a color or to a > blur instead +1 for blurring the current background onc

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=369676 Marco Martin changed: What|Removed |Added CC||notm...@gmail.com --- Comment #17 from Marco Mar

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #14 from Nate Graham --- Created attachment 111444 --> https://bugs.kde.org/attachment.cgi?id=111444&action=edit What you see right after the screen locks This is what you would see immediately after the screen locks. The date/time text

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #16 from Nate Graham --- Created attachment 111445 --> https://bugs.kde.org/attachment.cgi?id=111445&action=edit What you usee after any user input And this is what you would see after any user input (moving the mouse, touching a touchscr

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #15 from Nate Graham --- Also worth mentioning that we haven't decided for sure on what the default background will be. Current contenders are: - Default Plasma wallpaper - Slideshow of all the wallpapers in the wallpaper folder -- You are

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Radek Hušek
Pitel planned changes to this revision. Pitel added a comment. Ok, that looks that I did screw something. Time to investigate... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohame

[Powerdevil] [Bug 377046] Switch brightness levels smoothly, not instantaneously

2018-03-16 Thread Alexander Mentyu
https://bugs.kde.org/show_bug.cgi?id=377046 Alexander Mentyu changed: What|Removed |Added CC||notux...@gmail.com --- Comment #1 from Alexa

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Marco Martin
mart added a comment. i can confirm systray is broken for me as well, with plasma-workspace master REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Christian
Fuchs added a comment. Personal opinions, based on discussions here and on TG - fixed, (default) wallpaper has the advantage of not risking privacy, not munching power and being usable in, at least from login to desktop to lock screen, have a consistent feel for new users. Downside is th

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Andres Betts
abetts added a comment. In D11308#227330 , @graesslin wrote: > @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we h

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's about using the current Plasma wallpaper on the lock screen. Distros can and do override the desktop wallpaper but to my knowledge most don't currently override the lockscreen back

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-16 Thread Andrew Crouthamel
acrouthamel added a comment. Thanks for working on this again, it really helps. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, dav

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. In D11308#227330 , @graesslin wrote: > @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we have unreadable text. This is something which will happen, I have been too long in th

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Marco Martin
mart added a comment. In D11308#227248 , @broulik wrote: > > We can put the black bars back. Problem is because the UI is now stretched out a lot taller in order to cover the clock and switch user button I'd have to take up the entire screen.

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Marco Martin
mart added a comment. changes of this are included in D11390 , this should be closed REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas, ngraham Cc: mart, a

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. The icon changes themselves are done in D11390 . Since this patch just touches the opacity, +1 from me. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

2018-03-16 Thread Alexander Mentyu
https://bugs.kde.org/show_bug.cgi?id=362830 Alexander Mentyu changed: What|Removed |Added CC||notux...@gmail.com --- Comment #5 from Alexa

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. Sorry, I was going for whimsical, but I guess it didn't come out right. Will stick to technical. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin, abetts Cc: broulik, davidedmundson, zzag, Pit

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread David Edmundson
davidedmundson added a comment. > if you can find it in your heart to approve this Lets keep review comments purely technical please. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin, abetts Cc: broulik, davidedmu

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Kai Uwe Broulik
broulik added a comment. > We can put the black bars back. Problem is because the UI is now stretched out a lot taller in order to cover the clock and switch user button I'd have to take up the entire screen. We can make them vertical! REPOSITORY R133 KScreenLocker REVISION DETAIL

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. I strongly agree that this UI needs more background contrast, and I volunteer to spearhead the initiative to improve that (https://bugs.kde.org/show_bug.cgi?id=369676) However, this patch as is doesn't //require// that. We as the upstream vendor have control ove

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread David Edmundson
davidedmundson added a comment. We can put the black bars back. Problem is because the UI is now stretched out a lot taller in order to cover the clock and switch user button I'd have to take up the entire screen. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.or

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Wojciech Stachurski
wsdfhjxc added a comment. In D11352#227154 , @mart wrote: > yes, categories of those items need to be fixed, this was kinda forgotten as in plasma5 unfortunately the systray wasn't really using them It would be great if that happened. The

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Marco Martin
mart added a comment. In D11352#227065 , @wsdfhjxc wrote: > Doesn't seem to work for me. Only Notifications item is visible by default while there are multiple items set to be shown in the configuration. Also, changing the visibility state doesn

D11387: Ensure the KNS resource returns most recently updated for releaseDate

2018-03-16 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:a69ec23a7e51: Ensure the KNS resource returns most recently updated for releaseDate (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.

D11387: Ensure the KNS resource returns most recently updated for releaseDate

2018-03-16 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added reviewers: apol, Discover Software Store. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY

D11372: Put the refresh action on the left

2018-03-16 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:1e76a2f2dd3d: Put the refresh action on the left (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11372?vs=29645&id=29671 REVISIO

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Marco Martin
mart added a comment. In D11352#227120 , @wsdfhjxc wrote: > > If we conclude that sort based on categories + text is no sufficient I would strongly prefer using D11292 possibly with a larger default config ra

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Radek Hušek
Pitel added a comment. Phabricator:Pitel 2:0 INLINE COMMENTS > mart wrote in AbstractItem.qml:81 > what's the reson for using callLater? The main reason is to avoid calling `updateItemVisibility` from itself which might happen if `stackAfter` fires the `onParentChanged` event at wrong tim

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Radek Hušek
Pitel added a comment. I guess Phabricator does not let me only respond to inline comments. INLINE COMMENTS > mart wrote in main.qml:65 > as convention we usually don't have getFoo as names (and this is not getting > a property anyways) > i would like a more descriptive name like indexForCat

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Wojciech Stachurski
wsdfhjxc added a comment. > That seems like you are getting some javascript error in `updateItemVisibility`. Can look at what plasma shell is reporting (or paste it here)? There are no other errors except of `ConfigEntries.qml:228:34: Unable to assign [undefined] to QKeySequence` spam w

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-16 Thread Kai Uwe Broulik
broulik updated this revision to Diff 29668. broulik retitled this revision from "WIP: Support device pixel ratio in icon loader and engine" to "Support Icon Scale from Icon naming specification 0.13". broulik edited the summary of this revision. broulik edited the test plan for this revision. RE

D6313: WIP: Support device pixel ratio in icon loader and engine

2018-03-16 Thread Kai Uwe Broulik
broulik added a comment. Not really, I recently wanted to update this patch to include support for Icon Scale definition but ran into a dead-end of having to pass through the scale in 50 places... I think I'll give it a go once more but only special casing SVGs and leaving everything unchang

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Radek Hušek
Pitel added a comment. In D11352#227065 , @wsdfhjxc wrote: > Doesn't seem to work for me. Only Notifications item is visible by default while there are multiple items set to be shown in the configuration. Also, changing the visibility state does

D10251: [RFC] Use mipmap filtering in window thumbnails

2018-03-16 Thread Kai Uwe Broulik
broulik added a comment. What's the state of this? Bug 391915 just cropped up REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, al

D11375: Don't block evaluating DBus scripts if widgets are locked.

2018-03-16 Thread Kai Uwe Broulik
broulik added a comment. Please change the check to be if (immutability() == Plasma::Types::SystemImmutable) { ... return; } we don't want to introduce a way to mess up sysadmin-confined setups this way. REPOSITORY R120 Plasma Workspace REVISION DETAIL http

D11352: [RFC] Auto ordered systray

2018-03-16 Thread Wojciech Stachurski
wsdfhjxc added a comment. Doesn't seem to work for me. Only Notifications item is visible by default while there are multiple items set to be shown in the configuration. Also, changing the visibility state doesn't make any difference and the items are neither in panel nor in hidden panel, th