D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 28305. apol added a comment. Improve usability of the patch overall REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27825&id=28305 BRANCH arcpatch-D10475_1 REVISION DETAIL https://phabricator.kde.org/D10475

Re: Plasma 5.13 dependencies

On Thu, Mar 01, 2018 at 08:08:24AM +1300, Ben Cooksley wrote: > > Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks > > 5.46. The newer Qt will help us port KControl modules to QtQuick > > Controls 2 a target of this release. > > https://phabricator.kde.org/project/view/254/ > >

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau added a comment. Thanks for pasting the chat log, that sheds more light onto things :) Seems to me the spec author(s?) are not sure themselves what would be the best naming pattern (besides rtld namespacing) and are still sorting that out. Which to me leaves the choice between bei

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

ngraham added a comment. Here's the full discussion: Nate Graham, [28.02.18 14:17] Quick question: is it or is it not okay for TLD-style appstream IDs to end in .desktop? Is there any problem with this, or do clients ignore it when determining app uniqueness? (i.e. would org.blender.bl

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

ngraham added a comment. OK, I just asked him again over Telegram. Here was the reply: > Matthias, [28.02.18 14:18] > The general advice is to leave a desktop suffix out for new metadata > Having it doesn't hurt though REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricat

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau added a comment. In D10920#215888 , @ngraham wrote: > Also I forgot to mention: since my proposed change will make the desktop file name no longer match the AppStream ID, you will also need to add: > > `org.kde.plasmoidviewer.desktop

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

ngraham resigned from this revision. ngraham added a comment. Hmm, that's a good point. Let me get back to you. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D10920 To: kossebau, sebas, mart, broulik Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, je

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau added a comment. In D10920#215888 , @ngraham wrote: > Well the docs show you how an AppStream ID is to be constructed, and there's no mention of `.desktop`. I've had conversations with Matthias Klumpp, the AppStream maintainer, and he's

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

ngraham added a comment. Well the docs show you how an AppStream ID is to be constructed, and there's no mention of `.desktop`. I've had conversations with Matthias Klumpp, the AppStream maintainer, and he's indicated that my impression is accurate (and I believe he's said the validator will

D1231: Add Remote Access interface to KWayland

Kanedias added a task: T7785: PipeWire support in remote access to KWin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, schernik

D1230: GBM remote access support for KWin

Kanedias added a task: T7785: PipeWire support in remote access to KWin. REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmund

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau added a comment. In D10920#215866 , @ngraham wrote: > Appending `.desktop` is unnecessary and a violation of the AppStream spec. See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Appending `.desktop` is unnecessary and a violation of the AppStream spec. See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericCompon

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau added a comment. In D10920#215850 , @broulik wrote: > lgtm but can't really comment > > Can't go into 5.12 due to translations, can it? New strings should be fine, that has been done elsewhere before. As it's broken feature v

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

broulik added a comment. lgtm but can't really comment Can't go into 5.12 due to translations, can it? INLINE COMMENTS > org.kde.plasmoidviewer.desktop:9 > +Categories=Qt;KDE;Development;IDE; > +NoDisplay=True Will it still be accessible through KRunner? Though you probably want to use

Re: Plasma 5.13 dependencies

On Tue, Feb 20, 2018 at 8:17 AM, Ben Cooksley wrote: > On 20/02/2018 12:23 AM, "Jonathan Riddell" wrote: > > Hi Jonathan, Hi Jonathan, > > Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks > 5.46. The newer Qt will help us port KControl modules to QtQuick > Controls 2 a targ

D10925: Wrap at end of selector instead of in the middle

Zren created this revision. Zren added reviewers: Breeze, abetts. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Noticed this when scanning the code for D9773

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau updated this revision to Diff 28283. kossebau added a comment. fix unencoded & in bugtracker links REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10920?vs=28277&id=28283 BRANCH installmetadataforalltools REVISION DETAIL https://phabricator

D10016: [KFileTreeView] Manually expand tree when model tells us to

dfaure added a comment. Wow, I just wanted to say thank you. This bug has been bugging me for many years (though never enough to actually take the time to look into it...). You rock, Kai Uwe. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.k

D10896: Show config selection OSD when display button is pressed

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D10921: auto hide popup when it opened itself

mart added a comment. In D10921#215718 , @ngraham wrote: > That seems fairly reasonable to me. so, what i would like is to have this early in the cycle, so there is plenty of time to test for who has master, or neon devel unstable and sti

D10921: auto hide popup when it opened itself

ngraham added a comment. In D10921#215717 , @mart wrote: > In D10921#215715 , @ngraham wrote: > > > If we do this, I'm not sure that 3 seconds is enough for most users. A lot of people don't notice

D10921: auto hide popup when it opened itself

mart added a comment. In D10921#215715 , @ngraham wrote: > If we do this, I'm not sure that 3 seconds is enough for most users. A lot of people don't notice animated pop-ups in the corner of the screen as fast as you or I do. I would advocate fo

D10921: auto hide popup when it opened itself

ngraham added a comment. If we do this, I'm not sure that 3 seconds is enough for most users. A lot of people don't notice animated pop-ups in the corner of the screen as fast as you or I do. I would advocate for a minimum of 5 seconds, or even a bit longer. REPOSITORY R120 Plasma Workspac

D10921: auto hide popup when it opened itself

mart added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10921 To: mart, #plasma, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10921: auto hide popup when it opened itself

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when the device notifier pops up automatically, leave it open if there is

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau updated this revision to Diff 28277. kossebau added a comment. add missing setting of desktopFileName in plasmoidviewer REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10920?vs=28276&id=28277 BRANCH installmetadataforalltools REVISION DETAIL

D9773: Use 1px padding on titlebuttons

ngraham added a comment. Looks like this fixed everything but the maximize button: https://bugs.kde.org/show_bug.cgi?id=391232 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze, abetts Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D10855: Emit clicked when double click expires

ngraham added a comment. In D10855#214380 , @ngraham wrote: > Does this result in a behavior change such that a slow user with a mouse who clicks and then leaves the mouse in the same place for a moment will get a context menu? If so, I'm not su

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau added a comment. Target would be 5.12 branch REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D10920 To: kossebau, sebas, mart, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10920: Install app metadata for plasmoidviewer and plasmaengineexplorer

kossebau created this revision. kossebau added reviewers: sebas, mart, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Improves integration at runtime and with appstream

D10919: Make it possible to use QQC2.Action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6cf844edb3eb: Make it possible to use QQC2.Action (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10919?vs=28272&id=28275 REVISION DETAIL htt

D10893: Use an action group for the sort options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:fb21b21bd699: Use an action group for the sort options (authored by apol). CHANGED PRIOR TO COMMIT https://phabricat

D10919: Make it possible to use QQC2.Action

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D10919 To: apol, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10919: Make it possible to use QQC2.Action

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QQC2.Action doesn't have a visible property or iconName. For visible,

D10892: Make it possible to support exclusive action groups

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9ca92183166a: Make it possible to support exclusive action groups (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10892?vs=28269&id=28271 REVIS

D10892: Make it possible to support exclusive action groups

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D10892 To: apol, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein

D10892: Make it possible to support exclusive action groups

apol updated this revision to Diff 28269. apol added a comment. Still support Qt 5.9 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10892?vs=28193&id=28269 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10892 AFFECTED FILES src/CMakeLi

D9773: Use 1px padding on titlebuttons

This revision was automatically updated to reflect the committed changes. Closed by commit R98:bf6178561150: Use 1px padding on titlebuttons (authored by jackg). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9773?vs=25042&id=28267 REVISION DETAIL htt

D10461: GMenu-DBusMenu-Proxy

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10461 To: broulik, #plasma Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. I can't put to 5.12 as it seems https://phabricator.kde.org/D9325 didn't get into the 5.12 branch, and I don't want two versions of this patch. May I cherry-pick that commit to 5.12 and apply this patch? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DET

D10684: [Drop Job] Create proper trash file on linking

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c600f0cb823e: [Drop Job] Create proper trash file on linking (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10684?vs=27617&id=28261 REVISION DET

D10901: Add "move to device" functionality to hamburger menu

This revision was automatically updated to reflect the committed changes. Closed by commit R115:359ec78cb6ff: Add "move to device" functionality to hamburger menu (authored by Fuchs, committed by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10901?vs=28221&id=28260#toc REPOSITO

D10901: Add "move to device" functionality to hamburger menu

drosca accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D10901 To: Fuchs, broulik, drosca Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10729: Improve detecting D&D between two screen showing the same URL

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10588: No icons on the desktop by default

This revision was automatically updated to reflect the committed changes. Closed by commit R120:240d0d6fe1e5: No icons on the desktop by default (authored by jriddell). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10588?vs=27357&id=28259 REVISION D

D10915: [Kickoff / Kicker] Request closing plasmoid properly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:68667160e07b: [Kickoff / Kicker] Request closing plasmoid properly (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10915?vs=28252&id=28

D10915: [Kickoff / Kicker] Request closing plasmoid properly

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10915 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 28256. broulik added a comment. - Support radio buttons - Fix unchecking check boxes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10461?vs=28255&id=28256 REVISION DETAIL https://phabricator.kde.org/D1046

D10461: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 28255. broulik edited the test plan for this revision. broulik added a comment. - Split icon mapping into dedicated namespace and extend it a lot - Monitor menus right away so we know if there's actually a menu (appmenu-gtk-module always claims to have a

D10915: [Kickoff / Kicker] Request closing plasmoid properly

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In 0d6792c

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

fvogt added a comment. The thread on https://mail.kde.org/pipermail/distributions/2017-February/000163.html diverged into a discussion about kdesu at some point and it should not be available in PATH. This isn't something for the 5.12 branch in any case. REPOSITORY R126 KDE CLI Util

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Yes, I will push first to 5.12 both of them REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10728: Improve multi-desktop folderview behavior

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Ok, sounds and looks convincing, thanks! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-d

D10728: Improve multi-desktop folderview behavior

hein added a comment. This should go into 5.12 btw (ditto D10729 ) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohame

D10728: Improve multi-desktop folderview behavior

amantia added a comment. It adds a new entry, doesn't change an existing one. If that is not there, I see no problems, the ScreenMapper::readDisabledScreensMap() will not initialize the m_itemsOnDisabledScreensMap. That map was not saved previously, thus the folderview behaving differently a

D10728: Improve multi-desktop folderview behavior

hein added a comment. Since this seems to change the map format, is this safe to upgrade for users with existing config? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-moham

D10729: Improve detecting D&D between two screen showing the same URL

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D10729: Improve detecting D&D between two screen showing the same URL

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10896: Show config selection OSD when display button is pressed

sebas updated this revision to Diff 28251. sebas added a comment. - clean up now-dead code REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10896?vs=28202&id=28251 BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 AFFECTED F

D10896: Show config selection OSD when display button is pressed

sebas added a comment. OsdManager::showActionSelector() will delete existing OSDs before showing a new one, so we won't create multiple OSDs. That's arguably not as nice as tracking if it's already shown, but I think I'd rather avoid the added complexity of adding a check if it's already the