broulik updated this revision to Diff 28255.
broulik edited the test plan for this revision.
broulik added a comment.
- Split icon mapping into dedicated namespace and extend it a lot
- Monitor menus right away so we know if there's actually a menu
(appmenu-gtk-module always claims to have a menu even if there is none)
- Expand sections on the fly so ID mapping is correct and updating actions
works ("Undo" action in LibreOffice updates fine now)
- Fall back from menu bar to application menu on the fly (appmenu-gtk-module
always announces a menu bar even if the app might only have an app menu)
- Let "items to be added" also create new sections, fixes switching from
LibreOffice Splash to Writer where the menu is replaced entirely
- Fix updating visible/enabled property of actions at runtime
- A couple of sanity checks and crash fixes
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10461?vs=27142&id=28255
REVISION DETAIL
https://phabricator.kde.org/D10461
AFFECTED FILES
CMakeLists.txt
gmenu-dbusmenu-proxy/CMakeLists.txt
gmenu-dbusmenu-proxy/Messages.sh
gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp
gmenu-dbusmenu-proxy/gdbusmenutypes_p.h
gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
gmenu-dbusmenu-proxy/icons.cpp
gmenu-dbusmenu-proxy/icons.h
gmenu-dbusmenu-proxy/main.cpp
gmenu-dbusmenu-proxy/menu.cpp
gmenu-dbusmenu-proxy/menu.h
gmenu-dbusmenu-proxy/menuproxy.cpp
gmenu-dbusmenu-proxy/menuproxy.h
To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
