broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY In 0d6792c <https://phabricator.kde.org/R119:0d6792c4a7fc412f4710046fd90073e55194fef9> I turned the JS into a singleton but overlooked that it also accesses `plasmoid` context property. Instead of randomly calling outside objects from this library function, signal what the caller should do. The function already returned `undefined` for doing nothing, and `true` for requesting a close. Changed all call sites of this function to explicitly check for `true` TEST PLAN - Adding app to desktop from Kickoff closed menu - Adding app to desktop from Kicker closed menu - Adding app to desktop from dashboard closed dashboard - Adding an item to favorites did not close the menu REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10915 AFFECTED FILES applets/kicker/package/contents/code/tools.js applets/kicker/package/contents/ui/DashboardRepresentation.qml applets/kicker/package/contents/ui/ItemGridDelegate.qml applets/kicker/package/contents/ui/ItemListDelegate.qml applets/kicker/package/contents/ui/SideBarItem.qml applets/kickoff/package/contents/code/tools.js applets/kickoff/package/contents/ui/KickoffItem.qml To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
