D10084: Make the messages translatable

lueck accepted this revision. lueck added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10084 To: yurchor, #plasma, graesslin, #localization, lueck Cc: lueck, aacid, plasma-devel,

D10111: [Klipper] Force plain text on the edit dialog

safaalfulaij added a comment. This is how it looks currently: F5675251: Screenshot_٢٠١٨٠١٢٦_٠٧٤٨٢٣.png With the patch we'll get `Test` instead in the textedit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1

D10111: [Klipper] Force plain text on the edit dialog

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D10110: Port konsolesessions runner to Plasma5/Qt5

kossebau added a comment. Actually this runner plugin is misnomed, it does not deal with konsole sessions, but with profiles. Did not do any renaming in the port to keep port changes understandable, but would do a follow-up renaming of code and plugin name, with all "session" -> "profil

D10110: Port konsolesessions runner to Plasma5/Qt5

kossebau created this revision. kossebau added reviewers: broulik, jriddell, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Ported following changes in katesessi

D10096: Softer shadow on the screenshots

This revision was automatically updated to reflect the committed changes. Closed by commit R134:b6f1d90bd49e: Softer shadow on the screenshots (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10096?vs=25970&id=25971 REVISION

D10096: Softer shadow on the screenshots

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks fantastic. Ship it! I love the fade-in/fade-out effect. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10096 To: apo

D10096: Softer shadow on the screenshots

apol updated this revision to Diff 25970. apol added a comment. Small improvement REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10096?vs=25940&id=25970 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10096 AFFECTED FI

D10104: Port charrunner to Plasma5/Qt5

This revision was automatically updated to reflect the committed changes. Closed by commit R114:58e9e839f0a2: Port charrunner to Plasma5/Qt5 (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10104?vs=25959&id=25969 REVISION DETAIL

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. @graesslin: do elevated windows have order? (e.g. docks are above fullscreen windows, etc) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc:

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#196143, @graesslin wrote: > The region in this method is later on used for clipping. Given that you need that paintclipper fragment. I think `PaintClipper

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#196145, @graesslin wrote: > > Docks are drawn above all windows by the following code: > > > > for (EffectWindow* w : windows) { > > if (! w->isDock

D10104: Port charrunner to Plasma5/Qt5

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. good stuff! Master only pleae. REPOSITORY R114 Plasma Addons BRANCH portcharrunner REVISION DETAIL https://phabricator.kde.org/D10104 To: kossebau, broulik, jridde

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. > Docks are drawn above all windows by the following code: > > for (EffectWindow* w : windows) { > if (! w->isDock()) { > continue; > } > WindowPaintData doc

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#196026, @zzag wrote: > In https://phabricator.kde.org/D9638#195979, @graesslin wrote: > > > What you could try is using the PaintClipper to perform clippi

D10102: base scrolling on the smallest item

broulik added a comment. On my desktop it seems to improve it slightly but on my laptop I don't see any improvement, it's still way too fast. The slightest finger movement scrolls an entire page and more. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: ma

D10104: Port charrunner to Plasma5/Qt5

kossebau created this revision. kossebau added reviewers: broulik, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY As it has been part of Plasma4, is mentioned in docum

D10102: base scrolling on the smallest item

ngraham edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10102: base scrolling on the smallest item

mart edited reviewers, added: broulik; removed: Plasma. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10102: base scrolling on the smallest item

mart created this revision. mart added reviewers: Plasma, Dolphin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY after recent highdpi patches on scrolling that delegated it compl

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#196036, @zzag wrote: > File mode bits are slightly off. Fixed in https://phabricator.kde.org/D10100 REPOSITORY R108 KWin REVISION DETAIL https://p

D10101: Fix autohide panels on wayland

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY To test if the panel is under the cursor we u

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. File mode bits are slightly off. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyf

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0179f741bbd4: Updated the blur method to use the more efficient dual kawase blur algorithm. (authored by anemeth, committed by hein). Restricted Application edited projects, added Plasma; removed KWin.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25948. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Rebased to master. There was a conflict with https://phabricator.kde.org/D9879 This change reverts those changes since it is superseded by this change b

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#195979, @graesslin wrote: > What you could try is using the PaintClipper to perform clipping. But I don't know whether it's still fully functional on OpenGL.

D9993: Improve quality of images in notifications (Bug 385097)

ngraham edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, gassaf, progwolff, franciscofernandes, le

D10098: Fix drag cursor

This revision was automatically updated to reflect the committed changes. Closed by commit R115:3c70f04ebe8a: Fix drag cursor (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10098?vs=25943&id=25945 REVISION DETAIL htt

D10098: Fix drag cursor

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10098 To: broulik, #plasma, drosca, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D10098: Fix drag cursor

broulik edited the test plan for this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10098 To: broulik, #plasma, drosca, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10098: Fix drag cursor

broulik created this revision. broulik added reviewers: Plasma, drosca, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The `MouseArea` for allowing middle click to mute over

D10096: Softer shadow on the screenshots

abetts added a comment. I like it, it is definitively softer. The horizontal length could be shrunk a bit. Maybe 150, or 100? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10096 To: apol, ngraham Cc: abetts, plasma-devel, ZrenBot, progwolff, leslie

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. What you could try is using the PaintClipper to perform clipping. But I don't know whether it's still fully functional on OpenGL. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.or

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#195793, @zzag wrote: > I think this effect is ready for testing. > > Yet, I would like to have some clipping but it seems like there is no way to do this

D10096: Softer shadow on the screenshots

ngraham added a comment. In general not bad! Maybe the spread is a bit high, though? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10096 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10096: Softer shadow on the screenshots

apol updated this revision to Diff 25940. apol added a comment. unrelated change REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10096?vs=25939&id=25940 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10096 AFFECTED FIL

D10096: Softer shadow on the screenshots

apol added a comment. F5674545: vokoscreen-2018-01-25_16-50-00.mkv REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10096 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D10096: Softer shadow on the screenshots

apol created this revision. apol added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://ph

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

hein added a comment. Restricted Application edited projects, added Plasma; removed KWin. @anemeth The patch doesn't apply cleanly to current master. Would you mind rebasing it please? I don't want to introduce errors at this stage by editing code I didn't review. REPOSITORY R108 KWin BRA

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

hein added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'll push this for you (I'm interpreting Martin's resignation as withdrawing objections, knock on wood). REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To:

D10091: Combine source and version into a single piece of metadata

ngraham added a comment. IMHO the version number itself is valuable information, and I'm always a bit disconcerted when it's not available. Or did you mean something like this: Version: 2.8.1 from flathub or Version: 2.8.1 from neon-xenial-main or Version: 2.8.1 from kdeapps or

D10091: Combine source and version into a single piece of metadata

apol added a comment. Would it maybe make sense to just show the version by the displayOrigin in the different places? INLINE COMMENTS > AbstractResource.cpp:227 > +const QString version = state() >= Installed ? installedVersion() : > availableVersion(); > +return i18nc("version fro

D9944: Expose if the tablet mode switch is available

This revision was automatically updated to reflect the committed changes. Closed by commit R108:87b688daae7a: Expose if the tablet mode switch is available (authored by mart). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE h

D10084: Make the messages translatable

yurchor marked an inline comment as done. yurchor added a comment. I have removed the duplicate. Thanks. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10084 To: yurchor, #plasma, graesslin, #localization Cc: aacid, plasma-devel, ZrenBot, progwolff

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 25933. amantia added a comment. Make the code more clear, by renaming a local variable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=25799&id=25933 BRANCH master REVISION DETAIL https://phabricat

D10080: ensure the rounded rectangle of scrollbard stays round

This revision was automatically updated to reflect the committed changes. Closed by commit R31:a9a509d444bf: ensure the rounded rectangle of scrollbard stays round (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10080?vs=25894&id=25932#toc REPOSITORY R31 Breeze CHAN

D10092: [Examples] Fix build

rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. LGTM. The examples seem to have a circular runtime dependency on (at least) plasma-desktop. Is that just an opportunistic dependency (= they'd work fine you'd only just installed plasma-

D10056: [Look and feel KCM] Sync color group after copying over color file values

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cf49d415e7bb: [Look and feel KCM] Sync color group after copying over color file values (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D10016: [KFileTreeView] Manually expand tree when model tells us to

This revision was automatically updated to reflect the committed changes. Closed by commit R135:af9284852c49: [KFileTreeView] Manually expand tree when model tells us to (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabric

D9325: Use QUrl in the ScreenMapper API

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. two questions, otherwise lgtm INLINE COMMENTS > foldermodel.cpp:291 > > -const auto oldUrl = m_url; > +const auto oldUrl = this->resolvedUrl(); > could you call this at the top

D10093: Fix moving streams by drag and drop

This revision was automatically updated to reflect the committed changes. Closed by commit R115:12c5c46a9121: Fix moving streams by drag and drop (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10093?vs=25928&id=25929

D10093: Fix moving streams by drag and drop

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10093 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D10093: Fix moving streams by drag and drop

broulik created this revision. broulik added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This broke when I moved the contents into `compactRepresent

D10083: [Look and Feel] Reverse the button order

safaalfulaij updated this revision to Diff 25924. safaalfulaij added a comment. Align the warning text to the right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10083?vs=25902&id=25924 BRANCH master REVISION DETAIL https://phabricator.kde.org