broulik created this revision. broulik added reviewers: Plasma, drosca, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY The `MouseArea` for allowing middle click to mute overrules the `cursorShape` of the draggable area. By moving the middle click area to the right of the icon, we avoid this and can change the cursor to an open hand when hovering the icon to indicate something draggable. The drag area can still be middle clicked to mute. TEST PLAN - Verified hand cursor does not show up when it cannot be dragged (device list or only one device in application list) - Verified that left pressing mouse changes cursor to closed hand on drag area - Verified middle pressing mouse does not change cursor on drag area - Verified drag and drop to send applications to other audio devices still works - Verified that middle click on the list item still mutes/unmutes - Verified that middle click on the icon still mutes/unmutes - Verified that layout is correct with layout mirroring There's now a little gap above and below the icon where you can no longer middle click to mute/unmute but that's negligible imho as there's nothing visually there. Note the little dead area F5674568: Screenshot_20180125_172806.png <https://phabricator.kde.org/F5674568> REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10098 AFFECTED FILES applet/contents/ui/ListItemBase.qml To: broulik, #plasma, drosca, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
